From nobody Sat May 04 21:32:36 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VX19J64SKz5Jdbx; Sat, 4 May 2024 21:32:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VX19J3qRpz4RFk; Sat, 4 May 2024 21:32:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714858356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UDThWe/MtX0XZkYXinQek9t7eNNNH34NYWRGNeO+xz0=; b=wx2Jwc5MRChoEuQ/NnUxPxr4Fap3bIpRMRSLFgmiXV+9ywFIzldJNwwFk4JvVl0xdCf0bW ggZdz6jxL1kFle2PEdgT1bi2CLJm0Aw4OqmxLyyfKqShGQrUfw72EECm//DnZd/6aOV3z/ uHmpd4PqzjAy1SxXK2fktV2Y0zQTmsTonxWrtkjhHjrZs8a7TZw7iHvS4s96HE9XHDNi3G ef52d6d4HiUd7a6I8vyr0WHOGKxC9P21OIAElR5zCzysRdQ50OZulFPCOGajaCKovYh0Bs wjZBY0i+mg8eTHyLTabt+ndebuLlvOmsO9QgKrKnKLy8cQbyfnzfGagPsmo/7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714858356; a=rsa-sha256; cv=none; b=QEvlg5qn3kZiBpLEeiAmZS5k5d+Azmrg1iU+gHcDZ4zsHG6/UjVPFd+16bEmraDXaES0qL 9rhKNf6n9ho+lY4kLD7w2gm281NleIrJZpTYY1MxO3cBg5oJDiiu3DCUiIw2EgFTSkIL0v PjLbtWw04f+Ey6+yDubCxrKgkZdEX9dOMkPPmvOwfSAFBvnrzHxex43X3hHrNJ77BRxZ9y Nd1KbmbTSlZF7IZSDljfPsevsf+4KfNB9bYcTrKmqqgx1V+agIas0sH0v7g+DIy1tMp/6Z bCXG1Hl0MNCAanEJX1ID9AqSAedXvCjn424BW1yp0Lx5jYO9/CvEBHc6W4CI/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714858356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UDThWe/MtX0XZkYXinQek9t7eNNNH34NYWRGNeO+xz0=; b=wbqogKNC2iCe47XT+UWPgnL04sHr15K+x0qUMmXoG2vvYcGSc5toijH7QGWovm4bv7D1JQ KgOS4cqk0aEPHJbbDVQHsPiCom0U5yx2wnZ3eL69ojEC4UfkfjfJ5xxrJXkVe5n4A/rLgt gekqaP5QlhIbhnEvH81TZfCmu+mvQ3EDMbeNCR9KN2ptbBsOZP+UbHUJmwA9dvuLBXoM6/ G5rkNLw6ZuEFxgZYPs5Xz2XRE2kOsi9S8i020RuvGC7vGdx3O1ajTzUF6WmWFRBpSqkQMx NohzWcqvXiWDd9V+BGcWZiPg+mf077XkSBxTxGw4LcmH0JgybJIcJ0NQQrxgng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VX19J3RXrzmD6; Sat, 4 May 2024 21:32:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 444LWaDF089089; Sat, 4 May 2024 21:32:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 444LWaDF089086; Sat, 4 May 2024 21:32:36 GMT (envelope-from git) Date: Sat, 4 May 2024 21:32:36 GMT Message-Id: <202405042132.444LWaDF089086@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 3f65000b6b14 - main - nfsd: Fix Link conformance with RFC8881 for delegations List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3f65000b6b1460a7a23cd83014bb41a68d1a8a19 Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=3f65000b6b1460a7a23cd83014bb41a68d1a8a19 commit 3f65000b6b1460a7a23cd83014bb41a68d1a8a19 Author: Rick Macklem AuthorDate: 2024-05-04 21:30:07 +0000 Commit: Rick Macklem CommitDate: 2024-05-04 21:30:07 +0000 nfsd: Fix Link conformance with RFC8881 for delegations RFC8881 specifies that, when a Link operation occurs on an NFSv4, that file delegations issued to other clients must be recalled. Discovered during a recent discussion on nfsv4@ietf.org. Although I have not observed a problem caused by not doing the required delegation recall, it is definitely required by the RFC, so this patch makes the server do the recall. Tested during a recent NFSv4 IETF Bakeathon event. MFC after: 1 week --- sys/fs/nfs/nfs_var.h | 2 +- sys/fs/nfsserver/nfs_nfsdport.c | 12 +++++++----- sys/fs/nfsserver/nfs_nfsdserv.c | 11 +++++++++-- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/sys/fs/nfs/nfs_var.h b/sys/fs/nfs/nfs_var.h index 578fb3ce1340..950e0c097457 100644 --- a/sys/fs/nfs/nfs_var.h +++ b/sys/fs/nfs/nfs_var.h @@ -713,7 +713,7 @@ int nfsvno_rmdirsub(struct nameidata *, int, struct ucred *, NFSPROC_T *, struct nfsexstuff *); int nfsvno_rename(struct nameidata *, struct nameidata *, u_int32_t, u_int32_t, struct ucred *, NFSPROC_T *); -int nfsvno_link(struct nameidata *, vnode_t, struct ucred *, +int nfsvno_link(struct nameidata *, vnode_t, nfsquad_t, struct ucred *, NFSPROC_T *, struct nfsexstuff *); int nfsvno_fsync(vnode_t, u_int64_t, int, struct ucred *, NFSPROC_T *); int nfsvno_statfs(vnode_t, struct statfs *); diff --git a/sys/fs/nfsserver/nfs_nfsdport.c b/sys/fs/nfsserver/nfs_nfsdport.c index 5eb16564cf00..6f5b2855bcf0 100644 --- a/sys/fs/nfsserver/nfs_nfsdport.c +++ b/sys/fs/nfsserver/nfs_nfsdport.c @@ -1655,8 +1655,8 @@ out1: * Link vnode op. */ int -nfsvno_link(struct nameidata *ndp, struct vnode *vp, struct ucred *cred, - struct thread *p, struct nfsexstuff *exp) +nfsvno_link(struct nameidata *ndp, struct vnode *vp, nfsquad_t clientid, + struct ucred *cred, struct thread *p, struct nfsexstuff *exp) { struct vnode *xp; int error = 0; @@ -1671,9 +1671,11 @@ nfsvno_link(struct nameidata *ndp, struct vnode *vp, struct ucred *cred, } if (!error) { NFSVOPLOCK(vp, LK_EXCLUSIVE | LK_RETRY); - if (!VN_IS_DOOMED(vp)) - error = VOP_LINK(ndp->ni_dvp, vp, &ndp->ni_cnd); - else + if (!VN_IS_DOOMED(vp)) { + error = nfsrv_checkremove(vp, 0, NULL, clientid, p); + if (error == 0) + error = VOP_LINK(ndp->ni_dvp, vp, &ndp->ni_cnd); + } else error = EPERM; if (ndp->ni_dvp == vp) { vrele(ndp->ni_dvp); diff --git a/sys/fs/nfsserver/nfs_nfsdserv.c b/sys/fs/nfsserver/nfs_nfsdserv.c index 8141ee6cbdb6..0c8bda6dc6a6 100644 --- a/sys/fs/nfsserver/nfs_nfsdserv.c +++ b/sys/fs/nfsserver/nfs_nfsdserv.c @@ -1797,6 +1797,7 @@ nfsrvd_link(struct nfsrv_descript *nd, int isdgram, char *bufp; u_long *hashp; struct thread *p = curthread; + nfsquad_t clientid; if (nd->nd_repstat) { nfsrv_postopattr(nd, getret, &at); @@ -1858,8 +1859,14 @@ nfsrvd_link(struct nfsrv_descript *nd, int isdgram, NULL); } } - if (!nd->nd_repstat) - nd->nd_repstat = nfsvno_link(&named, vp, nd->nd_cred, p, exp); + if (!nd->nd_repstat) { + clientid.qval = 0; + if ((nd->nd_flag & (ND_IMPLIEDCLID | ND_NFSV41)) == + (ND_IMPLIEDCLID | ND_NFSV41)) + clientid.qval = nd->nd_clientid.qval; + nd->nd_repstat = nfsvno_link(&named, vp, clientid, nd->nd_cred, + p, exp); + } if (nd->nd_flag & ND_NFSV3) getret = nfsvno_getattr(vp, &at, nd, p, 0, NULL); if (dirp) {