From nobody Fri May 03 17:02:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWHDL1RpGz5J7Mg; Fri, 3 May 2024 17:02:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWHDL0WWPz45qM; Fri, 3 May 2024 17:02:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714755762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApqVmD5rswVoFuWPxlAuItdw0UtJvz6hI9khQhg018g=; b=a0aMGRsH8m+SjKz+CEI9STO5zSEmxL6qQHMR1up4Pj/Rgu7KGJQex3q+yPt9C1fb89wIvL ECeu+t/JeFRSaIUY3sElLqrjIU8HX/KKZzC8+Zf+sj7r/IK0XTHUZxwRQlAa4uSkT+Qk+j N9rn9UYaxoItm6JdJL0zvhDkFgqSupg2M1akskP0Y1U5/L6+hnRWy/PjzixIQop3wHd6lU ee0+mTMVCoQViUeMNZ0QDHmJ++cDsOQRyHWoRdlpvKH5XZ3CRYd+tDlH/9mvdpAhfi1zvY i0nX75wIVAFbtOEWZsK2hYHR1kpsQQJSoDoBlKsG16J4eJ7Kj2agk15D5OYzpw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714755762; a=rsa-sha256; cv=none; b=SJgp2c1DXyrt5JlAJk1OvAMHlAunOJ8xTd7gque+pbgL5P5zeuGuek4IPtMqPgaxTiYdfe +BVXwsjaXrmOCl0l1wFsFniBgP7POJjcFfYisbU/Kz8PjzDyyLDyrASmghGa9ZBIZMGUhz /8DPHPRqSWejoghEQImPpyw/nJh/EEPnn2EZrJlubRcVKWg/5au12sdHiYy2HbOwkN0qEC 5/rnCjt1+PzwooFCbtE/pHNzYamkMdXqmEiWZknIwXKlro/mQt6WMIlXcPqVzGdraavlQX PzTFZD7uPqKV+ZvnarhG0phY4eMI9+BuTXUm1+q0B8QxiBL2jcF9zwCEgLAuzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714755762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApqVmD5rswVoFuWPxlAuItdw0UtJvz6hI9khQhg018g=; b=R+W7nt81geUAXZhz8yqcvwCVXahwVj0ebpSAXPhHb5MnFUllW/9mNf0jqPx5VPToDZkOfZ 0OWB8m0gnQhATOV5yWQJl2JSQYc5NmR004nXkxlXosHBP4HzMhLcw8LkoaQQ+ofShYcdwV AdUphMwW2ltaP6a9GLV9SsxKqNKUNvWASYyS7b+GRiB7ng6ravO5elUH5qD3N9JhvNH3Xb JmEruUQ177jUbw5KHOfhcxoClNSYXSckGGcmSbVmS+YEDmuaROpJHb1RL7em/jpdszfGK0 zwQdDHALePIJH/QHUpKl1kHydrmVfAK4dya8olljsJcnjug52sTyLMppbKskWw== Received: from [IPV6:2601:644:937f:4c50:401e:498a:e125:d6ae] (unknown [IPv6:2601:644:937f:4c50:401e:498a:e125:d6ae]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VWHDK3YRFzZbH; Fri, 3 May 2024 17:02:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 3 May 2024 10:02:39 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: aa34b1d20e44 - main - vmrun.sh: Add arm64 support Content-Language: en-US To: Gleb Smirnoff , Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202405011301.441D1xEc000624@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/3/24 7:58 AM, Gleb Smirnoff wrote: > On Wed, May 01, 2024 at 01:01:59PM +0000, Mark Johnston wrote: > M> vmrun.sh: Add arm64 support > M> > M> For now, we enumerate disk devices before network devices. This is to > M> work around a problem wherein u-boot remaps BARs during boot in a way > M> that bhyve does not handle. Some discussion and experiments suggest > M> that this can be handled by having bhyve not map BARs during boot on > M> arm64; until a solution is implemented, however, this workaround is > M> sufficient for simple usage and doesn't have any real downsides. > M> > M> The console and bootrom are specified slightly differently versus amd64, > M> and a few of vmrun.sh's command-line options are amd64-only. > M> > M> Reviewed by: corvink, jhb > M> Sponsored by: Innovate UK > M> Differential Revision: https://reviews.freebsd.org/D44933 > > The share/examples/bhyve/vmrun.sh is not really an example, but a good > standalone tool. I use it all the time without any modification, and I > guess many other people do, too. > > Maybe time to move it to some path that is in the default $PATH? I really think we should instead be building a tool like vm-bhyve from ports, either by importing that directly, or perhaps rewriting it in lua and having that eventually replace vmrun.sh. -- John Baldwin