From nobody Thu May 02 22:02:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VVnwb3RSYz5K7bZ; Thu, 2 May 2024 22:02:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VVnwb2x7dz4DTH; Thu, 2 May 2024 22:02:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714687343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QOY0Xx6PoFDxPGEVPyoMlhrycqBxRdmLC1w0r8rh04c=; b=sQmHEWwPXvYNHQgnHNhpJePNkou3EetYS68tSYyOKPbrCQUfjVKzsitz79Hn89PlZb1GSX q9IMmnNri3UIWOxiUfm4DqRBISu6l1E/OhbyhT+uBHmNAo9zAj9jOi0vP5tqAusr9K3yfo 1qLRXA0MLytSo/+j+br8LUvVyGAUUg6gd0ip6UPyhsifKonm+jlPszV4lFPN12eE/AVyuC OPlo/1hmzBqbXkGsc/kamrNTKgHpvKDS4AzIOxkBQ0rKON28XAA5jfua8ttIwGJkdn+r3Q 6SuoFQmfhJsZOpaWzbH4PKBxSSvZR3IHr4u//Gw/8Xy+wmYzc7i2kNY5zkdNMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714687343; a=rsa-sha256; cv=none; b=d3/hqmOGxyAiEc3pMyXwfs8PPxi1XzGtpIz5AFcEAXKoW0d+bt7wlQv3HpzWy12U1h3WFp Yyu09iIG+GXTdiLXOMxvsZJNzCLIrJiHbys2/4SfPC4AIndP/mT7EjNYFPZp0sNMUt/Xnj xA634jcN3YmvYLrgDLkw4w1el8dItoU/PkB6SK05/sCzWfYPA1fF2tekRb3TwTyfU1EPP6 lE3o2sxvuv3h9hueh55ibcwObjsN0LoBrh8kqv3MN2Aa1EALxoBQuElNYAS6fKXNn0NOdT 7da+K3XZKrKTVeyrAJK2pE0ytUftbs/BGKeezsrWbaMrzVW7CpdyFn33eJLNqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714687343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QOY0Xx6PoFDxPGEVPyoMlhrycqBxRdmLC1w0r8rh04c=; b=clOsi5Pijc5BjAgW0Oc7uTL8e2FLvDJm26RR/NRPlNomIRS7hospK/evoqDYuuqX+2Vzxh EPKwXTOjEtjfPpTn8rjU2atSiIMv2xPvmd/eXkIkfjZhsTQGqH3R/kCCLXL0vinLF5a4wI agzbjZsx4G0k0tlH3zxBt5/XABG7YMp9cuZZA5gk7AywNJQW4yGRkECYGrRcUsEqHOmy1p uAM/GbVBn70SJWMWcuAJ1ndTqM846u0n0+meR8mJ0oWJTKIDmyXc+jTx2UrPQBDYgftLny hBTrCqRuwmGtlNytGzMrNCcLsdu/dCjo9q0M0qGaqdXAuyaZSiy1K/kbXuTWeg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VVnwb2XxBzKnj; Thu, 2 May 2024 22:02:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 442M2NO0059127; Thu, 2 May 2024 22:02:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 442M2NHa059123; Thu, 2 May 2024 22:02:23 GMT (envelope-from git) Date: Thu, 2 May 2024 22:02:23 GMT Message-Id: <202405022202.442M2NHa059123@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: d21c19d4127b - main - cam/iosched: Document latency buckets correctly. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d21c19d4127bb58ab8de83dc944c3ebfc3b43af5 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=d21c19d4127bb58ab8de83dc944c3ebfc3b43af5 commit d21c19d4127bb58ab8de83dc944c3ebfc3b43af5 Author: Warner Losh AuthorDate: 2024-05-02 21:58:55 +0000 Commit: Warner Losh CommitDate: 2024-05-02 22:02:04 +0000 cam/iosched: Document latency buckets correctly. Document how latency buckets are actually computed: They are a doubling from 20us to 10.485s by default, but based at kern.cam.iosched.bucket_base_us and increase with a ratio of kern.cam.iosched.bucket_ration / 100 from one to the next. Sponsored by: Netflix --- sys/cam/cam_iosched.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c index b83ab9699425..471e6c355d69 100644 --- a/sys/cam/cam_iosched.c +++ b/sys/cam/cam_iosched.c @@ -1070,7 +1070,12 @@ cam_iosched_iop_stats_sysctl_init(struct cam_iosched_softc *isc, struct iop_stat CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_MPSAFE, &ios->latencies, 0, cam_iosched_sysctl_latencies, "A", - "Array of power of 2 latency from 1ms to 1.024s"); + "Array of latencies, a geometric progresson from\n" + "kern.cam.iosched.bucket_base_us with a ratio of\n" + "kern.cam.iosched.bucket_ration / 100 from one to\n" + "the next. By default 20 steps from 20us to 10.485s\n" + "by doubling."); + } static void