From nobody Wed Mar 27 13:35:33 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V4SNP3zMGz5FV7G; Wed, 27 Mar 2024 13:35:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V4SNP2H00z4vCG; Wed, 27 Mar 2024 13:35:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711546533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GzgorWJ8E6ZlbyHqCZ5yFReSr2OqnzQmzl7IJguEopo=; b=ao9uCcv+Piww5iXGvRI3WrxBbrP8T3kPpJNJm9FNgxLDF4YM6leHhpHz+AxYB2/2lmuVCx vfSkjkSMWN+jArUK/Ucufg7AmLjQLe7mUNhGyRV1ebyChoFTZxg8m+gcRcsJqpkL8sbYq2 NuQz3PxPXYA1Cw7j1eF/36rbP3MjI7Ob3qp3WRP4KqWYOKLd2Fvzzj4A3kE5k/RuqHNQ8Y l4fAi4BNfzv97hkeKQHZ1nW7Q5OP2iwrUQrkQX20I2VD5ceMZlQ/TgJuvUr+ozNigWtFdO q2LHTe6YKqL44QZ8dGLNATIDBT3NMO6gRHoXTtgm90EIYIaJJ73Q/1V3NdftTA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711546533; a=rsa-sha256; cv=none; b=I4d4gonvt+ImjFyE6ofgbikItYLpKoeRJVidsF+2XGtGCJW2chFLrhlZ7/QVtZUoonXPoP 7xC2vPmDY+Ad4eOJEYEzRpBlYbzVkJEGiJ0N9dx9HHRMhTspZijg5wJk7WzOln6ZLyG9RE Oi4LyecuS8JvCovrIhP0ntHfSw/cgaul0glcWYPu0tOjHaU4cDJka13uyqdEd+BigKt2NQ LeaNbtnPhJhny7raZUZe4XYlKXTFMxAnBDOf7GuTjDRAnzWF3NXxTXZfeJ9HSLKDlXma9H EwTMp3gzqETsKV7KW82X2Rkw2YQFumr5gzwa+guuXbpNm2z5bcLs+p+gTIpQVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711546533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GzgorWJ8E6ZlbyHqCZ5yFReSr2OqnzQmzl7IJguEopo=; b=Dm0upzq5H8wp3CUvTlVr3wQDHFNLqDuVfh/f9ZMXY+W7nPbAzckBLleR2MMC0P+fPGbweL 8NErkul4S8tFnWeN5yXqm0+LedYuikERxnDRMkxIvh0NB9S/OWRJN21fsdjTG94+xSsif4 5G4nfgK9nI7Ho5mT8f0eQGyA2dr5K11wPSwYu9Uo2jToAxiKFx4Bq771Y8+T/mBzq/mUIP awCVzKEidtw3TQGpAS8P4fQ0DjYCuXxWJeFbQjVi3vwLhs+11RDOA6MRe2SFB4TqI2bMu3 UWLjT206tapQKNk3AghRSlOVOCUIqRolJ+tS+tny/XHe9sysI53YCyPcYS9QYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V4SNP1sggzlXJ; Wed, 27 Mar 2024 13:35:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 42RDZXIH023679; Wed, 27 Mar 2024 13:35:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 42RDZXRv023676; Wed, 27 Mar 2024 13:35:33 GMT (envelope-from git) Date: Wed, 27 Mar 2024 13:35:33 GMT Message-Id: <202403271335.42RDZXRv023676@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: ed505f893ab0 - main - tcp bblog: use correct length List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ed505f893ab08aa61e2a1046ae54df357a108260 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=ed505f893ab08aa61e2a1046ae54df357a108260 commit ed505f893ab08aa61e2a1046ae54df357a108260 Author: Michael Tuexen AuthorDate: 2024-03-27 13:31:48 +0000 Commit: Michael Tuexen CommitDate: 2024-03-27 13:31:48 +0000 tcp bblog: use correct length The length of tldl_reason is TCP_LOG_REASON_LEN, not TCP_LOG_ID_LEN. No functional change intended. Reported by: Coverity Scan CID: 1418074 CID: 1418276 Reviewed by: glebius, rscheff MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44510 --- sys/netinet/tcp_log_buf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_log_buf.c b/sys/netinet/tcp_log_buf.c index 5e168c5066e4..7b937958a4fb 100644 --- a/sys/netinet/tcp_log_buf.c +++ b/sys/netinet/tcp_log_buf.c @@ -2442,7 +2442,7 @@ tcp_log_dump_tp_logbuf(struct tcpcb *tp, char *reason, int how, bool force) if (reason != NULL) strlcpy(entry->tldl_reason, reason, TCP_LOG_REASON_LEN); else - strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_ID_LEN); + strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_REASON_LEN); entry->tldl_ie = inp->inp_inc.inc_ie; if (inp->inp_inc.inc_flags & INC_ISIPV6) entry->tldl_af = AF_INET6; @@ -2532,7 +2532,7 @@ tcp_log_dump_node_logbuf(struct tcp_log_id_node *tln, char *reason, int how) if (reason != NULL) strlcpy(entry->tldl_reason, reason, TCP_LOG_REASON_LEN); else - strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_ID_LEN); + strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_REASON_LEN); entry->tldl_ie = tln->tln_ie; entry->tldl_entries = tln->tln_entries; entry->tldl_count = tln->tln_count;