From nobody Thu Mar 21 20:30:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V0xsp1SNJz5FS3h; Thu, 21 Mar 2024 20:30:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V0xsp0zT2z4Wxq; Thu, 21 Mar 2024 20:30:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711053022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gBOEoC74bi2et6razlSNJLQyqlguEqUXOioShMuHTnY=; b=QufVA5Bx3iBF+GoV9u0DkMjF3FlWI3kjbKT6nFXy2hsp5hYus1hftkjeIF8bLm+VUbiHT8 XP7o9QzK/QEtmnJ85BMXATcf20PiknfzJxv98yJtTgvGHFLLHxp1NNncboc/fR5ryUq/s/ SHYQ+yFZVXe34N2p/y76rFUyknXGhP2P+n2MijuTMSc4tWl4Cgoqj4MQp6t5vPMTYnHv54 QP/+Yj3DV6S+N7KzfWFoWD5EpxaGGQa2zCJhvxNU4mKd1cm0uYOAfMbaan9dpmusRSzKXX fh2J30L7nzaGGSfajP1LP2W+/0VX77zSRcb8LC/9OD74OYMc4v36M9O3Cw979Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711053022; a=rsa-sha256; cv=none; b=Y24Q/H6YpU7wVcEXs5NpU8c9X38YHEP3TpH/03HjW6i8gN1Ptuqlg3aVgZ8+RkBtGFVTxn KMoV1javNSkLEqvVaLzTkzTc0HOo/+HGyV9ML42bXDHFM1U592b7idSEssbwMr5JNNGb6M d/r6gw/1E1wFNTcqRyBZWGEyoetwLk0F/TQe4A/8qScfcdAZDC45JS/I3hDExHX4AoAfrQ bR99xpBOdQSOlOgP9PTcvyi3J27j4PNRECb7A2obDeC5W9LOr62uYd1uCSMTCghOrHFnsM UJeel8Ne9TpIBYIzsYf8A6Pf+mlpi2kanGG65F3vk2d4ryntnBoGHFuA0f2d/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711053022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gBOEoC74bi2et6razlSNJLQyqlguEqUXOioShMuHTnY=; b=g7xA2iK6krk4Dr2JXW+8FkQHEmt4gh0ZxZukFLAjdPpQi5PQ0WpBo0b6GLejx/KSBIGW4k /V5WnGSFj7QqcR5of/c71/3VZnPksA+1LS++RXqmFxOz2AetgcY2Z3mNhob2jryomjDMyY unPmq8XVsVWjIHX33Dce9P3pEBo96dkZvJ00UPOXU31jD7cVOqAMwiYQyilkDyngcfDShQ SPYsqagjUlaeT80Y35JWu2hQ6maZ66o7fq0BhobTgVq49PtNNntr2yP29fWe/kp2cXl1fa 0BZWzFCwetjwTmib3UUjjmsL1rQehKEo+Ff35nrfBvYrXdbRmfaIR2ZnqwSiHw== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V0xsn6y0Xz16my; Thu, 21 Mar 2024 20:30:21 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id DA7C32A430; Thu, 21 Mar 2024 21:30:20 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: git: f0620ceeccf0 - main - Fix building of several libclang_rt libraries for powerpc64 and powerp64le From: Dimitry Andric In-Reply-To: <20240321162153.0048ccba@ralga.knownspace> Date: Thu, 21 Mar 2024 21:30:20 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <628CFE63-DC26-48E9-8425-B4C3C760C653@FreeBSD.org> References: <202403211711.42LHBlpr041561@gitrepo.freebsd.org> <20240321162153.0048ccba@ralga.knownspace> To: Justin Hibbits X-Mailer: Apple Mail (2.3731.700.6.1.1) On 21 Mar 2024, at 21:21, Justin Hibbits = wrote: >=20 > On Thu, 21 Mar 2024 17:11:47 GMT > Dimitry Andric wrote: >=20 >> The branch main has been updated by dim: >>=20 >> URL: >> = https://cgit.FreeBSD.org/src/commit/?id=3Df0620ceeccf070a69352105c5dbc23cf= f499a732 >>=20 >> commit f0620ceeccf070a69352105c5dbc23cff499a732 >> Author: Dimitry Andric >> AuthorDate: 2024-03-21 13:53:36 +0000 >> Commit: Dimitry Andric >> CommitDate: 2024-03-21 17:05:25 +0000 >>=20 >> Fix building of several libclang_rt libraries for powerpc64 and >> powerp64le=20 >> I reorganized the libclang_rt Makefile in e77a1bb27574 to make it >> more readable and maintainable, but the check for 32-bit powerpc was >> wrong. This caused almost no libclang_rt libraries to be built for >> powerpc64 and powerpc64le. >>=20 >> PR: 262706 >> Reported by: tuexen >> Fixes: e77a1bb27574 >> MFC after: 3 days >> --- >> lib/libclang_rt/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/lib/libclang_rt/Makefile b/lib/libclang_rt/Makefile >> index 46f7fdf814be..984da3f34156 100644 >> --- a/lib/libclang_rt/Makefile >> +++ b/lib/libclang_rt/Makefile >> @@ -67,7 +67,7 @@ SUBDIR+=3D ${SD_CFI} >> SUBDIR+=3D ${SD_SAFESTACK} >> SUBDIR+=3D ${SD_STATS} >> SUBDIR+=3D ${SD_UBSAN} >> -.elif ${MACHINE_CPUARCH} =3D=3D "powerpc" >> +.elif ${MACHINE_ARCH} =3D=3D "powerpc" >=20 > If you're excluding 32-bit powerpc you'll want to also exclude > powerpcspe. Though, you could just omit both powerpc and powerpcspe > from the list here, since there's no default error case. I wanted to keep the place open, for if at some point there would be = some sort of support for either of those architectures. But I guess the thing is better written as: ... .elif ${MACHINE_CPUARCH} =3D=3D "powerpc" . if ${MACHINE_ARCH} =3D=3D "powerpc64" # some subdirs . elif ${MACHINE_ARCH} =3D=3D "powerpc64le" # other subdirs . else # remark about nothing being available yet . endif .elif # other CPUARCH values -Dimitry