From nobody Thu Mar 07 19:05:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TrJfn0bPwz5Dd2Y; Thu, 7 Mar 2024 19:05:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TrJfn028Vz4Y74; Thu, 7 Mar 2024 19:05:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709838353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hmB768MwGH6d9bkqpjXZJ00d4VvfSYhfhfiy0VmzPNY=; b=ZzfB4KZ2VE8hiP/HVKXN70mCxwLPSnB/5EkkTwyfmzqmgv+2tF8EI75OIJ83qGn8F0DvAr nueFptdMbBxgVFqKUgbTsl25ftDcnVPI2mUGvPZypiBXr8jne6aodGryDb6UweHLeC3gGO 03CvnwKg9gZPfT4QcQpgE1+fReZW2SdYd/Fahp+DHZED79qosAlp8C4DhNanAvwNGihnCm QiRhFV1YI9HUifS81CBnHtXickEHmMoAt90PZ6xw7rrjYk1TnqZQkVnbxCVxsWPNu/0GE9 kU3xY9sZx/xC3N2So8mDXpE3rW5J0rO53ZQe6IOj2E4oWaJpmw92ewtR2sPFPA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709838353; a=rsa-sha256; cv=none; b=dzFsGFYCwoEzF9F+dWHXZcMlT1IZrHJkbFKiH5XEL+61ePDiC4oGBjzfnkRD9dfdZJuEqY 0aRYyZgDAowIXe5J8lyNvw4/uSPKj/k5FOg1ngWNU3/dKuGrKm59y+I2SLycWf5qXwg/Mb zzQIFG6sV6IPYbz7+HLwuqx3AA8NHcIXZs0/Y2VEfgIrrf9zZvbEsNnwxsnsA/MX07I0tQ g/MvEXWGFFdV/Z39GYvRtuGFr5ZVQqqKEcTCsbVpvzAcRtFs0B29IEYBIcdngWD1Gq6xPK 2JsFlJuU/qNvk5nhKr1VTXB2xYeEGN751C6sREl7v1z59LpdQdiP+DWxEoXvdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709838353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hmB768MwGH6d9bkqpjXZJ00d4VvfSYhfhfiy0VmzPNY=; b=tUlWW2GBCWRztsCUgj4pk04JnIewR3GulkHoKqPDNr26QvjyDDWUMyv+tJhj76UCQVVZkw uVL00Q+YViZgdUQQNICjK0Q9a2wO2C7Wx3pCQn+Ht7WcRzBgdITTht5EjgKDYNyZXnJf9o tK/CtnsfEtLbwU4a4Ya7k0By5L/9EWhMit78FDVWx3oigkwgNNwVytutXYTNxw0MzqgOnu m79TYzb4pwTB4iaLykZ7fTLujumTwSdzMi3KCNRrqZ2LfhtgMwHAXvoAliOsc04Uw3WZ4X QL3b6caow/lOSQ3vjwbhkECjc2XzAIyIZlQ7we0RXcKDaeZSAXS9heluO6Q3EA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TrJfm6l0ZzmcX; Thu, 7 Mar 2024 19:05:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 427J5qF8030443; Thu, 7 Mar 2024 19:05:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 427J5qJw030440; Thu, 7 Mar 2024 19:05:52 GMT (envelope-from git) Date: Thu, 7 Mar 2024 19:05:52 GMT Message-Id: <202403071905.427J5qJw030440@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: fe52c3384c61 - main - nvme_sim: Add comment about the is_failed test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fe52c3384c61a092a305deebc063968a47dc854f Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=fe52c3384c61a092a305deebc063968a47dc854f commit fe52c3384c61a092a305deebc063968a47dc854f Author: Warner Losh AuthorDate: 2024-03-06 21:30:01 +0000 Commit: Warner Losh CommitDate: 2024-03-07 19:05:28 +0000 nvme_sim: Add comment about the is_failed test We only see a request with a failed controller while we're in the process of failing the controller. Add a comment to that effect. Sponsored by: Netflix --- sys/dev/nvme/nvme_sim.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/dev/nvme/nvme_sim.c b/sys/dev/nvme/nvme_sim.c index 70bb95602bf8..f561756f99b7 100644 --- a/sys/dev/nvme/nvme_sim.c +++ b/sys/dev/nvme/nvme_sim.c @@ -270,6 +270,10 @@ nvme_sim_action(struct cam_sim *sim, union ccb *ccb) case XPT_NVME_IO: /* Execute the requested I/O operation */ case XPT_NVME_ADMIN: /* or Admin operation */ if (ctrlr->is_failed) { + /* + * I/O came in while we were failing the drive, so drop + * it. Once falure is complete, we'll be destroyed. + */ ccb->ccb_h.status = CAM_DEV_NOT_THERE; break; }