From nobody Fri Mar 01 23:04:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TmkF42pBBz5DCtH; Fri, 1 Mar 2024 23:04:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TmkF402hYz4J2J; Fri, 1 Mar 2024 23:04:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709334280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Gggo3id9Ot/46wjWoucTCqzBvYHtaLJrfIhbBMZbxpw=; b=NRTwfuuDqsCgfF/A4LaMsuA9GTpK48imyYd5MatfIOGbVmtZzx05XqCqnquw3yJOpNbHad tySIkS0tkuSXsLlYl4i9iC8DL57rLD8vBoPfatcNHeXSyGas0fl1YHcmkOmIyy+80vO/9j /z/cHqRActshV4oTl6K6x46eQrGp7vU/sQPyhXXFvZKjMc2kCfyjHFvur6LydGvFbBwi+L euIRQgXYqx8dQ6FaodRuyE90iS0tLcK6xw9iJvWP9Sqh711uN4YUjGq3i3snnCGWeKjrC2 XOKuFiMwr5R1wEvLHCAzRtWwN3c5lI9OldTGkM5KWyL49jcjllclOKA69ADYvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709334280; a=rsa-sha256; cv=none; b=huCfO08riR9t631lTX3SRWh52zUvX7xwjxU52swI6csz7JAZ7rdigDZCt6M78PuHlwC9Ky zEWpFvy2UmjHQ+yVtEya5kVJtQBwO+88uQRJpYsa1WoHCUrP8ONNrWNRW6Y+b81F47t3ev 9pKsr2uhX/sizmJvUj7cOJA16gvV5Im1EkxLrwsiOGhP8OXh4DOXJJy38EaLRBZ9/ksAGr txtYhkK/E2cLAWCpr6wEMe69RCTeTADYNeDDZe2TKY1dSg5iRjXCY/Rt2/3K/lpaVbvKEK 7eFrEdc7Z5huMRuloFaTKGeAVF4N82dPxPuTr9Tpr0HH6/yLOJHg8cv/U4dgYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709334280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Gggo3id9Ot/46wjWoucTCqzBvYHtaLJrfIhbBMZbxpw=; b=am/tToTWQ9zUHthEXLQ1ZBfUQL4yHsJKjUcnLFuPP4929IfhpCrr/P3ixzaIQdJ19I42L5 ipwTPYIwwqsnuzmyh6zeTrFUFQiWMwXiZQwWxsaqQVD0reOfw8EWl8TD724joqWziiyBSV 4bxuScx7aIOpzU9xQPX3jHhrcVrMGPSjnk7JZNFD0LL6KsvkN5MvA/d5Kh9hDizjXjvC8L zPqFNne6q92UJVXCXxlN5IVLgiFoA9m4oZMXWcI+n/YEpr97OUPhA2814YcbHi4pKhcIRM WEL1RyFFXELjW1htm8rFVOrinsHQgfWHU9GPPknNdhRLAnHZ07OO3B/Am8OxrA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TmkF36mXkzlmW; Fri, 1 Mar 2024 23:04:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 421N4dKZ039515; Fri, 1 Mar 2024 23:04:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 421N4duD039512; Fri, 1 Mar 2024 23:04:39 GMT (envelope-from git) Date: Fri, 1 Mar 2024 23:04:39 GMT Message-Id: <202403012304.421N4duD039512@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: c5246cb7b015 - main - nvme: Report only the unknown bits List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c5246cb7b0153730101163381576e9b0e91c73a5 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=c5246cb7b0153730101163381576e9b0e91c73a5 commit c5246cb7b0153730101163381576e9b0e91c73a5 Author: Warner Losh AuthorDate: 2024-03-01 23:03:19 +0000 Commit: Warner Losh CommitDate: 2024-03-01 23:04:27 +0000 nvme: Report only the unknown bits When we get a smart error that's unknown, report only the unknown (reserved) bits of the Critical Warning Bitfield. Sponsored by: Netflix --- sys/dev/nvme/nvme_ctrlr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index b29512455fda..0d33454125bd 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -650,7 +650,8 @@ nvme_ctrlr_log_critical_warnings(struct nvme_controller *ctrlr, if (state & NVME_CRIT_WARN_ST_RESERVED_MASK) nvme_ctrlr_devctl_log(ctrlr, "critical", - "unknown critical warning(s): state = 0x%02x", state); + "unknown critical warning(s): state = 0x%02x", + state & NVME_CRIT_WARN_ST_RESERVED_MASK); } static void