From nobody Tue Jun 25 17:42:38 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W7sby2ZvCz5PjSD; Tue, 25 Jun 2024 17:42:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W7sby1lgfz499j; Tue, 25 Jun 2024 17:42:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719337358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Iyzm3L1jEM8qoPb3EYINAhgyD7n7o9Bw9JYE8k1mneU=; b=AASTC31XToGuLNllkuHpNVIO8l/IAVvZIKgGDDhmSrv8jXr5j7GJpv+idhOFF7XzfKsgI6 u/XN2GS53xR9ZiZJWvgyKySylEMBG/Ni9vSH4Vt7uBhLwZv5WOWqDZpEVkWb1XN0KlpWMU E767rbYYLEAgoviacZfSAs9+SIZTu+6CIusacGXDOKLk90BkGh4INQqCYPD9mekxCbieMK pPxlemIn0cUOTsAYzUfCb/I9GUD/ZDZ9tCB5EpUkfG2l2r869AsGKQFRhFAjexiKA9qgqz qIW+6o9jkuupd0kL66cYDVy7Qc4iILJlewEzFwiHKPgLK9G3xebWoiwu/I8EIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719337358; a=rsa-sha256; cv=none; b=LGM8Myjj6JVhqmBdl3+YXp9xijyoCO9mpBzYihJ9DB8S8pcAl59QUlm0USdVuHk04TThhy +vCukbFo+pVKZXewUBspmV2GadW3I76x8VhpEQM5jVwh+xR+g1r3t6DnTgL12GgDZMCGRE pm0OhNJIh1t9Yl3qogrKJNQH5jMthahv6HRakSxGctar4woeV8sz9WQSZLbPdn4kP29f0Q jTLayh5wuK/9lHeZXfi+3YXT8fSeCkVwxQxKO1AX0/1UQrpRNugIMnRvUt4WkNL4cBsOQj +U05idsSgonPdReDgbFE42SVFSo0bYkjAdjDoMeXwgIqvNj/3vj8711Gfo7IRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719337358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Iyzm3L1jEM8qoPb3EYINAhgyD7n7o9Bw9JYE8k1mneU=; b=xCbfrlkgliwhTwpwRaPT6hHxToV8JmLaAhZRQTVXbmfOfFaGKjglv99kRV9nuPplySGOhA yDYoxSzpYcY22DeagWeidlOVGJ1oghCGMb1Tr2I60lQNXnHbm/BamrGchONNzJVrly0agz MX1f7MVZgDCycYEeBn/kDRKU4ANm/8FWB/AMXRWxHGeH1xreH3QDwkDaV4rurreZpWto5n 9SRKzWL5XHGB7riJUqiVUxJZ9r8a8lKy6z0mRkEwbz5QSr43655WHiVsxZTdOzuJeQyte1 BEHK7o1Zb8otNN63DzsZZIQN7mvzzI1QP7AsmrJYh3twiWv+HPCgI1GZeOAHgQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W7sby1M72z191n; Tue, 25 Jun 2024 17:42:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 45PHgcIW040213; Tue, 25 Jun 2024 17:42:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 45PHgcSs040210; Tue, 25 Jun 2024 17:42:38 GMT (envelope-from git) Date: Tue, 25 Jun 2024 17:42:38 GMT Message-Id: <202406251742.45PHgcSs040210@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: d25f0bdceb3a - main - cdefs.h: add __inline to __always_inline List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d25f0bdceb3abb798342821791d7ececb4ba3411 Auto-Submitted: auto-generated The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=d25f0bdceb3abb798342821791d7ececb4ba3411 commit d25f0bdceb3abb798342821791d7ececb4ba3411 Author: Ryan Libby AuthorDate: 2024-06-25 17:39:13 +0000 Commit: Ryan Libby CommitDate: 2024-06-25 17:39:13 +0000 cdefs.h: add __inline to __always_inline Add __inline to the __always_inline macro to quiet dozens of gcc warnings of the form: warning: 'always_inline' function might not be inlinable [-Wattributes] It's clearly the intention of the __always_inline macro applied to a function to inline the function. However, gcc seems to be picky with the -Wattributes. It appears that __attribute__((__always_inline__)) was intended to apply to inline functions, as in, function declarations with the attribute should also be declared as inline. Both clang and gcc sources themselves use the two in combination: inline __attribute__((__always_inline__)) FreeBSD sources mostly only use __always_inline, without the inline keyword. Only a few files in libmsun used both. Reviewed by: imp, kib, olce Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D45711 --- sys/sys/cdefs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h index 58146ddc721c..53ac1b1c3f92 100644 --- a/sys/sys/cdefs.h +++ b/sys/sys/cdefs.h @@ -265,7 +265,7 @@ #define __malloc_like __attribute__((__malloc__)) #define __pure __attribute__((__pure__)) -#define __always_inline __attribute__((__always_inline__)) +#define __always_inline __inline __attribute__((__always_inline__)) #define __noinline __attribute__ ((__noinline__)) #define __fastcall __attribute__((__fastcall__)) #define __result_use_check __attribute__((__warn_unused_result__))