From nobody Mon Jun 24 20:21:04 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W7K9K44tkz5PbPM; Mon, 24 Jun 2024 20:21:09 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W7K9K2Mthz41BZ; Mon, 24 Jun 2024 20:21:09 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-dfab5f7e749so4078037276.0; Mon, 24 Jun 2024 13:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719260467; x=1719865267; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=II+9sywttLHy31XQlaMHM79nfBERLWFVPw+SFdKb6Xc=; b=G7K4b4EFs6IFousB0lqEZ5kGtZt//D9duBCmZVTeNthSyawha4/5rucbl8uJrx5QhU d60ML7rib2hJ6eNZHR12hcTIsrfnSjBzKhn/70hqVDgmZ5WRVRfQ0VtAUV44T9VKLjpn nwG3rb+U5LUXUNWsWmToWrEy35H/RJQYkhyHGcKatgmz2UpvYI3Ltd3lS19zw5NjsIPm wRggFUYaQdhfDSnxZZ6w6O3tGbNEOzdmIb84DXXJSk/pPjrzZM2eTSCUiHww4v8Bm4cA vyP7XxEoMor40YEJWUydpsQvLLZzjaYH05pFS/J8ysd2SHcRnjF07M87aitNM6/CsN9K CAjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719260467; x=1719865267; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=II+9sywttLHy31XQlaMHM79nfBERLWFVPw+SFdKb6Xc=; b=T9PbqvPnVwYprZfZm8SYy+m+HdGuc74rPzyILY/L84/XJ2OjbGjzhUbCvSH/i2DNIm HzYGz/Z5f+8XNOWYH+r0T78P3vhDCHZNgC5gVe7if5lEffJ9sqxdquYcZtB57JDHFL0v 6kxOSTcrQol3v69M6yI2GvIbVwcOMrWYhlYvosg0wa74c1gVmA9iFr7tNYId202TrMsy M5YPRUwvpUbTv5MvcahNhNscwW/48mbw6HOhenh3IpDOUnlT3ktTgYhrvxni0YP9Z3f3 3FqiuIqd54buKSHD7BXpn2Zi+TCScPRbe/Na6zgBHLMdXHX+mBnwL4ZpGjivpZJ5k5p+ Du7A== X-Forwarded-Encrypted: i=1; AJvYcCUXh9CXKfo3IyfRTBo+dx/RteB2ff3ujtP5XS84PFL2QPCe4gP2mydLbMVhJhkbAffxDLw4lD9m99+3H+jkOE/s7aqgZjYO6Pc8rPA3/nho9+SeAxnKUq6xLEgkFY4XnFQhoHGqV5RIaM8hnNj1D3YMfA== X-Gm-Message-State: AOJu0YzRf3VUWipudKlp/wOXw1niE62k/lI9Wx7siGR5xGpZeLvJmXsp vCMdBB1/yYSRS2A+S09QAOM3XjARM6pqFPAiF6zye0B251hkilwa5YtVdb4+ X-Google-Smtp-Source: AGHT+IHp7Nnb7o3TTpEMRegX4Nh+A0wBwmr0uOPNF40U50aGcDT1HlX3FhQVpCJkNcCCoG1MVsnHkQ== X-Received: by 2002:a25:ab50:0:b0:dfd:c6a0:ea21 with SMTP id 3f1490d57ef6-e0300f408cdmr6256048276.16.1719260467441; Mon, 24 Jun 2024 13:21:07 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2c97136sm46223961cf.95.2024.06.24.13.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 13:21:06 -0700 (PDT) Date: Mon, 24 Jun 2024 16:21:04 -0400 From: Mark Johnston To: Gleb Smirnoff Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ac52fa1f1b97 - main - sendfile tests: Fix an error check in tcp_socketpair() Message-ID: References: <202406211821.45LILvWH052581@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4W7K9K2Mthz41BZ On Mon, Jun 24, 2024 at 01:04:59PM -0700, Gleb Smirnoff wrote: > Mark, > > On Fri, Jun 21, 2024 at 06:21:57PM +0000, Mark Johnston wrote: > M> commit ac52fa1f1b9768d281b9deed6d1158f43a8564ca > M> Author: Mark Johnston > M> AuthorDate: 2024-06-21 18:18:22 +0000 > M> Commit: Mark Johnston > M> CommitDate: 2024-06-21 18:18:22 +0000 > M> > M> sendfile tests: Fix an error check in tcp_socketpair() > M> > M> Fixes: c368d3f20fc0 ("tests/sendfile: factor out tcp_socketpair()") > M> Differential Revision: https://reviews.freebsd.org/D45598 > M> --- > M> tests/sys/kern/sendfile_helper.c | 2 +- > M> 1 file changed, 1 insertion(+), 1 deletion(-) > M> > M> diff --git a/tests/sys/kern/sendfile_helper.c b/tests/sys/kern/sendfile_helper.c > M> index 703b04fdea6c..6365531e312c 100644 > M> --- a/tests/sys/kern/sendfile_helper.c > M> +++ b/tests/sys/kern/sendfile_helper.c > M> @@ -84,7 +84,7 @@ tcp_socketpair(int *sv) > M> if (fcntl(sv[0], F_SETFL, flags) == -1) > M> err(1, "fcntl +O_NONBLOCK"); > M> > M> - if (connect(sv[0], (void *)&sin, sizeof(sin)) != -1 || > M> + if (connect(sv[0], (void *)&sin, sizeof(sin)) == -1 && > M> errno != EINPROGRESS) > M> err(1, "connect cs"); > > Sorry for not reviewing in a timely manner. Did you actually observe connect(2) > on a non-blocking TCP socket to immediately return success? Yes, I was seeing occasional failures from my test runner where the helper exited with "connect cs: ". It's easy to reproduce this by running the tests on a system with some background CPU load.