From nobody Fri Jun 07 05:49:46 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VwVdk2vzMz5MKgh; Fri, 07 Jun 2024 05:49:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VwVdk1hLxz4gjK; Fri, 7 Jun 2024 05:49:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717739386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6mU2eXbgiBEIk1xi+SfKSsN8u5mRINe3MyYzO541Sdw=; b=x1qN/cDuIYeZDRorpDqp638Jz2YUPCxiX6oHIAP9xibDYKqDqnRZ7g9tvq+IWPcDEDWcSJ CZHqqNCz6vzzbhhlIPS6seiliLqPZ0+4Gw+S7YQXQzmhY2iccQYMLBTGY6ew9lYkzKUV6p O//sbp1i4g8IDeGN+0muOfrvBUAe8bGQHiw7hS99HE1dY+F82emR+f9EENFnDJ4VLMCHaN P3L3VRyCAZZmh8nCN76tYcSEfgZ7sCuwKD4cmzDQxw4zIJVgGApFHYl95W2Z3smKGmfKHc 4ubE4+pT0PWwYEnsjqU5G5qFLSNSQ9Hx9q1ZfeoIM/WlfMwpkPLq9AutaVem8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717739386; a=rsa-sha256; cv=none; b=eCjGJBGSH6N28G35YiQLdYVFvxI6xqgLyOdp2KDiP7OP6Xg8aI7wuyV875shtV2JVmCUvC uMD3GKpLOrW8nLsxoJ0nvuMQyNjUGO0vw2kHblzZaNyOyddSN5UypC6uHc28YLB0C8aW+N ouFt0D9N6ynRXBsY2YEBtxooMMM441anHfMD2WHXe4UdxHyDIs1giNxVmeHUQOEi89GXrh CkT8THRWKANE/46eTEtpi46Odlb+FqQPWo+CqkHoycNO7/r+s2LW2AcvCX5CQDGprUffnH PVaiNppAKBX9UEN576vFjTv+3JfvPLJqHng1V7tVHCzOMggIeta49z7PBEScBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717739386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6mU2eXbgiBEIk1xi+SfKSsN8u5mRINe3MyYzO541Sdw=; b=baPprC9HyDsbhh+1g43rpysOHdyLzrdrS2stcvSUSsYGcusZxooGQcN8sqVL0xt++aJb9X o3E/rElXNs3FT+FikuSivPcr8OJShsCMuByFCiPzmI9KgTOns6uOGWk0lvzKe0b6z48wzK jzQntpKSmolIqxrFFke2mtCEwUMKH4jrGjVODcLMd/jrRsrG85vWP8YdaM10bCLiN/6FOF Jt7yS+uc3cabMJfFAgQGjr+jGlFr/6HdqjvbJVLK/S7LLs0f2UsGWDIeMRv7Xc6DeWV/zF rLl/MCWM64S83Ndn5oZ2sMqIa5mKfE+7rWOwVsQI9YqYB+4ev8qrUoCI/sFGUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VwVdk1JVHz1H5N; Fri, 7 Jun 2024 05:49:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4575nk3o058952; Fri, 7 Jun 2024 05:49:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4575nkLw058949; Fri, 7 Jun 2024 05:49:46 GMT (envelope-from git) Date: Fri, 7 Jun 2024 05:49:46 GMT Message-Id: <202406070549.4575nkLw058949@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: e84a661d5418 - stable/14 - qlnx: qlnxe: Fix kernel address leakage List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e84a661d5418790ac89113aa21d87901c627529f Auto-Submitted: auto-generated The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=e84a661d5418790ac89113aa21d87901c627529f commit e84a661d5418790ac89113aa21d87901c627529f Author: Fuqian Huang AuthorDate: 2024-05-28 05:45:52 +0000 Commit: Kevin Bowling CommitDate: 2024-06-07 05:48:21 +0000 qlnx: qlnxe: Fix kernel address leakage In function qlnx_rdma_deregister_if, the address of object rdma_if will be printed out. rdma_if is the address of a global variable qlnxr_drv, which is passed from dev/qlnx/qlnxr/qlnxr_os.c A kernel address leakage happens. Fix this by removing the printf statement. PR: 238646 (cherry picked from commit 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf) --- sys/dev/qlnx/qlnxe/qlnx_rdma.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_rdma.c b/sys/dev/qlnx/qlnxe/qlnx_rdma.c index 77b25a017ade..a69f0efd095a 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_rdma.c +++ b/sys/dev/qlnx/qlnxe/qlnx_rdma.c @@ -253,8 +253,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if) int ret = 0; qlnx_host_t *ha; - printf("%s: enter rdma_if = %p\n", __func__, rdma_if); - if (mtx_initialized(&qlnx_rdma_dev_lock)) { mtx_lock(&qlnx_rdma_dev_lock); @@ -285,7 +283,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if) mtx_unlock(&qlnx_rdma_dev_lock); } - printf("%s: exit rdma_if = %p\n", __func__, rdma_if); return (ret); }