From nobody Thu Jun 06 14:24:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vw66c2ypDz5MmLk; Thu, 06 Jun 2024 14:24:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vw66b2NKCz46pZ; Thu, 6 Jun 2024 14:24:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-60585faa69fso668882a12.1; Thu, 06 Jun 2024 07:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717683894; x=1718288694; darn=freebsd.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=NJZzyG+fLBq0+nvCuAaYy2+J/EcauqWR9obrIwUuRzI=; b=fANP4mwebf/RfTaOjaHLG0BtBrggMGyfag0ho2Qb0zCQbO1PhCZveTg6Y2UXMD0g+A 0NqwJFRVgn3DRXThuh+5tzMj047NcMf+jHklBYoaRU61S/VJkhPa7OpWAtFw6jnQwXUa IUfdFj0j2gpScKFdE3F8AjF+ja2N/vqjDzGYskNQ3MVfH4o14sPvlyJhHFCRTTKDsOEz cYQE4qNutJ+Wsvs2CFVaLm6vM/dGkYzBKsfCD39oILPmH02jN7HAxBJQXMSpKFeeRt+v EJx9er1vT/zFKl4SRK06qhXf/Md8VG2ww4xmOH2w8ojWEx0D/Xd10mxrih31AiND5JaZ Lb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717683894; x=1718288694; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NJZzyG+fLBq0+nvCuAaYy2+J/EcauqWR9obrIwUuRzI=; b=BJyP8TIsUKnUL5OSX/48HdSxjF1Tzdb6KxlPBEqE35AAWUIm1vh7QX8UXwgmicGLGq n4UVovPoxqyv28TNPBkiuUssYIMp+7p7QyZIpXJTBSUXUk0i4x59JCMB20KzJXihKntv ZH0EVEsiOc27YfnWSOBECB1PcyCYK4S38TewBuey6v3BMa8UP0xiuucueha6hDdH6ZDh Mw3xrdx4glLJWAa+kqAJwqwdC6pwCeddYATX9u+vopux6dEhMdwCzmfy8MYSoBLabvk9 rn77L8KLI/nnd+eoBLGoqn7FncmlBuIyvmiHt0hlf+BL/FAfboHgEOcluUMYriABzfdT o78Q== X-Forwarded-Encrypted: i=1; AJvYcCVXbCiYLP2I+Jpny/FBLXzCAcdLyi5VCSfCFwVJL6rThbPXn1Y9UNO3SEv/bs4o1TncTMDA8AAazBupAPfGImIE/0aPyOHlQxeRxYzUJ6ahNn773hRNl/Ks/oxso+Z3ECX0suXNs7pE1tXPtnPGwdIwjTfyXes= X-Gm-Message-State: AOJu0Yz7Co6HYUJ7lsFc3dTdKRVQ93y6am/M2D4F5s55fNm2sGW0gs6S sB/VY0PQFtZxOK0pIduaPscHlYUtEQ5lrh4feJCbhbvg8iEiR33BPwjPvw== X-Google-Smtp-Source: AGHT+IFUKYwIXpn3gxtrlxXAq2dY+165s/0hJPx7FsybJnJ5yZkJqyW+nfcWGpL5Rylj9JgxnRDBQA== X-Received: by 2002:a17:90b:1093:b0:2c2:84a8:8d91 with SMTP id 98e67ed59e1d1-2c2999d64cbmr3702306a91.16.1717683893419; Thu, 06 Jun 2024 07:24:53 -0700 (PDT) Received: from smtpclient.apple ([162.118.1.182]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c29c3845a6sm1668375a91.39.2024.06.06.07.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 07:24:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Enji Cooper List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (1.0) Subject: Re: git: 0e0919db966a - stable/14 - periodic.conf: remove long deprecated security_daily_compat_var() Date: Thu, 6 Jun 2024 07:24:52 -0700 Message-Id: <894B0AFB-A554-456B-94E8-8282D7A5E879@gmail.com> References: Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org In-Reply-To: To: Michael Osipov X-Mailer: iPhone Mail (21F90) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Vw66b2NKCz46pZ > On Jun 6, 2024, at 00:20, Michael Osipov wrote: >=20 > =EF=BB=BFOn 2024-06-05 17:55, Enji Cooper wrote: >>>> On Jun 5, 2024, at 1:07=E2=80=AFAM, Michael Osipov wrote: >>>=20 >>> The branch stable/14 has been updated by michaelo: >>>=20 >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D0e0919db966a83efc696d19b3= 9a5962500e6ad46 >>>=20 >>> commit 0e0919db966a83efc696d19b39a5962500e6ad46 >>> Author: Michael Osipov >>> AuthorDate: 2024-04-15 11:05:17 +0000 >>> Commit: Michael Osipov >>> CommitDate: 2024-06-05 08:05:54 +0000 >>>=20 >>> periodic.conf: remove long deprecated security_daily_compat_var() >>>=20 >>> This function is documented to be gone in after 11. Time to remove th= is >>> compat shim. >>>=20 >>> PR: 275296 >>> Reviewed by: jrm (mentor) >>> MFC after: 1 month >>> Differential Revision: https://reviews.freebsd.org/D44796 >>>=20 >>> (cherry picked from commit aa48259f337100e79933d660fec8856371f761ed) >> It=E2=80=99s kind of unfortunate that this didn=E2=80=99t just break peri= odic for folks that rely on these compat variables prior to their removal. >=20 > Enji, >=20 > we talked about this with Baptiste a couple of weeks ago. He fixed pkg and= deep-analyzed all ports for possible issues. All clean and we so no issue b= ackporting it. Also the removed function has been issuing a warning on every= call, did you miss it? Hi Michael, I haven=E2=80=99t missed these messages in the past (I pay WAYYY too muc= h attention to console noise =F0=9F=98=82). My concern is that I=E2=80=99ve s= een warnings like these be missed by others (in particular when FreeBSD is u= sed in a dev/embedded environment), since issues like this are lost in the o= verall =E2=80=9Csea of noise=E2=80=9D that gets dumped out to the console (p= eriodic output doesn=E2=80=99t even go to the console by default since it=E2= =80=99s invoked by cron, so it=E2=80=99s sort of worse=E2=80=A6). One way to mitigate this issue (in my mind) is to document this removal i= n the Release Notes, so maybe (hopefully!) someone might read the RNs, notic= e the change, and adjust their configs to use the updated variables =F0=9F=99= =82. Cheers! -Enji=