From nobody Thu Jun 06 07:20:26 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vvwhr6T3mz5LYcW; Thu, 06 Jun 2024 07:20:28 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vvwhr5yvKz47KS; Thu, 6 Jun 2024 07:20:28 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717658428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SFKJf2leFZ+tyNr8tRyLFp8kP3geBCPgfikwIpszdFk=; b=Va4cbsfX4J++vihxwCwP5crbGDYaqGq/K3+JINbEKJOWBzHhFZZtQemuOm2HdEncaPVh39 YyBZ6+/+FKetnvr1p/8WphruVZilkt4MA13+RcnGKAlZsc/BLxZDtsvKVdPwNU0e9NXpb9 itfyYEJUJTmJ0gN/xEtUFisEgm4ibhuFRQp6pfWrZLQNWF5WtJLcNyDNQExsZPUHvwMP+i yArmbjDKm9jgVAfIsXeIepKAietxt26o9ePJi53nM8YKGoWRjb0zVKkhRj860agaAL+OPB ONzAspZZoE8WTlbZ0ETZHgyrYVb7NrAR2reWkGz5LpG4tHTcSHUYwh3RIus41Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717658428; a=rsa-sha256; cv=none; b=fguLhTaTvVOgFJTME8KoMHqqwwz9fXi1/ArVnO4MgpgtkCgZw9sHKsJ8Ve8KrVZYZ/LKQG YMnbasYCK1F1vZG53hslM8YZ39pwCYpAF2J2QhAtqL//3T7emcFtcK15rVVEer/AlZqGop rjQIY7VCNL6FI0Ngt7C5iJMF14EjY6yx6JCBSHsL5Vj8ePFEA4aJY+abnJd3DT6V0P2GKp a8cbTBoiIXDigX13vCQ93TlGK7Ecfddq7/X24y/EzDrolzoG5IrwsWhCyVkJgaXfmzyRJ8 tOzvFJK0htWZqtBdzR0uaq6EzJN7FOJajTFcQbLS9uszYQ8kVwusKtHpRxTpGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717658428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SFKJf2leFZ+tyNr8tRyLFp8kP3geBCPgfikwIpszdFk=; b=slrlsn1rpR9vdwk/dRZcs3XZohrNNN25ZkKSQCh8eo0GoGLycOmSEJTqh6+iF1dVClPWcb E1LZep39HorRcUgPmkioQZ4j3IlgqrtCG3vb1NZsE5WHrLxDaM2xnXUWyKK0HQ2gApXb+R YVUdiGFe5p6NpCT4ZxDaZVdOVdaQ5avS4vZ6OnLI/9BvyYREnGlZBDa5i4sNR2gCBs5Suw jCreFCek9H60RyUWmWvQK9fH5tI2kshR64TReCCuqazogYSGbbrHvRq2hixhRKQCnoKXhf r2NJLcG9/zAwCB6yjGrBB3QmfKx2rfhJFeT0s7rIxgTRv5GUmsAkQvpRVGSARw== Received: from [192.168.1.23] (unknown [147.161.168.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: michaelo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vvwhr1f3xz1HWp; Thu, 6 Jun 2024 07:20:28 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) Message-ID: Date: Thu, 6 Jun 2024 09:20:26 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: git: 0e0919db966a - stable/14 - periodic.conf: remove long deprecated security_daily_compat_var() To: Enji Cooper Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" References: <202406050807.455871md091767@gitrepo.freebsd.org> <1B22E11F-D498-4F67-8AE9-AB8D6206F09F@gmail.com> Content-Language: en-US From: Michael Osipov In-Reply-To: <1B22E11F-D498-4F67-8AE9-AB8D6206F09F@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024-06-05 17:55, Enji Cooper wrote: > >> On Jun 5, 2024, at 1:07 AM, Michael Osipov wrote: >> >> The branch stable/14 has been updated by michaelo: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0e0919db966a83efc696d19b39a5962500e6ad46 >> >> commit 0e0919db966a83efc696d19b39a5962500e6ad46 >> Author: Michael Osipov >> AuthorDate: 2024-04-15 11:05:17 +0000 >> Commit: Michael Osipov >> CommitDate: 2024-06-05 08:05:54 +0000 >> >> periodic.conf: remove long deprecated security_daily_compat_var() >> >> This function is documented to be gone in after 11. Time to remove this >> compat shim. >> >> PR: 275296 >> Reviewed by: jrm (mentor) >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D44796 >> >> (cherry picked from commit aa48259f337100e79933d660fec8856371f761ed) > > It’s kind of unfortunate that this didn’t just break periodic for folks that rely on these compat variables prior to their removal. Enji, we talked about this with Baptiste a couple of weeks ago. He fixed pkg and deep-analyzed all ports for possible issues. All clean and we so no issue backporting it. Also the removed function has been issuing a warning on every call, did you miss it? Michael