From nobody Wed Jun 05 17:42:19 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VvZXq6bKCz5LNGh; Wed, 05 Jun 2024 17:42:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VvZXq65Tjz4Ssx; Wed, 5 Jun 2024 17:42:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717609339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=54m2THz63XNRuw3w+BPlmOOyNxKUDWxJf649fSVsojQ=; b=Dsn8jijSuq5VISpMxdjUBzCVzXVJS09IA0ut1YGu5Dx3zYJgR6gnAvsQ4pgAboKXbQCGUw 3h4WoZXTiNxr28mok34BOqSf6p/hfIw0mxmRcyXkQIQcC5WIz/UvNs8Mrwjojw1Qvh4GcH gXk7ogAexRtHqczmNYT1WX3hxjNKyOyqHuYAzIu/c4Nq4TaRXxftfsf5VpTFaVOiF2Wu2h FrPXfFULYPuXpjpR9QfgAbrvdaZPkphGj5LoaCaAvchPdW0ONZeCx4xQ/BIDSl9gbaOslo E8L48jJg/4LebYfKm2e8x9Y8niY/eSqfcYSKqw6qO8fD1iWvcgZDrNbLVHY4Tg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717609339; a=rsa-sha256; cv=none; b=ZM27OkxbwjVxQwwFzilvQvga5sF4LIs2Z99byElvTSZsG/JCMIi+C6qKZ2ef75ojnx4Jqm aUQ1n8S3me3jqfvGDNfkyF6d+fGsGHLfqnnB3LHN5AKxFgjC/SWyMIfvvP5rBOu6VM3V/w IUxLwWIXAPEe9s0flQQIUD6YkJV5oY+uFGupvvsuwdH2uGjEax5I9IbthhHvlRVJGCDiGS 7DNBqPHzWj/tYzm5/6cmDRyFY+C+hZaux5nwawi7ZLITyFxkEFPdWRRa3/9N6Pi3qEJk7h 8WEHui4R0Dw0dN8h3CqN9QnEZjTRpV4ocGb5yqim9G7KBwUK8Vk9qE0AWsPcfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717609339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=54m2THz63XNRuw3w+BPlmOOyNxKUDWxJf649fSVsojQ=; b=xM3dD+bfS+qYd4HDq38GoYn64pTEDoaTZtPzsZSusjr8WZZDC4dOifAJrDQMoa4KzibDOg 1fDg/Xex0+dt0hIq8G1Jsn8apvFeSZhbZLaUO/8KuacoOrbJidROSoTNkYg2Vy1MSEj0gn RgkkJEDnyMWvFmt6g3FEteciMRsGzBwrBcnli+uMPk4AmZYdUcNDKJDMueokMzLSPuMUc9 pA7nHHV/hLfRu+tPQjVF+D2QpAhUTog6RFyuweZJhstgb4UrsY+bynNpyoo3zlq0utZjgo S51G7nJpIGe6Nco91rpjt24F2SY+YTx/iDMSFN5r3+p2eY69U9qiZWsFXIsNTQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VvZXq5hnYz1BXp; Wed, 5 Jun 2024 17:42:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 455HgJaF071084; Wed, 5 Jun 2024 17:42:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 455HgJhp071081; Wed, 5 Jun 2024 17:42:19 GMT (envelope-from git) Date: Wed, 5 Jun 2024 17:42:19 GMT Message-Id: <202406051742.455HgJhp071081@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Cox Subject: git: 60847070f908 - main - vm: Eliminate a redundant call to vm_reserv_break_all() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: alc X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 60847070f908c7c5ebb2ea4c851f8b98680fd01a Auto-Submitted: auto-generated The branch main has been updated by alc: URL: https://cgit.FreeBSD.org/src/commit/?id=60847070f908c7c5ebb2ea4c851f8b98680fd01a commit 60847070f908c7c5ebb2ea4c851f8b98680fd01a Author: Alan Cox AuthorDate: 2024-06-05 06:40:20 +0000 Commit: Alan Cox CommitDate: 2024-06-05 17:39:47 +0000 vm: Eliminate a redundant call to vm_reserv_break_all() When vm_object_collapse() was changed in commit 98087a0 to call vm_object_terminate(), rather than destroying the object directly, its call to vm_reserv_break_all() should have been removed, as vm_object_terminate() calls vm_reserv_break_all(). Reviewed by: kib, markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D45495 --- sys/vm/vm_object.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c index 905df5454355..0af4402938ba 100644 --- a/sys/vm/vm_object.c +++ b/sys/vm/vm_object.c @@ -1953,14 +1953,6 @@ vm_object_collapse(vm_object_t object) */ vm_object_collapse_scan(object); -#if VM_NRESERVLEVEL > 0 - /* - * Break any reservations from backing_object. - */ - if (__predict_false(!LIST_EMPTY(&backing_object->rvq))) - vm_reserv_break_all(backing_object); -#endif - /* * Move the pager from backing_object to object. *