From nobody Wed Jun 05 05:38:09 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VvGTV6FW6z5LgMf for ; Wed, 05 Jun 2024 05:38:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VvGTV4mcrz565f for ; Wed, 5 Jun 2024 05:38:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-35e4be5bd7fso3771699f8f.1 for ; Tue, 04 Jun 2024 22:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717565901; x=1718170701; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DUiys0J02TLtCJSGine00ghgPjfsdZAHtD8m+QlklmI=; b=YADbTShOC7nhoo1NNeref9+zPoomRzKIPCVY7VO1wotsdTeGgsLn4D9CRBV2uoECy3 MIIGZTxJMrAo2ASNs4KuiIJIrpCW2BaJenWJfXEIa2vSHtJKKUyU3Y29YgFnDSpHIN9w 5wR0vPalUhB4yc+9OIuVmXpf3w7qfvoxGgKNWXmV+WsVix+OO1IXubCE9i03+HKtao0I BIcg/gkR2RbmpLN7+oViNVDSyf0Ce0DRf93T98MeILgZ34b+t/CehepOcnf7KmnNiIUM YYRDCiuDs6fFIHmS5bksX1cgTcLwX1pnYLDi3l3nNTc0ljnElZwumxfn00cd3BxFaMur 7Ykg== X-Forwarded-Encrypted: i=1; AJvYcCXcJ+WzjCEYizlVZM3R3NOMRtlDTXMjkZZFpWRJp1wwM5299FMCTru33xxIcx5v6GSzj0AV/QKzO2NmMmx53Zqcaz4j011n058aJT43TdYM X-Gm-Message-State: AOJu0YzJVL4yl1vK0yxzwZpGaHQ7s0aQ+CE+pd0pvnQ+YpMCcsfzqahk f36xkv+GiOlmv++YD2G3Z6rVuobMlpZgv+Lxf1V0ce7niYpXNiui6RK/Y0nyLCc= X-Google-Smtp-Source: AGHT+IEVKrsXwuL8spPePuWwcVRGNw5WR9cdAvYvr9edOuTckU3pk3MhhX2EqW8t/hkG+TeTx5CIhQ== X-Received: by 2002:a5d:4a8f:0:b0:359:7891:48db with SMTP id ffacd0b85a97d-35e84057c95mr1014586f8f.10.1717565900777; Tue, 04 Jun 2024 22:38:20 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04cc0b6sm13201412f8f.44.2024.06.04.22.38.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2024 22:38:20 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: git: dcb65c5a94d4 - main - csh: Remove hardlink /.cshrc From: Jessica Clarke In-Reply-To: <20240605073006.165e209edd1d6ce0c8520c9e@bidouilliste.com> Date: Wed, 5 Jun 2024 06:38:09 +0100 Cc: John Baldwin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <885F8DF1-69E2-4AC7-87E2-B63F1588DE17@freebsd.org> References: <202405290757.44T7vbf4021395@gitrepo.freebsd.org> <20240605073006.165e209edd1d6ce0c8520c9e@bidouilliste.com> To: Emmanuel Vadot X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4VvGTV4mcrz565f On 5 Jun 2024, at 06:30, Emmanuel Vadot wrote: >=20 >=20 > Hi John, >=20 > On Tue, 4 Jun 2024 16:07:53 -0700 > John Baldwin wrote: >=20 >> On 5/29/24 3:57 AM, Emmanuel Vadot wrote: >>> The branch main has been updated by manu: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Ddcb65c5a94d4c622b1d486847dc20488= f59974e7 >>>=20 >>> commit dcb65c5a94d4c622b1d486847dc20488f59974e7 >>> Author: Emmanuel Vadot >>> AuthorDate: 2024-05-27 13:12:18 +0000 >>> Commit: Emmanuel Vadot >>> CommitDate: 2024-05-29 07:56:58 +0000 >>>=20 >>> csh: Remove hardlink /.cshrc >>>=20 >>> Remove this historical artifact. >>> csh will try to use /.csrch if the user has no home directory = defined which >>> is rather unlikely (To be exact if the concatenation of $HOME = and "/.cshrc" >>> fail which is the same thing). >>>=20 >>> Also, with this change pkg will happily handle 3way merge for = /root/.cshrc >>>=20 >>> Differential Revision: https://reviews.freebsd.org/D45382 >>> Reviewed by: emaste, imp >>> Sponsored by: Beckhoff Automation GmbH & Co. KG >>=20 >> FWIW, this happens anytime you use /bin/csh as root's shell and boot = into >> single user mode. Similar to /.profile being used for single user = mode if >> root's shell is /bin/sh. Given we've changed the default shell for = root, >> then it's fine to do this change, but that probably should have been = noted >> in the commit log (in part to serve as a reminder so we don't remove = the >> links for sh). >=20 > I've thought about single user and csh and yes that's a case where csh > will try to use /.cshrc but root shell doesn't matter here as you need > to specify /bin/csh as the init prompt for single user mode, the > default is still /bin/sh no matter what. > For /.profile, /bin/sh in single-user mode does have $HOME point > to /root so I think we can remove safely the /.profile hardlink. I > haven't looked at why /bin/csh doesn't have $HOME set but if someone > cares about using /bin/csh in single user mode (again nothing to do > with root shell) they probably wants to do something about setting > $HOME to /root/. Are you sure it=E2=80=99s /root before .profile is sourced? root=E2=80=99s= .profile sets and exports HOME itself, so echo $HOME will be misleading at a single-user prompt for the environment at .profile source time. Note that root=E2=80=99s .cshrc doesn=E2=80=99t do this, which is likely = what you=E2=80=99re seeing? Jess