From nobody Wed Jun 05 05:30:06 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VvGJR1w8fz5LffM; Wed, 05 Jun 2024 05:30:31 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VvGJP5dNGz55FK; Wed, 5 Jun 2024 05:30:29 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1717565420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZkehZEWR1Md/o5fcHj1ctcK0U45sOXRKwJnkNbOqVCE=; b=AFtPqZMTQ/J/hRxD3b5wpiNfTfGbcbVpYzqLhJaTLXtDMkD1TjEiqeQ6ohs5NvANkNu35v Z03LX9H2rRglJfYjOlZcY/4aYGnaWjbAF/ROFPLQeAV4cmjG8CUAtqPFsx6cO7muMkjyxW vWs1RElBqnxqewJYcxVPhEzIlrwFVN0= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id e680eb03 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 5 Jun 2024 05:30:20 +0000 (UTC) Date: Wed, 5 Jun 2024 07:30:06 +0200 From: Emmanuel Vadot To: John Baldwin Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: dcb65c5a94d4 - main - csh: Remove hardlink /.cshrc Message-Id: <20240605073006.165e209edd1d6ce0c8520c9e@bidouilliste.com> In-Reply-To: References: <202405290757.44T7vbf4021395@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Queue-Id: 4VvGJP5dNGz55FK Hi John, On Tue, 4 Jun 2024 16:07:53 -0700 John Baldwin wrote: > On 5/29/24 3:57 AM, Emmanuel Vadot wrote: > > The branch main has been updated by manu: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=dcb65c5a94d4c622b1d486847dc20488f59974e7 > > > > commit dcb65c5a94d4c622b1d486847dc20488f59974e7 > > Author: Emmanuel Vadot > > AuthorDate: 2024-05-27 13:12:18 +0000 > > Commit: Emmanuel Vadot > > CommitDate: 2024-05-29 07:56:58 +0000 > > > > csh: Remove hardlink /.cshrc > > > > Remove this historical artifact. > > csh will try to use /.csrch if the user has no home directory defined which > > is rather unlikely (To be exact if the concatenation of $HOME and "/.cshrc" > > fail which is the same thing). > > > > Also, with this change pkg will happily handle 3way merge for /root/.cshrc > > > > Differential Revision: https://reviews.freebsd.org/D45382 > > Reviewed by: emaste, imp > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > FWIW, this happens anytime you use /bin/csh as root's shell and boot into > single user mode. Similar to /.profile being used for single user mode if > root's shell is /bin/sh. Given we've changed the default shell for root, > then it's fine to do this change, but that probably should have been noted > in the commit log (in part to serve as a reminder so we don't remove the > links for sh). I've thought about single user and csh and yes that's a case where csh will try to use /.cshrc but root shell doesn't matter here as you need to specify /bin/csh as the init prompt for single user mode, the default is still /bin/sh no matter what. For /.profile, /bin/sh in single-user mode does have $HOME point to /root so I think we can remove safely the /.profile hardlink. I haven't looked at why /bin/csh doesn't have $HOME set but if someone cares about using /bin/csh in single user mode (again nothing to do with root shell) they probably wants to do something about setting $HOME to /root/. Cheers, -- Emmanuel Vadot