From nobody Sun Jun 02 18:05:18 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VslC23xwzz5N8QN; Sun, 02 Jun 2024 18:05:34 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VslC23Q6yz4Qwj; Sun, 2 Jun 2024 18:05:34 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717351534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zQQqhbXA/XgC+OPOZH0LllN1bVN0llY2a6/NxmCUbok=; b=o+6TbkaGPLjPF80kKPYE74DKwtet9lbEFzvFxQ0MiVeS2XRU3VYsjf53hy3WER0LhFRhFw nR1PT9QEz5Z4ja35sBQEpNRqSHw04uV3IWV2HGwVwYGNeH2nhbuUxP8ZrXRqql2RNtgxh6 f1emlNqq+F6A70QZdUmO0s96eFPhbXu27n6xWMxlT5arpI3NKTiqMDXLRQbFRqYmge1X2D MV+EGdpCczC2G+XN4+1rnBgbA4XnDSE4tgixVkLo9H3zoUZctRcv/oSZXrd+F3VNyC4HW5 GGkF0/+eXP6qPilD0E3mUdHeL4KZlrsyVehCpIKKk2bF7/TdGF1p1vLBVyjfmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717351534; a=rsa-sha256; cv=none; b=J2aQcnOp+XdMsxBURVar/wcp/VAT+u0yurH/brV52LmDep+V6m1rmklE4Hlk0cbUxcW6Kg 2aQUvbpmHADIhXhVRvluzhLd3/IlruafPbtkpOajUm0PDRnlxO5kMTNmQx+ZCNNmzNwbE5 q1oSG6H1/nEKamHxKZ+fCfBeczsktch0LMDYD4XgZI7GltGU3oiWuwkunnziLhMW8tK3Pd NPFmB9IAw32jDB5S5ncSyK3iaPzJFtw06jay0z4jHtcUwRNNx3sXKeGlXb6t28biTFWg/u FzG/jvNeh72SzLqUYqcpXa1bIlNZa9ohMd/Iy2yxAj67Ag1zs6rihgMqA4YPfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717351534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zQQqhbXA/XgC+OPOZH0LllN1bVN0llY2a6/NxmCUbok=; b=VCm0big4ayzZwJFKYXhb8q075IUFwnP88H0yf2prOANTbgxCbUg9vRPhjjW4ut8giiUWl/ mLIxq/Bu5E5SPE7AKQuQC6lUSh46XU4JZLedO4bX05XPUzgW+gY1Az5njmCV47b9CpF0Y4 onDwE3KG7XWumcQ44rzU4kU3s5MakU1R4lCpSsaFyx53VD+VI5XwfzwK1VuskTRrRGdhgN n7QIruICItfnN6sZa3faRNQXIG27skkoi+/gp9X8oJBRsZlJ3Vc1c11oIkn2KdU+qePAZk 3dih7DN6nwZgWMoSzrnSVMYGJ9CIG8lOWZ1/AhT3RegBCBn/zaGQYFqqR8Fgzw== Received: from francois.localnet (92-184-97-89.mobile.fr.orangecustomers.net [92.184.97.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VslC054MqzGZ6; Sun, 2 Jun 2024 18:05:32 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Warner Losh , Nuno Teixeira , Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 108de784513d - main - Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME Date: Sun, 02 Jun 2024 14:05:18 -0400 Message-ID: <3049031.hHqAuc6tWs@francois> Organization: FreeBSD In-Reply-To: <20240601224055.6a6cac10@slippy> References: <202405311447.44VEl1G1078199@gitrepo.freebsd.org> <20240601224055.6a6cac10@slippy> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2418096.THHZn3L5Ee"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart2418096.THHZn3L5Ee Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Olivier Certner Date: Sun, 02 Jun 2024 14:05:18 -0400 Message-ID: <3049031.hHqAuc6tWs@francois> Organization: FreeBSD In-Reply-To: <20240601224055.6a6cac10@slippy> MIME-Version: 1.0 Hi, Some food for thought. Given the (minor?) fallout, I wonder if we should have instead just added a distinct numerical value for CLOCK_BOOTTIME, which didn't occur to me while doing the review. This would have the benefit of allowing all these 'case' labels to coexist, which makes the interface more predictable and thus easier on applications. The patches below obviously only can cover the precise applications that we noticed failed to compile, and not other existing ones nor future ones to be written. I don't see any real drawback for such an approach because, to read clock information, applications always have to specify the clock ID and, AFAIK, cannot, e.g., request a list of clocks and times, where we would have to be careful to output the same time for all the aliased clock IDs. Thanks. -- Olivier Certner --nextPart2418096.THHZn3L5Ee Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmZctF4ACgkQjKEwQJce JidbYQ/+IscfV9GyJbYl3pvI6m8KbEd8UzX5Z6Pm/udJM3xCa9mKysIzDgQkDAMQ Oc9xEH/dMCLzbIlp2r4p53RLfGTnvEVzPzIWcAFWOnxaBXK+uFKhul4WURdRl97B C2Vxvp0H258Eg76PxDT9Ljgvs/kCPLsp+AD2XeNc51iZ04TXNFaGQqn7wv7TdCL0 DYXUX91Qwum7W8EZGpdRy5XyXkMFW3qEUKmGy61QTQ4DH03yeZhE52nxx/1mF0HJ /b3sRLwAnqZ3L7ZdEwE6I/vG7GTfbIzZi3lv/aSID1Wa3t1iNU9Yr4m3s+Nq57XK 2LdqjdULT8RsQ0woRE0XVq1ndQJ57xZuUnBh/Qd+63BlqVc6xcB2ZKoiF98Csj0Q LCTf5qvPVvOuxpmiUYPmRwZTJOsE3d7U2pPsIDy56ynTUIzRfYqzueNas3CqDXjg MkMfsgYjisrSiHgOF9KPg8oWmRnxiX6AjFhcf2JwaWgK6dAXuSqWZ36Ulo+HL1lB EmAUlaBK/M7bPejYaQ75/r80VK3mRL5xsMs2TH4wvtQvTG6q0Wss7QtrHfXfix9m fLyGCXMpGswLY6XdKxDkXjN/55eefxh0Xsz6WqU27TM4p0Rw/LToQdS5qL3nBqLR rqxK5vH2kGKuH2EY4CzNYi5gLaI+F3vAmO+QPGM+BxcMdO1wDq0= =KwGd -----END PGP SIGNATURE----- --nextPart2418096.THHZn3L5Ee--