From nobody Tue Jul 30 14:12:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WYHHX6n6hz5S3FB; Tue, 30 Jul 2024 14:12:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WYHHX6BWKz4vN0; Tue, 30 Jul 2024 14:12:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722348760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NFlxIJPhxOBlCGIAckZbOe6rhP9LhLpAIVoP95GmdEQ=; b=oxV0MdvJWCcKpuf1TyEH0NwnQiyqIOoaCycufRm1+XzBywCEZYYUjRv3AS1FADvAnH1L1c 3NBwK8RMugTrBqBgNW+lgSHNEVltOgsLFcIHT351Cs07sG/l3pNpJXq2NyZP9i78BABTtr IdIcJXyxYpXsICDc/B0EtqF8WUNkMy3ntBmcoHkNR8ijML6kaYsPcvNwSq9tSsWktd9Xj4 PSdMR2LSrO8mnt+SIjQQXcpTizVpu603eACSJlhtojf7Yv6s5U7aYjT1E87lIPtCfgyYFx ulOEhq9o29KOBfShOFmLWqsPjAGV2wreKPBHnVsdEEgP0G8kDROOhDowv2SrGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722348760; a=rsa-sha256; cv=none; b=NasFqYl4FnozfJh0Ea/sfCQL80+q/wcr+j3CmEA/j/ErvSpN8LOBuTyGNeF1vfcnRcTBCx OlKWbROC0f2wx4qDicYr+849jx8KlUX8hA9naBotTYqWBaKOeHtw9UhbahpFxzBhIA7kU9 rEyJlM0AvNdqFosXB0hQLQo6QUqSO5kj2mwctm8w1k01A6aCUZEJA9NRCAL+sK75MbLfPp y2w+5aIea5E/0+5pSqqA2MIDKnl/cZjdpOKX9RQ2oN9wLxELoh+TpReOBlnW1UgWrOVXef l2s0nUQ0pP+A+Z9jePBE8WS45jgSAqPurrSX+Wc8QKgNHQdc2Kmvn9h0qeqCNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722348760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NFlxIJPhxOBlCGIAckZbOe6rhP9LhLpAIVoP95GmdEQ=; b=X1tdwCcgA4wxX9d0bLP9l8cnSAn0t6xJAiBMnUKVEHMATUcLN3FXlnLChgKjol7d1o7qEJ 1ySrdh9ay6XGMk0C+4z2GHFQvi/WbmmY9eq4/Q8QhB0OFrbOuWZ0/atupvwlHBucX5V1QV AEarmAaU4w6xtbYCZlxTIVz6x4JLqJnOlSO4ACYsx+O+KxfbVoTj8qQ+u2TBgjw5NUQvAc 1CSXQdHm56pqH/4wkVR7neYtWkaGgHrzZEiFmFbbWGOsLYk9io6F13/km9rmyPVql4dCPt nHbbR0AiF0rZFsF7CBu3tStiB16n+ULyk4EaD4lG5XcxV+NoR4mM7LLscrhkXQ== Received: from [IPV6:2601:5c0:4200:b830:392f:842d:8de1:d214] (unknown [IPv6:2601:5c0:4200:b830:392f:842d:8de1:d214]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WYHHX3fXpzPF6; Tue, 30 Jul 2024 14:12:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <93322d8e-4ce5-4175-bdd1-6fde7012914b@FreeBSD.org> Date: Tue, 30 Jul 2024 10:12:39 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9 Content-Language: en-US To: Jessica Clarke Cc: Warner Losh , Mark Johnston , Yuri Pankov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202407291431.46TEVQow094080@gitrepo.freebsd.org> <63334eb1-7af6-439a-89a0-ba379428c5a6@aetern.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/30/24 10:00, Jessica Clarke wrote: > On 30 Jul 2024, at 14:52, John Baldwin wrote: >> >> On 7/29/24 15:18, Warner Losh wrote: >>> Hey John, >>> On Mon, Jul 29, 2024 at 11:55 AM John Baldwin wrote: >>>> On 7/29/24 13:40, Warner Losh wrote: >>>>> On Mon, Jul 29, 2024 at 10:39 AM Mark Johnston >>>> wrote: >>>>> >>>>>> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote: >>>>>>> Mark Johnston wrote: >>>>>>>> The branch main has been updated by markj: >>>>>>>> >>>>>>>> URL: >>>>>> >>>> https://cgit.FreeBSD.org/src/commit/?id=801c452795ac441523655eb3277051b7b034becf >>>>>>>> >>>>>>>> commit 801c452795ac441523655eb3277051b7b034becf >>>>>>>> Author: Mark Johnston >>>>>>>> AuthorDate: 2024-07-29 14:12:40 +0000 >>>>>>>> Commit: Mark Johnston >>>>>>>> CommitDate: 2024-07-29 14:17:04 +0000 >>>>>>>> >>>>>>>> man9: Really complete the removal of MD5.9 >>>>>>>> >>>>>>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now inaccurate >>>>>> kernel side manual page.") >>>>>>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 manual >>>> page >>>>>> from section 9.") >>>>>>>> --- >>>>>>>> ObsoleteFiles.inc | 2 ++ >>>>>>>> share/man/man9/Makefile | 2 -- >>>>>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc >>>>>>>> index b21778466800..01b4824e8692 100644 >>>>>>>> --- a/ObsoleteFiles.inc >>>>>>>> +++ b/ObsoleteFiles.inc >>>>>>>> @@ -56,6 +56,8 @@ OLD_FILES+=usr/share/man/man9/ifaddr_byindex.9.gz >>>>>>>> >>>>>>>> # 20240729: remove MD5(9) >>>>>>>> OLD_FILES+=usr/share/man/man9/MD5.9.gz >>>>>>>> +OLD_FILES+=usr/share/man/man9/MD5Init.9 >>>>>>>> +OLD_FILES+=usr/share/man/man9/MD5Transform.9 >>>>>>> >>>>>>> This really needs to be smarter, but you have to specify .gz suffix for >>>>>>> man entries as we have compression enabled by default. >>>>>> >>>>>> Sigh, who knew it was so difficult to remove a man page. >>>>>> >>>>> >>>>> There is a pull request being worked on that will be smarter about what's >>>>> removed since we have compress (UFS) and uncompress (ZFS) setups >>>>> now. >>>> >>>> Does it just add an OLD_MAN helper variable to use instead of OLD_FILES >>>> and then try the various extension combinations for each OLD_MAN? >>>> >>> https://github.com/freebsd/freebsd-src/pull/1295 >>> was submitted a bit ago. the repetition is why I've not committed it. Is an >>> approach >>> like that good, or should we move all the old man pages to OLD_MAN? >> >> This is solving a different problem. This is dealing with removing duplicate >> copies e.g. when switching from WITH_MANCOMPRESS=yes to WITHOUT_MANCOMPRESS=yes. >> >> OLD_MAN would be orthogonal. It would be similar to how we use extra logic >> for OLD_LIBS where we look for debug symbols in /usr/lib/debug to remove along >> with the library. For OLD_MAN we would try to remove both $f and $f.gz. > > list-old-files already has: > > -V "OLD_FILES:ts\n" -V "OLD_FILES:Musr/share/*.gz:R:ts\n” > > So as long as you list the manpages with a .gz suffix it’ll already > handle the uncompressed version. Ah, ok. Perhaps part of the goal of OLD_MAN would be to avoid the need to include the .gz suffix since it gets forgotten periodically, but that would be the only goal given the above snippet. -- John Baldwin