From nobody Tue Jul 30 13:52:32 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WYGrK6YPyz5S1L6; Tue, 30 Jul 2024 13:52:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WYGrK653bz4rwN; Tue, 30 Jul 2024 13:52:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722347553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=96VkamLg0LbjO9viGfcKJSi/uYHm5jlqY0eG/e4Dfa8=; b=fmTa9HOY8yy53L6KRtIuriDlXZOo4eLXuKho+8l9OD3zd/2NEP/bTWUtdMkfke7677cZkP 7+qr5xIvVoyREWm2f90bOqmhnMuXr4Sd/9ky3/q74iQyS3kWQLjf2I2D2MX84xatTagnUQ LgXrTdXiPkoeST3VGc8mNQi8SZSLWVbBRUiPrF2jQsRBW7SsRoaI+ifiCdu1ntElpO/kxQ sHYfKhQRqjtg10O9MqpKdmSZdgbnncBU4ySAf3/wnghtegqscGU/GajU5KbQrppmwB+r2S so0zXOBVYkjwx4sCb6qXvXQsP62ovjB7SzJ9xI4ttSUNgyEuQ6oYf9C03FGZdw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722347553; a=rsa-sha256; cv=none; b=Eu4PEupHPQ4NPp+i4cvvJ6KzY5E5Czbp/j7nKgPkj0yAFtubqzIy/LH18H4ywSKGmigsEg FoJb5a8MSkCKWtWZ4xiHh+qQj6oMVYGyckmu560hw8XdiUE0P6UEf3sdrnz+Y7lQD/oq5r xJXlBdqZKcC+04VkbEslaruJpJuUJtnrJYyfcYfyhA7z0bETk4VomAxLa6yfqMvanRvPCB wf8R680ABdT/oMyCutJBti1vf+gyACoaXF1lzZNa/0MGHY3Na6OwuCwECx3cc00JANNUA9 qK5Cvag4llXMNWa0b72w5e5haQd8lzfpDLG2Gghl5OD/++7o5ryKy8kd9UN+xg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722347553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=96VkamLg0LbjO9viGfcKJSi/uYHm5jlqY0eG/e4Dfa8=; b=RleVqqrtuMcZljFnhz+m14sYceyGJPfmPdLGjikW2oRlyiiz+y9i/ULWpiVUvtG5T7PHZj 8KnR/3Cb17LlYK5vKZ3PRZF+HQUqm2LNF2ajY4fuIOnzQKTTPajO1YUNofHI4BMuOSGIqs aAnFAEdeyfpeUR+piAfPATcvPwycBDrKfRtPr1C/4YxId9AXLD4+Lc4OcGDn+WBEEmLaji 6b593KRXDMoqnXNhE/WOKqtQ15O4BhKYZAtN7MdXdqvUUaGq1YTuOWXLIxqn5pKmkb8qbm 69NfJbPlBPw5MiPLrrnhNpBYgZFCUquymGWuHSnJNBv4kaDd4Q54/Itx1hKzLw== Received: from [IPV6:2601:5c0:4200:b830:392f:842d:8de1:d214] (unknown [IPv6:2601:5c0:4200:b830:392f:842d:8de1:d214]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WYGrK3pwWzPnc; Tue, 30 Jul 2024 13:52:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 30 Jul 2024 09:52:32 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9 Content-Language: en-US To: Warner Losh Cc: Mark Johnston , Yuri Pankov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202407291431.46TEVQow094080@gitrepo.freebsd.org> <63334eb1-7af6-439a-89a0-ba379428c5a6@aetern.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/29/24 15:18, Warner Losh wrote: > Hey John, > > On Mon, Jul 29, 2024 at 11:55 AM John Baldwin wrote: > >> On 7/29/24 13:40, Warner Losh wrote: >>> On Mon, Jul 29, 2024 at 10:39 AM Mark Johnston >> wrote: >>> >>>> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote: >>>>> Mark Johnston wrote: >>>>>> The branch main has been updated by markj: >>>>>> >>>>>> URL: >>>> >> https://cgit.FreeBSD.org/src/commit/?id=801c452795ac441523655eb3277051b7b034becf >>>>>> >>>>>> commit 801c452795ac441523655eb3277051b7b034becf >>>>>> Author: Mark Johnston >>>>>> AuthorDate: 2024-07-29 14:12:40 +0000 >>>>>> Commit: Mark Johnston >>>>>> CommitDate: 2024-07-29 14:17:04 +0000 >>>>>> >>>>>> man9: Really complete the removal of MD5.9 >>>>>> >>>>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now inaccurate >>>> kernel side manual page.") >>>>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 manual >> page >>>> from section 9.") >>>>>> --- >>>>>> ObsoleteFiles.inc | 2 ++ >>>>>> share/man/man9/Makefile | 2 -- >>>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc >>>>>> index b21778466800..01b4824e8692 100644 >>>>>> --- a/ObsoleteFiles.inc >>>>>> +++ b/ObsoleteFiles.inc >>>>>> @@ -56,6 +56,8 @@ OLD_FILES+=usr/share/man/man9/ifaddr_byindex.9.gz >>>>>> >>>>>> # 20240729: remove MD5(9) >>>>>> OLD_FILES+=usr/share/man/man9/MD5.9.gz >>>>>> +OLD_FILES+=usr/share/man/man9/MD5Init.9 >>>>>> +OLD_FILES+=usr/share/man/man9/MD5Transform.9 >>>>> >>>>> This really needs to be smarter, but you have to specify .gz suffix for >>>>> man entries as we have compression enabled by default. >>>> >>>> Sigh, who knew it was so difficult to remove a man page. >>>> >>> >>> There is a pull request being worked on that will be smarter about what's >>> removed since we have compress (UFS) and uncompress (ZFS) setups >>> now. >> >> Does it just add an OLD_MAN helper variable to use instead of OLD_FILES >> and then try the various extension combinations for each OLD_MAN? >> > > https://github.com/freebsd/freebsd-src/pull/1295 > > was submitted a bit ago. the repetition is why I've not committed it. Is an > approach > like that good, or should we move all the old man pages to OLD_MAN? This is solving a different problem. This is dealing with removing duplicate copies e.g. when switching from WITH_MANCOMPRESS=yes to WITHOUT_MANCOMPRESS=yes. OLD_MAN would be orthogonal. It would be similar to how we use extra logic for OLD_LIBS where we look for debug symbols in /usr/lib/debug to remove along with the library. For OLD_MAN we would try to remove both $f and $f.gz. -- John Baldwin