From nobody Mon Jul 29 20:31:46 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WXqlX2lG0z5RwSG; Mon, 29 Jul 2024 20:31:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WXqlX157gz4kSl; Mon, 29 Jul 2024 20:31:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3db23a60850so1893269b6e.0; Mon, 29 Jul 2024 13:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722285109; x=1722889909; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XMB0TyK4VgYKhXQ1pY6q85/rtWD0lyG4YqC71CAPKxk=; b=W7wH7Ox3XfC4y8L66PomE0ESGVyhd7yDYVb0C8yY0/7U8Ustlv9BrMKKVhjK8wOVMM 2bbcnGYCY9OVoUiPzW+GZCWaVG5/RFcDvptYlcTTALRuHVvQ2RDcQn+jfzapUQgE3jlb E+LtP0UqOe24JqP2FN5MdPSNhwz9XCDt/nIf7K3DZC/WD1WYEoleHahyoWR6Y0tRbFxW w++q2Drlbe29cO7Z6QL4sp1FxBdR86azrIMWIQKdyqqkhCt8BXtonII9c7EIBSOLs0Nr KQThnxrkRkaOn2URne9Qs/sKOmfNEdLEUSZMxiCeKT2c46hWPZwhkBcRoQDypgSfY8F7 YEDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722285109; x=1722889909; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMB0TyK4VgYKhXQ1pY6q85/rtWD0lyG4YqC71CAPKxk=; b=G6m7VRbs/5pkxtngdRSm8nsWCrqXKa9/7Qjl4Dj3GzHZ7Hz5bc6q9rcTrCoXit9xFz hGqrrFp14tJ0fGigUgHBo/5SGrQoS/+yJhnVBZYFOSsEO76/Y7pKCM/NhBG9/KpniH7q qdEVVWHFq/u3iHfArKxnGt8fJV6xE9U98WLLZqsLsemDnDkGpvQ0rwAFMWBFsyigZ8LL O6Z5FeHVnNGCHyIg8y+sKdhQ8N3xDtnu9t+1DsZU1e2kCtY3bZfo1jntQreNEDews9Fc J+jI7vfmEIz14e/SeQfXHyxpYKPBDHOJp36SMG72DatrDIUEMGbK5exHnEvKNK24Ozn8 TyiQ== X-Forwarded-Encrypted: i=1; AJvYcCXYOKNFAfBJqM7ZsUk40IoTx1ThX1IhpHZ/m+LIjWGyoeKNhtLw42XNjJsYa8dTNum8DOnz8avrA94eGJB5bnzpNMqKg3J7zNTbsDksi4Ju8YcrgK3o7dHh4Rdmun9g7LP8kd1qbFOYuYo4hCb3b+tHhg== X-Gm-Message-State: AOJu0Yx3GKFTQCTFyyMThtztKub1nXJ7OTACi/INtLt+YQJEeqZcV9Qm +VnVaBT6fGD+JneLRzddJWs4KSGyiJXoYlP5fpa2xxMeO+Zg1KBKV4s/3nLWjbQ= X-Google-Smtp-Source: AGHT+IEt2/Xg/ML2MTFeh1qQsLMrgIvn+KxtuKk/oSwWHM5TF+Uxr9IFVqhSOqNI0VB1Ed/fLE7WtQ== X-Received: by 2002:a05:6358:b3d6:b0:1aa:d1f7:8 with SMTP id e5c5f4694b2df-1adbe8c69b0mr896627455d.7.1722285109374; Mon, 29 Jul 2024 13:31:49 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb3f7e419csm56874876d6.0.2024.07.29.13.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 13:31:48 -0700 (PDT) Date: Mon, 29 Jul 2024 16:31:46 -0400 From: Mark Johnston To: Michael Tuexen Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 71867653008c - main - udp: improve handling of cached route Message-ID: References: <202407282141.46SLfuuZ083113@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202407282141.46SLfuuZ083113@gitrepo.freebsd.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WXqlX157gz4kSl On Sun, Jul 28, 2024 at 09:41:56PM +0000, Michael Tuexen wrote: > The branch main has been updated by tuexen: > > URL: https://cgit.FreeBSD.org/src/commit/?id=71867653008ce17a66a9c935e9dc29c1320bf48b > > commit 71867653008ce17a66a9c935e9dc29c1320bf48b > Author: Michael Tuexen > AuthorDate: 2024-07-28 21:25:22 +0000 > Commit: Michael Tuexen > CommitDate: 2024-07-28 21:36:48 +0000 > > udp: improve handling of cached route > > The inp_route pointer should only be provided to the network > layer, when no destination address is provided. This is only > one of the conditions, where a write lock is needed. > If, for example, the route is also cached, when the socket is > unbound, problems show up, when the sendto is called, then > connect and finally send, when the route for the addresses > provided in the sendto and connect call use different outgoing > interfaces. > While there, clearly document why the write lock is taken. > > Reported by: syzbot+59122d2e848087d3355a@syzkaller.appspotmail.com > Reviewed by: Peter Lei, glebius > MFC after: 3 days > Sponsored by: Netflix, Inc. > Differential Revision: https://reviews.freebsd.org/D46056 Hi Michael, After this commit, two regression tests started failing: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/25371/testReport/sys.netinet6.test_ip6_output/py/TestIP6Output__test_output6_nhop/ https://ci.freebsd.org/job/FreeBSD-main-amd64-test/25371/testReport/sys.netinet6.test_ip6_output/py/TestIP6OutputNhopLL__test_output6_nhop_linklocal/ I verified that they pass again after reverting this commit. Could you please take a look?