From nobody Sun Jul 28 19:07:02 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WX9w62JJ7z5RT01; Sun, 28 Jul 2024 19:07:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WX9w61qR1z44Sp; Sun, 28 Jul 2024 19:07:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722193622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rg/Znx+7y0b6NrAJ8ffWkjDBgsDX2pV1ORxH2UXHP9A=; b=HJDrAJSK/DjNgHHXHBc/anLOQrbhYCQlJF9Mecht/xWN+6lgx9CSPiBu6dlrd1CkrP4u6b /weXixaick55S8WbtQP+gMTOpkQ9cAcmGskhREwhAEx8f1J6E8ZVY/LLtxaBzDT+frT6wZ 7E+2VqaSONd/4oPUkhG7vtBtk7ZTvSfqGKCQ6c64PmkcLpLTKL25SIt9fnxvEWMpQCptQh xnGD12rGoyhrCsq1HWUHVFxA856b/93v28QzvcChX8bB/3Ziwae6XKeklMlS6hNKpJ7RaG j5Cs7ooE/1IhavSthIxWzjDSQC0Sak4B/d51DI3R0wjNbb8rAnHg7OROVeX3eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722193622; a=rsa-sha256; cv=none; b=mz8Q3l7OdZXnR+M4hhL/oPBOXkzrcfAeT1tklVS0esa2Toh4WgaCTCrIfS1EhInGfhchhW EC+8TCkViJJRQ0evWL1ghbCoRi+naCL/Y01vOo9anfYBtTWV0zZOtfzAG+5r0UaTdqE0e6 bV5XL267LsP5oZ7YfnqKpj2HdWp17I+lczFVIiCKd9agBaDwa0bhbPUCQrEsEvxdsQ3nlV 7oMs/p1jj8CKm/dd5eIDSNbsVpimMFqK00gjs1a2SI+8bDAuii6y8NOOLmSDxECB/RHz0I eEe5Qt5VdseG2ERP/qD6n2xkcFi33jzkp3FzaFol7RbT0cgjTgHMJGsrWjqSMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722193622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rg/Znx+7y0b6NrAJ8ffWkjDBgsDX2pV1ORxH2UXHP9A=; b=BYHOUTMSKl+bkuJ+uSSDuvO60dNqs2o8dmydVy68Ib9kOumklrY86H4g+vuZtfcva6mQCd 3uFL/JRx2/Ti5y2dKF1AOKygucqQPA71DTwACaRXYsUdQtJpm7eeA2uw4zmlHXP14dRRwc C9ImwF8dBn1exVAaGcBtFUXS85cEZn6e9p/Nntf3RndWg4G0UY7b57IVSwfiLltcmLcon0 O0tl7z7rqEubay0zUIThSGt4jLwbfazPwSpR0BOBPdZuRfiPfox/S4u+POKqQsfnoezmB9 7ftuQYvqZnPAfCnXxNS8rvnpABjRXbnmoMQTzNfvRAakmSk0J0FywVMt9b6P4g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WX9w61NtXz136g; Sun, 28 Jul 2024 19:07:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46SJ7250015624; Sun, 28 Jul 2024 19:07:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46SJ72tu015621; Sun, 28 Jul 2024 19:07:02 GMT (envelope-from git) Date: Sun, 28 Jul 2024 19:07:02 GMT Message-Id: <202407281907.46SJ72tu015621@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kirk McKusick Subject: git: 21161df3e032 - stable/13 - Do not allow snapshots on UFS filesystems using gjournal. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 21161df3e032252e7533a183acbc5374157b66f1 Auto-Submitted: auto-generated The branch stable/13 has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=21161df3e032252e7533a183acbc5374157b66f1 commit 21161df3e032252e7533a183acbc5374157b66f1 Author: Kirk McKusick AuthorDate: 2024-07-25 06:09:58 +0000 Commit: Kirk McKusick CommitDate: 2024-07-28 19:06:52 +0000 Do not allow snapshots on UFS filesystems using gjournal. PR: 280216 (cherry picked from commit cab41e0dd31d184bdb0d14403ca71a0f6c9a5e83) --- sys/ufs/ffs/ffs_snapshot.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index d4280391f48c..bc4dbdf52e5b 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -224,6 +224,15 @@ ffs_snapshot(struct mount *mp, char *snapfile) ump = VFSTOUFS(mp); fs = ump->um_fs; sn = NULL; + /* + * At the moment, filesystems using gjournal cannot support + * taking snapshots. + */ + if ((mp->mnt_flag & MNT_GJOURNAL) != 0) { + vfs_mount_error(mp, "%s: Snapshots are not yet supported when " + "using gjournal", fs->fs_fsmnt); + return (EOPNOTSUPP); + } MNT_ILOCK(mp); flag = mp->mnt_flag; MNT_IUNLOCK(mp);