From nobody Fri Jul 26 17:14:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WVvWc1clwz5Qybc; Fri, 26 Jul 2024 17:14:52 +0000 (UTC) (envelope-from gallatin@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WVvWc0sMPz4KHV; Fri, 26 Jul 2024 17:14:52 +0000 (UTC) (envelope-from gallatin@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722014092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WHj0+52y8Paea0ohCL5IjVEKvPWn2sGDCB0B08+oLvg=; b=F93UW/sZA+B+6HGkwBtTaslca/wgvu92INj+iOhpz3PEPHxWRZsvcalmisvHV4kwx58Jwf DrC/57RlfjFoeAaNNaOZIXzkKVFzKQDc/5Xw4hPkoFOhCJS7nnmRRwO+I7HIARbrp5IMOt d+2pumZBDBIUS4twI3CNkN9XWMFIurnmLg13aw0wEoTVA/iYVuArgMBGeyQgNPfqId1rl4 jLQdaL67SJTceQZkxM7xUWkKXlp/NQhItdG/iE1Pohs3sujMbLZ78Yw2fM4FKI6GOFwYHm /L0WW6Jr6mTsrTOvyBxAqusJ0HpHD/hOxy6AeFDIHHm2raWW/Ast3Lx/qNqiIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722014092; a=rsa-sha256; cv=none; b=ZMyqzxJ5L6218+BeOKyDQkzU6vxql1ZUhlYGGunyRqoEJRo4ZWIYRrdKgFuU1hBg4x8MFH nBU2T1h3Qi+FJ6yYr27oVzVz3mXdkLx/cfklNQTl1N/NdPFFDJiKtGYDm1Sil/qS2fMSvk FAwg1X0Rx05VtD4BFzCygcPNtxQvgEJoFLvLZMytOJ4uzF5paxa0LEkXt+wtxSAh13T63u +4xEXbZRee3DMa0hsOrtQE/L8dI+Rid39XpRyEMa9JcUm7xXU9w3ha89JOB7Z9k5SXcfZF GQKL4bV50mf+Kgkc2YudCFiRjZyHRylZvMs3Pl/DpG0DdykOqUqr1WNmCzou/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722014092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WHj0+52y8Paea0ohCL5IjVEKvPWn2sGDCB0B08+oLvg=; b=UPUso6SdCFQnw2T19tfa/zk0qKRAKRbfvaWZAN5b2MDceebZrPoa++521UM9Tf7wYlP2Z7 m5Jpzx+jMU2PtZXjdY8470AKOi7GnezuT2H3P4DMCaAeGgqI1B6/yWt/0Y34ByXpMItHqQ DNBDowQ9SwazSw3+C0J8vFkTHIuv49EdxNt+vN6Muh+Vt6gu/NdFRqs2JVwLrKDpbwq8K/ lv1BwERnw8h576pKuOgZco1cEt6w7ooJnwA5pI/C02jHy2/eW1ErAn0C+rjWy3RUfHuuvq adgNf9SUfmtMIAFUPab2t2WQ1TWu4ibjuXVt7XRcDZWFKV8cLsH80Kyf4vdXcQ== Received: from fauth1-smtp.messagingengine.com (fauth1-smtp.messagingengine.com [103.168.172.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gallatin) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WVvWb66nmzj7J; Fri, 26 Jul 2024 17:14:49 +0000 (UTC) (envelope-from gallatin@freebsd.org) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfauth.nyi.internal (Postfix) with ESMTP id 5EC481200077; Fri, 26 Jul 2024 13:14:43 -0400 (EDT) Received: from wimap26 ([10.202.2.86]) by compute1.internal (MEProxy); Fri, 26 Jul 2024 13:14:43 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrieehgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsegrtd erreerredtnecuhfhrohhmpedfffhrvgifucfirghllhgrthhinhdfuceoghgrlhhlrght ihhnsehfrhgvvggsshgurdhorhhgqeenucggtffrrghtthgvrhhnpedvfefhjeeludefge efjeelteeifedtffeuudevgffgffefudfgleeuvdekhfejieenucffohhmrghinhepfhhr vggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrghllhgrthhinhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihht hidqudeffeehledvvdduiedqvdelhedtgedukeegqdhgrghllhgrthhinheppehfrhgvvg gsshgurdhorhhgsehfrghsthhmrghilhdrtghomhdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i41414658:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3C6F419C0089; Fri, 26 Jul 2024 13:14:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-582-g5a02f8850-fm-20240719.002-g5a02f885 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Message-Id: <52e1bb60-32f3-49de-9714-78762edbfd4c@app.fastmail.com> In-Reply-To: <202405060315.4463FxP6098471@gitrepo.freebsd.org> References: <202405060315.4463FxP6098471@gitrepo.freebsd.org> Date: Fri, 26 Jul 2024 13:14:23 -0400 From: "Drew Gallatin" To: "Konstantin Belousov" , src-committers@freebsd.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: c097967b9af9 - main - mlx5en: add diagnostic in one more case of failed eeprom read preparation Content-Type: multipart/alternative; boundary=775e74ac73ea4ddb9d8a89b5497dea89 --775e74ac73ea4ddb9d8a89b5497dea89 Content-Type: text/plain Hi, This recently hit our tree and was deployed, and our operations team is quite upset because this results in a massive (orders of magnitude) increase in our kernel log messages due to our monitoring scripts probing each port. Can we please move this under bootverbose, or have some other way to suppress these prints? I can back this out in our tree, but I don't want to create yet another local patch. Thank you, Drew On Sun, May 5, 2024, at 11:15 PM, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c097967b9af946cf46246cce5adde53f7e955ecc > > commit c097967b9af946cf46246cce5adde53f7e955ecc > Author: Konstantin Belousov > AuthorDate: 2024-05-05 07:09:07 +0000 > Commit: Konstantin Belousov > CommitDate: 2024-05-06 03:15:35 +0000 > > mlx5en: add diagnostic in one more case of failed eeprom read preparation > > Sponsored by: Nvidia Networking > MFC after: 1 week > --- > sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > index e1dbd02fcf3a..962705e6d258 100644 > --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > @@ -3674,6 +3674,9 @@ out: > /* Check if module is present before doing an access */ > module_status = mlx5_query_module_status(priv->mdev, module_num); > if (module_status != MLX5_MODULE_STATUS_PLUGGED_ENABLED) { > + mlx5_en_err(ifp, > + "Query module %d status: not plugged (%d), eeprom reading is not supported\n", > + module_num, module_status); > error = EINVAL; > goto err_i2c; > } > --775e74ac73ea4ddb9d8a89b5497dea89 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Hi,

This recently hit our tree and was deployed, and our o= perations team is quite upset because this results in a massive (orders = of magnitude)  increase in our kernel log messages due to our monit= oring scripts probing each port.

Can we ple= ase move this under bootverbose, or have some other way to suppress thes= e prints?  I can back this out in our tree, but I don't want to cre= ate yet another local patch.

Thank you,
=

Drew

On Sun, May = 5, 2024, at 11:15 PM, Konstantin Belousov wrote:
The branch main has been updated b= y kib:


commit c097967b9af946cf46246cce= 5adde53f7e955ecc
Author:     Konstanti= n Belousov <kib@FreeBSD.org>= ;
AuthorDate: 2024-05-05 07:09:07 +0000
Comm= it:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-05= -06 03:15:35 +0000

    mlx5e= n: add diagnostic in one more case of failed eeprom read preparation
=
    
    Spo= nsored by:   Nvidia Networking
   = ; MFC after:      1 week
---
<= /div>
sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 3 +++
1 fi= le changed, 3 insertions(+)

diff --git a/sy= s/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c<= br>
index e1dbd02fcf3a..962705e6d258 100644
--- = a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
+++ b/sys/dev/mlx5/m= lx5_en/mlx5_en_main.c
@@ -3674,6 +3674,9 @@ out:
=
/* Check if module is present before doing an access */
module_status =3D mlx5_query_module_status(priv->mdev, module_num)= ;
if (module_status !=3D MLX5_MODULE_STATUS_PLUGGED_ENABLE= D) {
+ mlx5_en_err(ifp,
+   &n= bsp; "Query module %d status: not plugged (%d), eeprom reading is not su= pported\n",
+     module_num, module_stat= us);
error =3D EINVAL;
goto err_i2c;
}


--775e74ac73ea4ddb9d8a89b5497dea89--