From nobody Wed Jul 17 14:24:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WPJ9Q0KSBz5RPx0; Wed, 17 Jul 2024 14:24:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WPJ9P5M6Zz40hl; Wed, 17 Jul 2024 14:24:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=32Cmaj8pBKubAnZMeerytF4RNANpn4XCyWd1UEXUEtQ=; b=mcdEq71HWJVO9M47wdLEo8pQf1UdUYJpHYR90/w/Sp1v03P+YSgnXzLkg1om817Y0bmcQn 9ar7/1uJrMpckwozgO5rqYKqCmjSjrrPrVRQJ9om8nwbMQtCsWvig3Db6pnHDnO1XDHk9P QTbhcdasieFf7r6KY22AIOs/Jx5JAxUC78yWjeBxjtDiTxW6RL1gCOjvFlW6tSx6LVihXp M5HADSrs9cCYP+Jald3SaFXG1fl332Xb6Y8IlVWT9+MGn/s1hnNURBbrI2kfOUshPYNT3+ unYb1KZ1RuB4P3x/CRxuwMuVeKeWOQ2gAtM5jXPzNWPrITuAlli5iT56InPZIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721226281; a=rsa-sha256; cv=none; b=u5UgmR7xm3K+Ut4MpUwMDUbCxVcDewk9U1izFooCvExoQlEXJmObVcR86vEzhYxN5y5K24 onrwgN8uE21No1HsFB/rhMdPxUwT9SkIFkwOR4LmQidWIo1Yftvu+/o5DRWdDuSX+UHtEO qctIqQ3leLJRtVOI46h+xDZTIUMBny6FqmHY2ZFYFx2dZ+beBBOskSMZPfzu7yH9pwhbs4 JBW7QLRkHXhi5YMmJnKgujWsB5WeSegxvpK9Fwmvx7XdVVFRdqbYWDyU9EqsWUbnyJG7qD ceJtv8Ts4mgRjX9peN69QIG7bjz52u0GaTiuYZVrXQ3Xt+vHl9W8KFMUtuGpxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=32Cmaj8pBKubAnZMeerytF4RNANpn4XCyWd1UEXUEtQ=; b=HQVN1yi5s2GFPBySxghNc+62JUiWyDd5agoDWBg+8kc8M/eAuFM3k0PyADzITbHFm8D9gY FvytXqERdRP4fgI6wB1A6i6s5nHeiTSIQLnduf2uR+FvsA7EFVXCS8sYmbgrTVMNlQB57/ vS2raVNM/6Fg3esqmMS1lY6bd3YtmMpZ69yYKagQNH44zjiNsw87XM5+gswg7FKX571jru 2bRl16GCCpc3jKAlb5/pwXQwg3286qFm6KjHvvq4kYhjad5K3xxTXlbu+QYjc8GNRh/cMe DXeGawVREyAD7RwyLEG4zslx84VTJl3KM0POjG29AvbmK3xHkS6fNULdE+rpow== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WPJ9P4yq1z1MdM; Wed, 17 Jul 2024 14:24:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46HEOf9w033295; Wed, 17 Jul 2024 14:24:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46HEOfNK033292; Wed, 17 Jul 2024 14:24:41 GMT (envelope-from git) Date: Wed, 17 Jul 2024 14:24:41 GMT Message-Id: <202407171424.46HEOfNK033292@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 352bef734c4d - stable/13 - cxgbe(4): Minor tweaks to comments. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 352bef734c4d7460eb65ad2b1a9a263d58f18e09 Auto-Submitted: auto-generated The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=352bef734c4d7460eb65ad2b1a9a263d58f18e09 commit 352bef734c4d7460eb65ad2b1a9a263d58f18e09 Author: Navdeep Parhar AuthorDate: 2024-04-30 20:01:07 +0000 Commit: Navdeep Parhar CommitDate: 2024-07-17 07:15:43 +0000 cxgbe(4): Minor tweaks to comments. No functional change intended. Sponsored by: Chelsio Communications (cherry picked from commit 21aba396551e29808fa56a6d4fab17e871c3524f) --- sys/dev/cxgbe/t4_main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 80e798049aa4..6db64dc53440 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -5396,9 +5396,13 @@ get_params__post_init(struct adapter *sc) } /* - * MPSBGMAP is queried separately because only recent firmwares support - * it as a parameter and we don't want the compound query above to fail - * on older firmwares. + * The parameters that follow may not be available on all firmwares. We + * query them individually rather than in a compound query because old + * firmwares fail the entire query if an unknown parameter is queried. + */ + + /* + * MPS buffer group configuration. */ param[0] = FW_PARAM_DEV(MPSBGMAP); val[0] = 0; @@ -5410,7 +5414,6 @@ get_params__post_init(struct adapter *sc) /* * Determine whether the firmware supports the filter2 work request. - * This is queried separately for the same reason as MPSBGMAP above. */ param[0] = FW_PARAM_DEV(FILTER2_WR); val[0] = 0; @@ -5422,7 +5425,6 @@ get_params__post_init(struct adapter *sc) /* * Find out whether we're allowed to use the ULPTX MEMWRITE DSGL. - * This is queried separately for the same reason as other params above. */ param[0] = FW_PARAM_DEV(ULPTX_MEMWRITE_DSGL); val[0] = 0;