From nobody Wed Jul 17 14:21:54 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WPJ6B5Ljvz5RPMM; Wed, 17 Jul 2024 14:21:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WPJ6B2y4pz4tRL; Wed, 17 Jul 2024 14:21:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yFklu6tLEujCmjIBhyRt+ccU4Dr0rOZ36os8ducPmG4=; b=i2jR252IWz5DiGWiYwT8CeedZzQPk85g4Bjh/8Nzoc5GGCKhXZMokuGQ92dzkK5MBbHni9 N8FAozq+/1PO7sSYudyuD3PAu6JLtH3swcpX2eTJ2u5BHPA6jVBO9gBVTDpHLFBeBOHcVY NIUL2BqX4+Sdx4suxM+GItag5cdjCw2ptCvyllXO3uk8I54lo5sDaxYLL/aYER24y6TvWR 06bQ4rSoX4NjVwiX/Zz9nhOLgFjqJuSp3W8RltKpn331/SUHWquqTcLpESpo9BLNzL66ZR Cl739TPyIoEOd7FJOgyioF2ncy4GSDbgEBM8BhI0LM9liwilAo6nssYydXCSEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721226114; a=rsa-sha256; cv=none; b=GUA2LN2Oebj/nmHCfAfImJtRpt10iYZjqevrdhPHYOIKO9Y0RMto+zO6FvrxwTy+9plJJJ vVrbclZJohV9aJV6EdTpEAlDt4TCxeWAPE31IGA8JawC96/lQ5UFdSWP34RZMpSVq/rFDn FT62pGwTDXd7uWzBkrYJMm/yFeQSzz8nW2VSKGYAffZ72fTK7KodoQ2tYHIv6iHwVtPjoS unAdv7s0z/wnYKUwGGZpyf602z6ZgMAiCGR4OglHSZOE2f1XnnbBB5XnqBFSP7XxdUFNP/ TDNxU1CA2++b5p1LVJC5VFbftfqWFA1c282XmGzJ0i5Sxxxd2y6o1A29nUpiqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yFklu6tLEujCmjIBhyRt+ccU4Dr0rOZ36os8ducPmG4=; b=GlAC2HqK1k/q62aQShUxVLBMJswQyaenwkPUJsMJ9LVe+WgzaLMV6KpdzdWwBOq0+4khsA moXi5yN6rMNipQ7snNZZTP2D+emTI/RgqbUp4sgAeklF3pjMamlfXTi1lGV3Vc8c+n11IP VctljaxmI69gR5l+gLLWqKqjK9MUzOKJ5YHqtWb2xYKHuXtv5oNKMM8llbUG2HlBVRzEwa sTXK/pisk/KG7nPFQHNdPPKQCaZQHxtnMGh++05icWyL5fjigIScA3eKSVZX7ijPlBBT2c nPOA5oMaLprYtXPyxLKF5rawMKRDDrEeOWsZGUwfWbQ322UJYyuVkknyLbATmw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WPJ6B2V23z1MpQ; Wed, 17 Jul 2024 14:21:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46HELsLV031228; Wed, 17 Jul 2024 14:21:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46HELs56031225; Wed, 17 Jul 2024 14:21:54 GMT (envelope-from git) Date: Wed, 17 Jul 2024 14:21:54 GMT Message-Id: <202407171421.46HELs56031225@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 60bf442ee273 - stable/14 - cxgbe(4): Do not report link state change during interface detach. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 60bf442ee273e06b56b59698778d1569a3a55e30 Auto-Submitted: auto-generated The branch stable/14 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=60bf442ee273e06b56b59698778d1569a3a55e30 commit 60bf442ee273e06b56b59698778d1569a3a55e30 Author: Navdeep Parhar AuthorDate: 2024-07-03 19:01:33 +0000 Commit: Navdeep Parhar CommitDate: 2024-07-17 06:40:13 +0000 cxgbe(4): Do not report link state change during interface detach. This fixes a panic when multiple VIs are configured on an interface and only the non-primary VI is up at the time of driver detach. The problem was that the driver would queue a link state change notification for an interface about to be freed. To reproduce the panic, add "hw.cxgbe.num_vis=2" to loader.conf and # kldload if_cxgbe # ifconfig vcc0 up # devctl detach t6nex0 trap 0x9, rip = 0xffffffff8107db70, rsp = 0xfffffe0055263d60, rbp = 0xfffffe0055263dd0 taskqueue_run_locked() at taskqueue_run_locked+0x2a0/frame 0xfffffe0055263dd0 taskqueue_run() at taskqueue_run+0x72/frame 0xfffffe0055263df0 taskqueue_swi_run() at taskqueue_swi_run+0x18/frame 0xfffffe0055263e10 intr_event_execute_handlers() at intr_event_execute_handlers+0x249/frame 0xfffffe0055263e50 ithread_execute_handlers() at ithread_execute_handlers+0x9e/frame 0xfffffe0055263e70 Reviewed by: jhb Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D45864 (cherry picked from commit dc20d49aa939caea365cbdf0341b00de69253be4) --- sys/dev/cxgbe/t4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 2e885b9c3ffe..b60eda504b6b 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -12227,7 +12227,7 @@ t4_os_link_changed(struct port_info *pi) for_each_vi(pi, v, vi) { ifp = vi->ifp; - if (ifp == NULL) + if (ifp == NULL || IS_DETACHING(vi)) continue; if (lc->link_ok) {