From nobody Wed Jul 17 14:21:46 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WPJ624tpnz5RP1q; Wed, 17 Jul 2024 14:21:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WPJ62378Fz4t1w; Wed, 17 Jul 2024 14:21:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h/MKk+m0+biIieN+R4AuyzWtnVb0WBDxpNoDP6QosNA=; b=yWam9dmFIMwIL0c3RxzuE1AnoYDvfIIPrMfgpya5enLbhFvGdIn+eLGh4tMvmUyVfG/iwU fEetWnhXqqC+eO6z/3cp57r3fIjFxbNzzXUnky/9gxcscExD543xKX+JwRgLiJ2W/GTBRk 13csjtGfDm7pTuNqeT5ZKEC3OnpZwSZ7MYRr/wNSkQdUQOV/U7BjA/FCQCY4aKCNac7UD+ Nreevp52nc+a+GDmg26VdHuMChmcLxEkDOpNAOIjcCKUJrHn+poKYov8IqTWowkujQr+28 aWSgqIG+mZ2mJDYFHAWM1JdnAo4qrG5bhsm2W6eFc1pZAgEkRaDb/gA6K0UEgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721226106; a=rsa-sha256; cv=none; b=u8pmiuBx0Wa7/IUF+PIDEetLstobLhCNlEEjfIKXkLrLfMEGp7aHJ5g57gwPbNJY+oIGPY ds6C/j/92eXvb/Fqdakh5J68o6+PGEZ/4k0afye2lbAkk2lQwuSxzb6AnU6/9qvDyc7XlT e5C8wvHHWsiYMYb679ybv1rNxYtO/AZ6yv/Ta588Z4y8oCbhR9Vm2bXK98FSSZvxAy52/8 DgcBxHqmwtp7v3E4ZPixzv1qESA2DHmOBfp00z0qsUv2iia1CsSXdtGg5KzPiJOPuyG5s/ USIp/cpdDs9kw1VKIpi7d5OKW9nApyHfZm47eht0sD7tx/RpGs5pSIiko+WJDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h/MKk+m0+biIieN+R4AuyzWtnVb0WBDxpNoDP6QosNA=; b=TVo9PK5i1Iq5MqD4pFy0eDems54VgqpfwPCLt6J4r/F47njpSkyxGqX1oxegyKfbo7EAEi Fczmp11q7pFmQNCPpA288eRB+5MltPcQEs42LqxBELRhySBydY0G6kHJHDhp2oZoxsZgw7 qdDPfloDcXFSIVV7zBAg39BBJHkvN8t7Nwe3NwQcvjJkpC3SsNGx71TsIscFmp/25myvMa pmsK3Aj+BbyKze9xm2Oy6nGFXCyS80UEgImYUOzDXdm788kq1mV+QaUrsgVvrhNi4yQwk+ Y90zNZrkXCl+qDk+b+tRzIksRnnmVpN6xWRwq3h6BKQa8yOdft0Uas1SeycoKw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WPJ622lKrz1Mmt; Wed, 17 Jul 2024 14:21:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46HELk8L029921; Wed, 17 Jul 2024 14:21:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46HELkYY029900; Wed, 17 Jul 2024 14:21:46 GMT (envelope-from git) Date: Wed, 17 Jul 2024 14:21:46 GMT Message-Id: <202407171421.46HELkYY029900@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 5af25b6e4d55 - stable/14 - cxgbe(4): Minor tweaks to comments. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5af25b6e4d5514c10028c6bce89d123a6162a2de Auto-Submitted: auto-generated The branch stable/14 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=5af25b6e4d5514c10028c6bce89d123a6162a2de commit 5af25b6e4d5514c10028c6bce89d123a6162a2de Author: Navdeep Parhar AuthorDate: 2024-04-30 20:01:07 +0000 Commit: Navdeep Parhar CommitDate: 2024-07-17 06:38:18 +0000 cxgbe(4): Minor tweaks to comments. No functional change intended. Sponsored by: Chelsio Communications (cherry picked from commit 21aba396551e29808fa56a6d4fab17e871c3524f) --- sys/dev/cxgbe/t4_main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 4834a4fc2873..04f564124356 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -5323,9 +5323,13 @@ get_params__post_init(struct adapter *sc) } /* - * MPSBGMAP is queried separately because only recent firmwares support - * it as a parameter and we don't want the compound query above to fail - * on older firmwares. + * The parameters that follow may not be available on all firmwares. We + * query them individually rather than in a compound query because old + * firmwares fail the entire query if an unknown parameter is queried. + */ + + /* + * MPS buffer group configuration. */ param[0] = FW_PARAM_DEV(MPSBGMAP); val[0] = 0; @@ -5337,7 +5341,6 @@ get_params__post_init(struct adapter *sc) /* * Determine whether the firmware supports the filter2 work request. - * This is queried separately for the same reason as MPSBGMAP above. */ param[0] = FW_PARAM_DEV(FILTER2_WR); val[0] = 0; @@ -5349,7 +5352,6 @@ get_params__post_init(struct adapter *sc) /* * Find out whether we're allowed to use the ULPTX MEMWRITE DSGL. - * This is queried separately for the same reason as other params above. */ param[0] = FW_PARAM_DEV(ULPTX_MEMWRITE_DSGL); val[0] = 0;