From nobody Wed Jul 17 14:21:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WPJ5y1nH1z5RP1k; Wed, 17 Jul 2024 14:21:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WPJ5y08M0z4sjS; Wed, 17 Jul 2024 14:21:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zmWMJjfqiw77rlj/7awc7NKSw1ZnMAz2krwmbZnY2Tw=; b=lZvM3t22qc45uhtyVHWpdSBJt48AbDH13k2lyRrtDjVuX34ZveE+EJ9L7ZZ5AG6zOKfDlY WubfUc1Zj1dC8xu1kkziw92VumGLC6lVEVUEPBmKNgWql5QqdixPHfZSm2qOWdkLyPl2a1 Ak9CEaFhB2DVagkrD0h88DDIE9jezBS1f+25Lh1KQkVNbdWno7ti6dpvOKam2gNBar0H6W Np2S4YViDJWS2EdUOBi0fJB8BbHOmW3n8BefzG0HMUL2EAxQ9kq7LWJpPnhoncv0zbZ1hA tFqzNCwhFSbyeF2EbtsIpLWCyZ2x5glK8uXIbeQS7HdfTkblGu94Mred1knuaA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721226102; a=rsa-sha256; cv=none; b=vmAjDonsLUXzpzZSTahAHz3qJ14XEYRTg9bsYvxZSHVKZqPBmIIE5nyv60vcdyG8zLKnmP 5eFyYIcufRsZzA1bEWB4/qfQQ+eAVRVXPEGU1biQ/8a0YQLCm6ZFlHNC+vMOAKFPkQ0ZkC YvtDhZwHWyNfdvEYQzLezpNfh3ySpuWzdLkMyfzFZRZ4qHv2bSqXi2ORPqk08oHbjPu0CN Vgl60mKg8g/DIC2BBNl2iepS7iGrWGGTqOUq8EF00lUK2+ed9h856DRCikSWJXd67H2OGf TvilfqqW4Ix+gs+wvnGRN0hRp9ZSv0hVgX78VMWTBYABj8se0vZ4OwEPqy8gow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721226102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zmWMJjfqiw77rlj/7awc7NKSw1ZnMAz2krwmbZnY2Tw=; b=ZBfeELRX3iT1HEHzQ5oF0IjPlmEGosF9WCh6ylowStzkhsheToW5ql3lviNpguMurKfUgt 16RLgcGrwQ7PfOR88JA7zIUGpuqFM9UK4uyfhduZg5vO5iylOvPM4AtJiw4K9iH9tf9FWP vVqBjzkD3bRHWRbk8rdB6fd9V5VqYU+ASYYufLRh+eWdfQb1+AIq4a7+uYHb1phB0R0SvT 45bbaHRqMwwRaeVUjBogjLDKJMKCtM5QWk/eKFLluQKH4WsaYdRvWLKJyIyTOiarJwdAt4 lrPClhyYCHDew72CLf1tPdhLT6dgbu0AOadL924oXaI/n50eIe+qp9RS+tBTjg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WPJ5x6qSXz1Mp9; Wed, 17 Jul 2024 14:21:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46HELf4F027038; Wed, 17 Jul 2024 14:21:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46HELfvI027035; Wed, 17 Jul 2024 14:21:41 GMT (envelope-from git) Date: Wed, 17 Jul 2024 14:21:41 GMT Message-Id: <202407171421.46HELfvI027035@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: a238d1b04522 - stable/14 - cxgbe(4): Shared code update to deal with partial failure in query_params. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a238d1b04522565d6ce20cea69b7c26e23266595 Auto-Submitted: auto-generated The branch stable/14 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=a238d1b04522565d6ce20cea69b7c26e23266595 commit a238d1b04522565d6ce20cea69b7c26e23266595 Author: Navdeep Parhar AuthorDate: 2024-02-14 01:28:53 +0000 Commit: Navdeep Parhar CommitDate: 2024-07-17 06:37:03 +0000 cxgbe(4): Shared code update to deal with partial failure in query_params. Obtained from: Chelsio Communications Sponsored by: Chelsio Communications (cherry picked from commit 2965ae59144177eb3570721295da9cbc447f1105) --- sys/dev/cxgbe/common/t4_hw.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/sys/dev/cxgbe/common/t4_hw.c b/sys/dev/cxgbe/common/t4_hw.c index 9048884eeb7e..8a225849930d 100644 --- a/sys/dev/cxgbe/common/t4_hw.c +++ b/sys/dev/cxgbe/common/t4_hw.c @@ -7740,9 +7740,18 @@ int t4_query_params_rw(struct adapter *adap, unsigned int mbox, unsigned int pf, } ret = t4_wr_mbox(adap, mbox, &c, sizeof(c), &c); - if (ret == 0) - for (i = 0, p = &c.param[0].val; i < nparams; i++, p += 2) - *val++ = be32_to_cpu(*p); + + /* + * We always copy back the results, even if there's an error. We'll + * get an error if any of the parameters was unknown to the Firmware, + * but there will be results for the others ... (Older Firmware + * stopped at the first unknown parameter; newer Firmware processes + * them all and flags the unknown parameters with a return value of + * ~0UL.) + */ + for (i = 0, p = &c.param[0].val; i < nparams; i++, p += 2) + *val++ = be32_to_cpu(*p); + return ret; }