From nobody Tue Jul 16 07:35:01 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNW8Y22XZz5Ql9w; Tue, 16 Jul 2024 07:36:13 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from mailgate.Leidinger.net (mailgate.leidinger.net [IPv6:2a00:1828:2000:313::1:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mailgate.leidinger.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNW8X5mF9z4w1v; Tue, 16 Jul 2024 07:36:12 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Authentication-Results: mx1.freebsd.org; none List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1721115356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1603q+GmBkN3MqMH4LDM9c8JhL+PoDWWcyOC8TCwnn8=; b=ETaW6Iv+9FWSddVBxM20cVK+l2IP+TlPwh0Y+sOMPQeG7m9tJBojEByGoQOqp3SwPvYTe4 KK7azuThdxmAUZs/FH0HCo9QBbwcSJHxm4zkBU2C7h4Q46eXnv1N+m4Rm6SG8v++64OAmQ RyzYmf1dx7+Cb/qrVCK9DOei2IsyWCKpNzLpXqt+wmtCFbEUQgjTZawB6k4IALixItygkH qJWSiIicvAKw6tFkvjMoe8BbA8qCPwsvJWyXpIDL9LTAbltDUGzfr8RH3UNjTI1pPxuamO S7AekynswONIaI4JMJInL6Gh6rt2WlITWzUDc0i0u7PMOgMuhQg1+BsytZT60A== Date: Tue, 16 Jul 2024 09:35:01 +0200 From: Alexander Leidinger To: John Baldwin Cc: Mateusz Guzik , Mateusz Guzik , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 87ee63bac69d - main - locks: add a runtime check for missing turnstile In-Reply-To: <752a3f0a-438e-4465-a8ae-47700e79306d@FreeBSD.org> References: <202407111107.46BB7uSb007077@gitrepo.freebsd.org> <81cfe7ad-cbee-4122-abef-e47ce2b34f05@FreeBSD.org> <752a3f0a-438e-4465-a8ae-47700e79306d@FreeBSD.org> Message-ID: <281b2b20d14c3a90614e6ee8127666dd@Leidinger.net> Organization: No organization, this is a private message. Content-Type: multipart/signed; protocol="application/pgp-signature"; boundary="=_9fc0b88989e8e38f60dd43ff24786617"; micalg=pgp-sha256 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:34240, ipnet:2a00:1828::/32, country:DE] X-Rspamd-Queue-Id: 4WNW8X5mF9z4w1v This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --=_9fc0b88989e8e38f60dd43ff24786617 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Am 2024-07-15 22:13, schrieb John Baldwin: > bugs might have been useful in the log as well. I think it's fine if > we want > to have some checks that are always on, but it's currently quite rare > so > needs a bit more rationale in the log than other changes is all. Is this a "we want to keep this permanent" change, or is this a "we see bugs, we don't know more, let's add this to have more people stumble upon it with more info until we know what is causing this and then remove it together with a fix" change? I would tend to understand it as the later (which maybe should lead to a commit to comment this part as such). Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_9fc0b88989e8e38f60dd43ff24786617 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc; size=833 Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmaWIrQACgkQEg2wmwP4 2Ia65g/9HiFZJNNmbByeSuE59TVZ6jOL+CwLAepcZd7Lbv1U0p7PwXheYn41cCnb YbMQPiPv0nLdF5N/chs8XQwrIC9gxje80Sf2uJlNM7NTTlCyuDUiAnP+WaqhHOdu NxSsXrgltiZRbS6toVWlP348wFMR5FJ/gtjihlHV23D13mR1RkFdaxGnqn/Ru5cZ m5ICMs6NZm+aN+DokWPSri+sXmqkMKmDTwKhQG6ZOctgXGj9EFpRuaQs/F53DVZR Dhaysotl+78qdz4FK9iKYLZetBJvHHyxOGmOeTPWE5+tkH1QbBzK/lXV4A2mAPL/ 5aZ/Md7W/lNXjqnwrb7jV9tSfDwn5inieoKMj0EzkjNriN33XOOxiRotP25Es+Qx vpKQ2nQshNArRgGSrg4+jZcKZHPgawri3tgLM1DGJW01vuN7H9pt0LMnMhlLgLq1 8BlAVARN49ebV3o8SqXfpSWnIvqjNemz/R9SypMsRFvpmTnBCqo2xNKMWPQl47yI bhY06ulpByTl/cKyxFB/JG4cx3PMeMhv21+SnrtatnBxhUhge5GzncGyMO0nAmrm 6B44A3ExTu/IHm8UgjJONLBujyeg2mGYRoBpUmQHFNtdX/06bbqEyj1a5y0cBaUD k8s74bI/7y9fRnJAIuJjAKiH/E2kqd5+Q4PvcWlsA4O2inDvKvk= =kqCO -----END PGP SIGNATURE----- --=_9fc0b88989e8e38f60dd43ff24786617--