From nobody Sat Jul 13 14:57:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WLs5G6N90z5QShB for ; Sat, 13 Jul 2024 14:57:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WLs5F3NBlz4X22 for ; Sat, 13 Jul 2024 14:57:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=yMlhtqBv; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::329) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-708bf659898so368758a34.2 for ; Sat, 13 Jul 2024 07:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1720882656; x=1721487456; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=K4xbI/36PM50MqO62dfkw0j1/V8DWglcU0j2fYz0pfg=; b=yMlhtqBvoNcFivsvx94Ikt6+ai6PC+Z+zcnILrixlddJfU27DnYFVqPk3RI3bcS/LR jvMo5e3HjDU8BBmG+n+GAPw2mHDejk/YiuUvewfXGtw0VykTpealt2X3qEoeG8CvpMZJ uYKZ03uIvpXuL3m9KJsXbWSb6vRA4DzKV+nMIYTL1exz3Eszr8ZkrtE2ADcuu0qG0D4S tFBwMTqc31OJ/W0r/FuTQAMKOm6fd2hlKpBPX/jRFzaPS2ktrN3ZfHaiDMF8u4Rc8Z0J u7yprxhQG4XUeslH3WNmWqUAMSPUcjVEGy4+0d05tpEHM+DcswIhfuYm59WBJ9SScd5c 0wfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720882656; x=1721487456; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K4xbI/36PM50MqO62dfkw0j1/V8DWglcU0j2fYz0pfg=; b=rCR/Pzs7z4krKoE+D8rcd+sTnMXuNbFXfcNqnWv/LWgvvvv5bZpm/g56Pd4G6za1eg H9P1xqQ0MGmrD6V1LSUOjlE58bck1PA6QybhvozEdhDD3rAKHsNmVUd07vr8ccAyjLaM G5kpXM1pfSjI7jLhY2Z9jlY+tEBBhyn+qIMRT4QFOM2dcx4Yx4kfCBppDHi7ln7tFTjy dQ806XkAcOuF9y3QTuhvyajLW+iKYXWupXJJR3NGMKDZnjmKv/thND9SnnzrlusVZLR/ yGwJODlkLvAjr2VC0UpkRvRsgGip3NitrHJyYelI0y1Bhnqj+cGyQoqEf85yRC69ZHgn bYcw== X-Forwarded-Encrypted: i=1; AJvYcCUXIqLkDKmxKi7Q9a4NqpPH+cIyqpv9bFt6thylHoeK2vzSh/dhbqkLccIOejI7pLaAzZcUnQpIQsjqwruQKB2b/V4FwBGaulcqgO9m2HfG X-Gm-Message-State: AOJu0YwIrQB4RDBYOmibw8/SJoloPXcgPbObmbfcYgaALyBZckk3w7VR kulXAYYbzcns6T+R+oX+Wi/kWowA/UXftMR7QJAtfR3zvXG7EVqNhOzmUyZlMXFww4TtR+beHmN WB5SjloehnyeHqdIJNEsPp19d+47zH3xNOiSeB/e5AeVZ4AgNna8= X-Google-Smtp-Source: AGHT+IGktudakV+7XzQbcTKsQItvefZCJfCCnMuIVi9Hjwt19FGBIkEQFx5a8X7k6aIqWd0WeJ2WTdJYKo3xyGjlkWc= X-Received: by 2002:a05:6358:6f19:b0:1ac:671a:f39f with SMTP id e5c5f4694b2df-1ac671af3f6mr94176655d.11.1720882656403; Sat, 13 Jul 2024 07:57:36 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202406281500.45SF0sOZ057462@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 13 Jul 2024 08:57:20 -0600 Message-ID: Subject: Re: git: fc3e5334ab89 - main - Fix "%hhi" conversion for kvprintf() To: Konstantin Belousov Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000006f7e83061d223750" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.974]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::329:from]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; R_SPF_NA(0.00)[no SPF record]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4WLs5F3NBlz4X22 --0000000000006f7e83061d223750 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 28, 2024 at 9:13=E2=80=AFAM Konstantin Belousov wrote: > On Fri, Jun 28, 2024 at 03:00:54PM +0000, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dfc3e5334ab891eab22a4278384be6f9= b74d6d91a > > > > commit fc3e5334ab891eab22a4278384be6f9b74d6d91a > > Author: Sebastian Huber > > AuthorDate: 2024-06-13 11:01:31 +0000 > > Commit: Warner Losh > > CommitDate: 2024-06-28 14:57:39 +0000 > > > > Fix "%hhi" conversion for kvprintf() > > > > The signedness of "char" is implementation-dependent. > > > > Reviewed by: imp,zlei,nightquick@proton.me > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1290 > > --- > > sys/kern/subr_prf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/kern/subr_prf.c b/sys/kern/subr_prf.c > > index e291a1fa00a6..4dc989e2d1f1 100644 > > --- a/sys/kern/subr_prf.c > > +++ b/sys/kern/subr_prf.c > > @@ -904,7 +904,7 @@ handle_sign: > > else if (hflag) > > num =3D (short)va_arg(ap, int); > > else if (cflag) > > - num =3D (char)va_arg(ap, int); > > + num =3D (signed char)va_arg(ap, int); > > else > > num =3D va_arg(ap, int); > > number: > Isn't the same fix needed for libexec/rtld-elf/rtld_printf.c ? > Oh I believe that it is. The code is different in appearance, but it's clear that this is needed there too... I'm a little behind on things, but I hadn't forgotten. Warner --0000000000006f7e83061d223750 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Jun 28, 2024 at 9:13=E2=80=AF= AM Konstantin Belousov <kostikbel= @gmail.com> wrote:
On Fri, Jun 28, 2024 at 03:00:54PM +0000, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Dfc3e5334ab891eab22a4278384be6f9b74d6d91a<= /a>
>
> commit fc3e5334ab891eab22a4278384be6f9b74d6d91a
> Author:=C2=A0 =C2=A0 =C2=A0Sebastian Huber <sebastian.huber@embedded-b= rains.de>
> AuthorDate: 2024-06-13 11:01:31 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-06-28 14:57:39 +0000
>
>=C2=A0 =C2=A0 =C2=A0Fix "%hhi" conversion for kvprintf()
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0The signedness of "char" is implementatio= n-dependent.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0Reviewed by: imp,zlei,nightquick@proton.me
>=C2=A0 =C2=A0 =C2=A0Pull Request: https://github= .com/freebsd/freebsd-src/pull/1290
> ---
>=C2=A0 sys/kern/subr_prf.c | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sys/kern/subr_prf.c b/sys/kern/subr_prf.c
> index e291a1fa00a6..4dc989e2d1f1 100644
> --- a/sys/kern/subr_prf.c
> +++ b/sys/kern/subr_prf.c
> @@ -904,7 +904,7 @@ handle_sign:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0else if (hflag)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0num =3D (short)va_arg(ap, int); >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0else if (cflag)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0num =3D (char)va_arg(ap, int);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0num =3D (signed char)va_arg(ap, int); >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0else
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0num =3D va_arg(ap, int);
>=C2=A0 number:
Isn't the same fix needed for libexec/rtld-elf/rtld_printf.c ?

Oh I believe that it is. The code is different = in appearance, but it's clear that this is needed there too... I'm = a little behind on things, but I hadn't forgotten.

Warner
--0000000000006f7e83061d223750--