From nobody Mon Jul 08 23:39:27 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WJ0vh1VJRz5Qt7d; Mon, 08 Jul 2024 23:39:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WJ0vh10QRz40WN; Mon, 8 Jul 2024 23:39:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720481968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AyxgsMUO9aPhQ207YXNj1zY7MjBXX9mlc5I55rTprzI=; b=kckh2/tua3ksXKOpZkrSfnxt7iJYyTuN60f+gPSfoPyiAuDAndDCeVn89DsFOQcv7WWZDV jsXn+q7hSCn5j4ZnYqpHmzfQzJp/Xd57mNAKkhdpzapd5u7t58EgiFJK/nFwXa/2P23OFc VVhTvGDGLC3DriurZDCa8td+A5R3nvQu2wr9rgD774aar/335+eKkF5brEPtMe1tBJhBfP E1UuUJF+l6JP/GzIrcdYRcvgFXkUowWiGaIWh08IboR3d1sni18reR/T4qRIKyGr6iGX5B e5JNXfaIbrcAXGgUckbjYZvdCF6HHyP9qo+RCiIvityal+kaTcPvS1prphFE1A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720481968; a=rsa-sha256; cv=none; b=JzQr4QRV8TfcJUngvZtGuyjD8Iwv4RhCCq8lxG49g7shcHuBqNgfgh3+42wPhDeh9PQN1C 3KTjfUSQ2SltK+wl51ncBBK0bDk6Ey+UkgYehZyDUDVJzL9EU2caDGLZOsACobXu067oUz aqXFP3RHwCcCsGeUoPtIpEK/v57YHeVK/9/dleHAj1V1XbOOWVgwh28BCG1Q19ZIrsHr/p X97U/xp3jykGpq9lR7jYRbxB1wbDsKXc4X9qedFWQiszjq1PdKYq69FdB8M6LAX5esZVui OSs8cLbQQU3qZYmhFMYN+xMJTQyMK6JwgmYmAeWk436+5cx6yNwsMyQhdcJlGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720481968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AyxgsMUO9aPhQ207YXNj1zY7MjBXX9mlc5I55rTprzI=; b=ISsnh8oM4Yelv49DKi+8292Y9UyGbBfcNiROEPnRYvRgF4K+5L+pz9TJHHsxMm7Lkz9uwv yX1C0rx09sP29bo8SPeMcfBKNqWCZIGOsFxfBJg2+k4Sm9cX7piM3PkVPQbTj7Lc9OqQDm EG1DP6SLNuD3k0fufx+oaodsvTZHegyE4lDy8icoJ1w6otDsfbUEs/eGqIMFYMTk2yxoZH BMD2AQoY+eMqwxTjF+OjMRr+o+APJa0ZU4oiHTAh/PMxmqZMvD0VUfDa9czL1OUlf9dhG5 5fl9mBcYZM/fzrbR3A5mdAruyvkKVrGeiST1zsIwv0If3gckUpstYNcdkN3KDw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WJ0vh0Szzz1B6R; Mon, 8 Jul 2024 23:39:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 468NdRvE033640; Mon, 8 Jul 2024 23:39:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 468NdRmZ033637; Mon, 8 Jul 2024 23:39:27 GMT (envelope-from git) Date: Mon, 8 Jul 2024 23:39:27 GMT Message-Id: <202407082339.468NdRmZ033637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 53734ccd4261 - main - Potential typo/copy issue List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 53734ccd42614e48ae227f88161af89c807cdbcf Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=53734ccd42614e48ae227f88161af89c807cdbcf commit 53734ccd42614e48ae227f88161af89c807cdbcf Author: Ted Spence AuthorDate: 2024-07-05 04:22:42 +0000 Commit: Warner Losh CommitDate: 2024-07-08 23:36:03 +0000 Potential typo/copy issue This test here appears to be clamping the start and stop values to a minimum and maximum. But it looks like one of these lines may have been copied incorrectly. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1317 --- sys/dev/cxgb/cxgb_sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index a2b3918032bb..1b82f2ebcaae 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -266,7 +266,7 @@ check_pkt_coalesce(struct sge_qset *qs) if (cxgb_tx_coalesce_enable_start > COALESCE_START_MAX) cxgb_tx_coalesce_enable_start = COALESCE_START_MAX; if (cxgb_tx_coalesce_enable_stop < COALESCE_STOP_MIN) - cxgb_tx_coalesce_enable_start = COALESCE_STOP_MIN; + cxgb_tx_coalesce_enable_stop = COALESCE_STOP_MIN; /* * if the hardware transmit queue is more than 1/8 full * we mark it as coalescing - we drop back from coalescing