From nobody Sat Jul 06 18:24:07 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WGf0m2pK5z5PMDn; Sat, 06 Jul 2024 18:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WGf0l66tbz544r; Sat, 6 Jul 2024 18:24:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720290247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G3Xpbw9JWEtuwJFAqesCpDlS8HVrgyeM/zm9ZBudyiQ=; b=SaUPn5I30BXrUXXg7nrbmRkTEFPKEDdxkSqrtL6T07EltcmLkfnva/jm7JW1IeDFDBITeZ PzKsFujt1gdowih+M0E4fUxTFD08c4Q5fFDG5cpq2+GF9QB4Tdh1V++V3sHhnDJFeLBQTn TfOOP62CZEHRf1FjlGowUq8+yUEOAqB92BBFY/FyTvrNWwQ0dKxX5NKOa9+uijvrUc+5IQ E2IN4oxMb5LNPx+Q6fhc2wNBAMwTzVCoEpCmdbjjBluDNZblEvxvuF273OdxcvRfp55+BB XDb67+9kRP9HOSZj6983DnC709l9oLP+p5NB1owMu4Ja+WcRt7LsH0ikHrXeGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720290247; a=rsa-sha256; cv=none; b=WjzMhSvU1a9/gUy5h3GNmqhl7bLwWlgyfSameId4wr2saQX0eYkgd5U1NfnDmWpA8WVtxF qGWSeNBxPUVReGI6o+5SYyn96FV21Y593p/Jy0L98uEOzTFAEs4q7Jbn7/cXrEGJkESYmD E2gcc3WF/bv1BazJyUPixf01cPV6Gkc/KTKS53HxMpx9LFU7k4HxKABaQDuTbrc71dc0cz DBCpKRoT3U4yWRsifl+6q1XvpmqZbBDBTknbPYKeIiChAVGMx5TKZfLJlKXDPg+J1G232l tt6YH3Ykv06IMHJKrQE1teR8E/U0QbRz6y0qlXZZp5g7rY5Qzk6IPWCiNNoCtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720290247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G3Xpbw9JWEtuwJFAqesCpDlS8HVrgyeM/zm9ZBudyiQ=; b=uDjWZsfg4f0yFhg7HQ4k67RD2LVHG9YqbNMVkpiMgdMjlW8ZF03kGxNFqIkujFTM8L07qr ZTUY0XlxMr/3gywCoxHx00jfMYL4mH5FWFgLEnujJoeCi6JE8vh/GNUft2l2snVCr/F33j tl+nS7pNSAVBPBGCZwZ83+UmvyaUQcx4QCTTq5utI8XKAjC2KiXOGyfijSV2Hgj99BUwS1 POnRU1WJ2xSsNULUruu/h3VRrP9ICQIsC9A4XDPuqXbq9UE9+aHexxkUzH5J1oi1z40poj Ilsk700OkprSCCZYjNbDc6EswKcDqk4VSJNTQ2dBbT+aVuD0FE4VzDj2a69kvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WGf0l4sGCzrLB; Sat, 6 Jul 2024 18:24:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 466IO78h090632; Sat, 6 Jul 2024 18:24:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 466IO71F090629; Sat, 6 Jul 2024 18:24:07 GMT (envelope-from git) Date: Sat, 6 Jul 2024 18:24:07 GMT Message-Id: <202407061824.466IO71F090629@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 3402d474ceb8 - main - snd_uaudio: Remove unused sc_sndstat sbuf List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3402d474ceb8541d07689bad6960f90739129997 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=3402d474ceb8541d07689bad6960f90739129997 commit 3402d474ceb8541d07689bad6960f90739129997 Author: Christos Margiolis AuthorDate: 2024-07-06 18:22:26 +0000 Commit: Christos Margiolis CommitDate: 2024-07-06 18:22:26 +0000 snd_uaudio: Remove unused sc_sndstat sbuf This information is also printed to dmesg(8) on attach. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, markj Differential Revision: https://reviews.freebsd.org/D45771 --- sys/dev/sound/usb/uaudio.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/sys/dev/sound/usb/uaudio.c b/sys/dev/sound/usb/uaudio.c index d47eb86ed271..c202ac581119 100644 --- a/sys/dev/sound/usb/uaudio.c +++ b/sys/dev/sound/usb/uaudio.c @@ -368,7 +368,6 @@ struct uaudio_softc_child { }; struct uaudio_softc { - struct sbuf sc_sndstat; struct sndcard_func sc_sndcard_func; struct uaudio_chan sc_rec_chan[UAUDIO_MAX_CHILD]; struct uaudio_chan sc_play_chan[UAUDIO_MAX_CHILD]; @@ -391,7 +390,6 @@ struct uaudio_softc { uint8_t sc_mixer_iface_index; uint8_t sc_mixer_iface_no; uint8_t sc_mixer_chan; - uint8_t sc_sndstat_valid:1; uint8_t sc_uq_audio_swap_lr:1; uint8_t sc_uq_au_inp_async:1; uint8_t sc_uq_au_no_xu:1; @@ -1293,8 +1291,6 @@ uaudio_detach(device_t dev) if (bus_generic_detach(dev) != 0) { DPRINTF("detach failed!\n"); } - sbuf_delete(&sc->sc_sndstat); - sc->sc_sndstat_valid = 0; umidi_detach(dev); @@ -2149,15 +2145,6 @@ uaudio_chan_fill_info_sub(struct uaudio_softc *sc, struct usb_device *udev, if (rate > chan->pcm_cap.maxspeed || chan->pcm_cap.maxspeed == 0) chan->pcm_cap.maxspeed = rate; - if (sc->sc_sndstat_valid != 0) { - sbuf_printf(&sc->sc_sndstat, "\n\t" - "mode %d.%d:(%s) %dch, %dbit, %s, %dHz", - curidx, alt_index, - (ep_dir == UE_DIR_IN) ? "input" : "output", - channels, p_fmt->bPrecision, - p_fmt->description, rate); - } - next_ep: sed.v1 = NULL; ed1 = NULL; @@ -2230,9 +2217,6 @@ uaudio_chan_fill_info(struct uaudio_softc *sc, struct usb_device *udev) if (channels == 0) channels = channels_max; - if (sbuf_new(&sc->sc_sndstat, NULL, 4096, SBUF_AUTOEXTEND)) - sc->sc_sndstat_valid = 1; - /* try to search for a valid config */ for (x = channels; x; x--) { @@ -2263,8 +2247,6 @@ uaudio_chan_fill_info(struct uaudio_softc *sc, struct usb_device *udev) if (x == (channels + 1)) x--; } - if (sc->sc_sndstat_valid) - sbuf_finish(&sc->sc_sndstat); } static void