From nobody Mon Jul 01 15:24:59 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WCVGM4G6tz5P85K; Mon, 01 Jul 2024 15:24:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WCVGM3hCWz46YV; Mon, 1 Jul 2024 15:24:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719847499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SguJh6odm78mKbLmNZWQ6uxurnZwCN0Ww7Xc/cDZK9A=; b=Iwkq4z2E8zNEz+eNg9ffZgjsSBD+/8PqEgMbgKttyN80oM1qgksPAt2k50/moeRYy+pvcF FZMyFIOSLiUbxzesEWHCxO6XrwA3OYxik9IDNyfV6OSxoV8xLpmWiItjNIgxvp/zxnn94y 6QvP3XZevYqRw26amlUZ+vh5AGlIAE3NSuNPI3WIKRZKAW2Bcwjo8V4Pywo47dCcJaWO/y mXpChiGT4wM/N2ni+XSEglB0m5LSBNLtCHacqt/3B86GFSh6CNA9geyjViBSoSxtKku/9b l6K0Lwcxw73nKDUBhMkQd0p6rrF/7demWahwoS3uBM5dZ92R6YENgMUF/WF3Sg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719847499; a=rsa-sha256; cv=none; b=GDlTaFZ3sdK1sGETllSX3/F6GZ59KpHDqhFZ+ToEp6j+tqusjmwFJxlGkWimilUPE+O2B4 gMC3BVgjCSAvV0A9xYDg4ZQqNvNgBUxN46sOypUsv5dNd97jY+eftoOddxgbJNfXOGTEJR oNOw40qbfxF/+JJYbvaX2sGdhWIalJ3j8qW6wzxPj/cgDaVNxJCdBhKvPzN+MZI+o2QLEL HNdRAp+2RjPXdXqv1/z50psIBmZ9KaAYQKlgNqt/0nRGGpI42kgZwcL9JR/RW6c49RUBFG 3zykjVOuFyDOZO7FNZj9ya8If0Xa1UJlzWB81XUwZ7V1kSlA39jKnumKpBatew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719847499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SguJh6odm78mKbLmNZWQ6uxurnZwCN0Ww7Xc/cDZK9A=; b=SFOt5YNfEZYOLu3B0uao8k/784miGU8XRKI0avvgOc8MeTNahbvdBTTOJeUxeS82QcEp00 LA91+fgC50SG0KTVIofvcLwLw8xOORo0OO29TfPkwyLTNOznyB8ksNKFmpjbywpImIeegj dfYT1PpnpORLeUQYSVgewJEPFvEkQMXHiST0Zv9EhHdrmVz0N6uIU7EkWCc4uIJelhL5L6 5ihEwKPWZYL0k+ZgszE1mRMTQn6mNJKANE0hypBLCLlP684IeHJ3Qr3vSVxDvEfbmLOfcj EP6kqDxN8QWP27cbdGffeg0NfyoHpJWHnubNTYVqw0WPyTRdX2/7o2Jfv7It9g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WCVGM3DqBz19Dc; Mon, 1 Jul 2024 15:24:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 461FOxxK096785; Mon, 1 Jul 2024 15:24:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 461FOxsL096782; Mon, 1 Jul 2024 15:24:59 GMT (envelope-from git) Date: Mon, 1 Jul 2024 15:24:59 GMT Message-Id: <202407011524.461FOxsL096782@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: f8a46de2dd48 - main - bluetooth socket sysinit: correct memset initialization List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f8a46de2dd481da2bf69747551db30ea453490d5 Auto-Submitted: auto-generated The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=f8a46de2dd481da2bf69747551db30ea453490d5 commit f8a46de2dd481da2bf69747551db30ea453490d5 Author: Ryan Libby AuthorDate: 2024-07-01 15:22:31 +0000 Commit: Ryan Libby CommitDate: 2024-07-01 15:22:31 +0000 bluetooth socket sysinit: correct memset initialization gcc -Wmemset-elt-size diagnosed this. The code was only initializing the first 1/sizeof(long) bytes. On 64-bit systems, this would mean only events up to 0x20 were initialized. This effectively reverses the security policy for some events with higher ids, now permitting them on unprivileged sockets. Two that are defined are NG_HCI_EVENT_LE (0x3e) and NG_HCI_EVENT_BT_LOGO (0xfe). PR: 280039 Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D45707 --- sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c b/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c index b8caf0c515fd..b123322b33aa 100644 --- a/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c +++ b/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c @@ -808,8 +808,7 @@ ng_btsocket_hci_raw_init(void *arg __unused) /* Enable all events */ memset(&ng_btsocket_hci_raw_sec_filter->events, 0xff, - sizeof(ng_btsocket_hci_raw_sec_filter->events)/ - sizeof(ng_btsocket_hci_raw_sec_filter->events[0])); + sizeof(ng_btsocket_hci_raw_sec_filter->events)); /* Disable some critical events */ f = ng_btsocket_hci_raw_sec_filter->events;