From nobody Wed Jan 31 20:57:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQDrj36Xmz58H4m for ; Wed, 31 Jan 2024 20:57:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQDrh5W1Pz4nvt for ; Wed, 31 Jan 2024 20:57:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-55a179f5fa1so262237a12.0 for ; Wed, 31 Jan 2024 12:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1706734673; x=1707339473; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L1OQhj7tqr3CFxAB9Atr4++0glIc7WVkr6jaaf5uiuk=; b=PP1atdUgG3oDOKD9zwYVz1wk4tGhmrwc9vu4Wbt6Hu52R/JB60sAmZBIHhIrqg9PXG J6O9E6u35fHz83zNls4UIcRFU/Ntc+PsACyVXHPCYMfImQYR+Twaq2QDHQcvtYiswf0g M92jYS7ETqHnHDjZ4ti0c66SRY+s+cqnRO6FvJcKnD2XI2ur+4L8E/iSZ1L3tthQWVfL gk6ZSAq4I0rsBt3bq+kR3Q/2Lj1th2pI3edJvlubBb2c4UEAK3dQwP/TIavKnEVOxTHY rsnlh4b6ldtBSdph3cDdT5XSsniwEJOpA+pjYxpS24FRjBmZmAB6gbm1P69m7UtMcp6E Zgmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706734673; x=1707339473; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L1OQhj7tqr3CFxAB9Atr4++0glIc7WVkr6jaaf5uiuk=; b=ZXRQxpqh8X9d9iyj+fshbxktteG+PVHEY6NFfbt2o2DWP2RGcgYXTl/ZVrP6nuU1U3 0yVDiTDAtA9tvfqGUbGYg3xIr+EKakTN09/+etYrVtYq6M9L2lIpxSIH++C50BwCkjrk 6igpvjLcNCk8wor63jsr+Sz6/oW8/kSdPpSD3ALkCvuI+w29D0LWZhN6xFfrIAvr0Pp+ A5LbgrcAtB/O5hkC/kuEXkVF14AulS1kKL7DELD9g2KDdO6QkBzGu1+600epzUdYsRKU PqSrNy1Y5XcP9NkkJuZCx4wGQsSS7Fms+9OixCpiM2OlXT6BrSi1BiAB4vr0aZ/4Ax+Q 22og== X-Gm-Message-State: AOJu0YzBj4Z5+0EoLVNBpi0CetG7Fnoanai6YCQJcoTL+tONNaWyrwF5 6WJ98Ym3zfWb2HFecv97NiT5ibIqS+yMDnvr8IcHy08nytcpJOsvQGvzBOMQ8P5aSbi5XpVkLd1 9+G59nLC7xgxU05Nfy40sB4b9g+/lB4dapK1hlA== X-Google-Smtp-Source: AGHT+IFY1JZIS+pYN1i7wvyY3Z27pStNN1KtkEGJ8i0xSZSMbZe7noC8Ytni2n5puul1Hj4eyumAdSvcZ7fn13OYSDM= X-Received: by 2002:aa7:ccd1:0:b0:55f:19a4:e5f with SMTP id y17-20020aa7ccd1000000b0055f19a40e5fmr1937582edt.20.1706734672469; Wed, 31 Jan 2024 12:57:52 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202401312041.40VKfgE0080600@gitrepo.freebsd.org> In-Reply-To: <202401312041.40VKfgE0080600@gitrepo.freebsd.org> From: Warner Losh Date: Wed, 31 Jan 2024 13:57:41 -0700 Message-ID: Subject: Re: git: ed3563b0ac31 - main - csu: add crtbrand.o dependency on sys/param.h To: Ed Maste Cc: src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000e0f95d0610442124" X-Rspamd-Queue-Id: 4TQDrh5W1Pz4nvt X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --000000000000e0f95d0610442124 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 31, 2024, 1:41=E2=80=AFPM Ed Maste wrote: > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Ded3563b0ac31d854bf907d4d847ac01= 95ec9637b > > commit ed3563b0ac31d854bf907d4d847ac0195ec9637b > Author: Ed Maste > AuthorDate: 2024-01-12 15:01:49 +0000 > Commit: Ed Maste > CommitDate: 2024-01-31 20:40:27 +0000 > > csu: add crtbrand.o dependency on sys/param.h > > __FreeBSD_version is recorded in *crt1.o and crti.o via crtbrand.o. > Add > an explicit dependency to pick up __FreeBSD_version bumps. > > Additional changes are required to fully plumb *crt1.o dependencies > through the build. > So a kernel bump now rebuilds (or at least relinks) everything? Or soon will? Reported by: bapt > Reviewed by: bapt > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D43417 > --- > lib/csu/Makefile.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/csu/Makefile.inc b/lib/csu/Makefile.inc > index 55aaf589f48f..1509a1ece2c3 100644 > --- a/lib/csu/Makefile.inc > +++ b/lib/csu/Makefile.inc > @@ -55,6 +55,9 @@ Scrt1_c.o: ${CRT1SRC} > Scrt1.o: Scrt1_c.o ${CRT1OBJS} ${CRT1OBJ} > ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o} > > +# __FreeBSD_version is recorded in crt1.o et al via crtbrand. > +crtbrand.o: ${SRCTOP}/sys/sys/param.h > + > crtbegin.o: crtbegin.c > crtbeginS.o: crtbegin.c > crtbeginT.o: crtbegin.c > --000000000000e0f95d0610442124 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 31, 2024, 1:41=E2=80=AFPM Ed Maste <emaste@freebsd.org> wrote:
The branch main has been updated by emast= e:

URL: ht= tps://cgit.FreeBSD.org/src/commit/?id=3Ded3563b0ac31d854bf907d4d847ac0195ec= 9637b

commit ed3563b0ac31d854bf907d4d847ac0195ec9637b
Author:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-01-12 15:01:49 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-01-31 20:40:27 +0000

=C2=A0 =C2=A0 csu: add crtbrand.o dependency on sys/param.h

=C2=A0 =C2=A0 __FreeBSD_version is recorded in *crt1.o and crti.o via crtbr= and.o.=C2=A0 Add
=C2=A0 =C2=A0 an explicit dependency to pick up __FreeBSD_version bumps.
=C2=A0 =C2=A0 Additional changes are required to fully plumb *crt1.o depend= encies
=C2=A0 =C2=A0 through the build.

So a kernel bump now rebuilds (or at least = relinks) everything? Or soon will?=C2=A0

<= div dir=3D"auto">
=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 bapt
=C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 bapt
=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation
=C2=A0 =C2=A0 Differential Revision: https://reviews.fr= eebsd.org/D43417
---
=C2=A0lib/csu/Makefile.inc | 3 +++
=C2=A01 file changed, 3 insertions(+)

diff --git a/lib/csu/Makefile.inc b/lib/csu/Makefile.inc
index 55aaf589f48f..1509a1ece2c3 100644
--- a/lib/csu/Makefile.inc
+++ b/lib/csu/Makefile.inc
@@ -55,6 +55,9 @@ Scrt1_c.o: ${CRT1SRC}
=C2=A0Scrt1.o: Scrt1_c.o ${CRT1OBJS} ${CRT1OBJ}
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*= .o}

+# __FreeBSD_version is recorded in crt1.o et al via crtbrand.
+crtbrand.o: ${SRCTOP}/sys/sys/param.h
+
=C2=A0crtbegin.o: crtbegin.c
=C2=A0crtbeginS.o: crtbegin.c
=C2=A0crtbeginT.o: crtbegin.c
--000000000000e0f95d0610442124--