From nobody Tue Jan 30 17:55:03 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TPXr74Yf1z59Gmy; Tue, 30 Jan 2024 17:55:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPXr73xXbz4LxK; Tue, 30 Jan 2024 17:55:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706637303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xMdm3Zp+0nanhMhZavVOP01u2gNmioNEDvoB2czhBXs=; b=qTwUGqV/BkPeq3nvJy7WJNNjsDf/AFWS/fsMPcSIlyK38ATncjleAIRb1dMMkxN4idO95W kulpNZ8Y3rRshUPwdiZrZJbS7qwkPseS6jPhxEXtd/JJmx7cbLF0gPpdn82DliXjUavVn2 xSxxVvJ+R5HjlZVzRis8rjwX24LBMRY/dVOMM0wzfuJ2hCSe93dPT2A/7LGtDyQ9v7lZOc 8i01ts1jaKL0fsoqkIUW2+D10zAHLyfynm7auU/7n2/iJKj5/FBSAm6EUl0LGeCFwIAu8Q S+ec/A/m/mK1NyLm+UXWo3RZrdbvFJ7lnbwIHJIj3Mhw7pcXimYWYBrMm7oMrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706637303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xMdm3Zp+0nanhMhZavVOP01u2gNmioNEDvoB2czhBXs=; b=veb+H6di9ytv0sPesEqwbExzdfFvJsjl0ZBHKlNKZjLZjX4T6B2wgWclKcq83nsuREBjXw WyqPZ0hQ5LWSB8ABWqwUbbOUTkZmKy8Dve3en2AnSFbEJxy0TR8kejTAsnoIvoO4kv9DO+ g1tpB7Rdn2x5gazxlxejo+iM4wFDa0/3H88mnJ7fQ7q8z7NWNVjlwZI3kVNoD5p0jvhfNs T8sQSZJRXWKlCrZzLalfQQ4LiTY8GY871Ro6MRfxBu5tKgoTVJ0heh+ylt7LR6kuLSd86e nk5YcGqcGjbiPH7+CuQgzWkVjtmetkzESCkKPS0tZvXzRIMzB7y5X6TkEZG+Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706637303; a=rsa-sha256; cv=none; b=NOLLQHvFLG011/ndvsceSiYP+ee02LMUU9gVnKmuFtWB1ugokfTX1ZxI5kiaqm96wK60lc Z4FuUWmBmfjM1Vkl32w6x5mCc3pOmg9H1xHJalMxZbaqKlpvNhnkJB88MaSo4jmWlsPVDd B2bNDXhLrHoT6BQ4ICx22fMDFL0+ZNCLYSAWtYKHjLV514tVqW80EXWqM/TyzQx9VWIxqN eA5/e+PwfNY1TVRWmLMl29ihmHnA0T1THO/V5J38i0d0dOVCxAf+JvdtrRI9afVJXObrJv RCdbOLCYoK75GRg+cVIk7tyzkqbrmCwDYFrp2hd2NFnjbmOrFP8vWWJRDm5k1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TPXr732pyzl80; Tue, 30 Jan 2024 17:55:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40UHt3YG066439; Tue, 30 Jan 2024 17:55:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40UHt3Dq066436; Tue, 30 Jan 2024 17:55:03 GMT (envelope-from git) Date: Tue, 30 Jan 2024 17:55:03 GMT Message-Id: <202401301755.40UHt3Dq066436@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 277382e92885 - stable/14 - msun: remove fabs from Symbol.map, and adjust comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 277382e92885ebe2adf29c5052b7e2669c36b58e Auto-Submitted: auto-generated The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=277382e92885ebe2adf29c5052b7e2669c36b58e commit 277382e92885ebe2adf29c5052b7e2669c36b58e Author: Dimitry Andric AuthorDate: 2024-01-27 21:24:38 +0000 Commit: Dimitry Andric CommitDate: 2024-01-30 17:53:19 +0000 msun: remove fabs from Symbol.map, and adjust comment We have s_fabs.c, but fabs(3) is already provided by libc due to historical reasons, so it is not compiled into libm. When the linker does not use --undefined-version, this leads to a complaint about the symbol being nonexistent, so remove it from Symbol.map. While here, adjust the comment about some functions being supplied by libc: while it is true that all these are indeed in libc, libm still includes its own versions of frexp(3), isnan(3), isnanf(3), and isnanl(3). Reported by: Steve Kargl MFC after: 3 days (cherry picked from commit d04e03c19a8d7660ea36f62720eef9bc96b69889) --- lib/msun/Makefile | 3 ++- lib/msun/Symbol.map | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/Makefile b/lib/msun/Makefile index 9917be01d863..9b64674bbe7d 100644 --- a/lib/msun/Makefile +++ b/lib/msun/Makefile @@ -156,7 +156,8 @@ COMMON_SRCS+= catrig.c catrigf.c \ s_cproj.c s_cprojf.c s_creal.c s_crealf.c s_creall.c \ s_csinh.c s_csinhf.c s_ctanh.c s_ctanhf.c -# FreeBSD's C library supplies these functions: +# FreeBSD's C library supplies these functions (but note we still have s_frexp.c +# and s_isnan.c enabled above, so they are duplicated): #COMMON_SRCS+= s_fabs.c s_frexp.c s_isnan.c s_ldexp.c s_modf.c # Exclude the generic versions of what we provide in the MD area. diff --git a/lib/msun/Symbol.map b/lib/msun/Symbol.map index 6e74918ade6e..4d5a5e4d7e6e 100644 --- a/lib/msun/Symbol.map +++ b/lib/msun/Symbol.map @@ -88,7 +88,6 @@ FBSD_1.0 { exp2f; expm1; expm1f; - fabs; fabsf; fabsl; fdim;