From nobody Thu Jan 25 02:22:24 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TL4NZ3pgQz57SrP for ; Thu, 25 Jan 2024 02:22:38 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TL4NY6xhWz4Brt for ; Thu, 25 Jan 2024 02:22:37 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40e7065b692so66938335e9.3 for ; Wed, 24 Jan 2024 18:22:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706149356; x=1706754156; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=006BSzGf6TfM6ZXwSJ8MVdf7bc8AiX7YXo4HiYWOuvk=; b=ATEyy4DAyhILBTvAUEaAo6/aMuv8pPTSkEHcyxjL/VoRQ+tshKRPWEec0zmbXlL6y+ QA6TBIn/1Sr7LjRjNqzWSXhjqDqq2nCE2Qz6nmAcch+kV/twRnVS1Fuao4Pf26X6py1x HsPDlMS/Ty95fyyskooKQPV1xOeRRjFMwjt/9I6GSun3GpMz9p8cvvkdqN2jDi+V5G7X x7xRWAnN4tK2CZpQSN5zSKozeCpfA7YZ5Ln3yeqCPLH+eXxFo4S8nRlOkI9/1nOU6RXt tNd79URzYwX/z8S7p/xnqG8jfhk5R5OlSTMw2h3DUNB12D03ez7wVRg72zpxLOnBwpFv 9t/A== X-Gm-Message-State: AOJu0Yx/BX9gEtLxiENp2S+nhZh3HKZIDHAz/THX5rptydElysWPbQzG GAL15N/fUOJF2WE9frJNGtoCauv8VUd+OIAsUnfNvnVzR4B1BD+Boql3z7DZ9/c= X-Google-Smtp-Source: AGHT+IHPHRFh9Am+oJUAsmiprZzg3/VrCsg7zPatuS5FkqHaLcy+s+a/+r2p6uKW5EVQkYatugMaSQ== X-Received: by 2002:a05:600c:2248:b0:40e:615f:32cc with SMTP id a8-20020a05600c224800b0040e615f32ccmr72311wmm.185.1706149355647; Wed, 24 Jan 2024 18:22:35 -0800 (PST) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id v19-20020a05600c445300b0040d6d755c90sm825338wmn.42.2024.01.24.18.22.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2024 18:22:35 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: git: 820401bf1769 - main - nl_types.h: explicitly include cdefs.h From: Jessica Clarke In-Reply-To: Date: Thu, 25 Jan 2024 02:22:24 +0000 Cc: Ed Maste , src-committers , "" , "" Content-Transfer-Encoding: quoted-printable Message-Id: <549CBD3B-51AA-4BDE-A987-8E98BF1EE8C0@freebsd.org> References: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Rspamd-Queue-Id: 4TL4NY6xhWz4Brt X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 25 Jan 2024, at 01:24, Warner Losh wrote: >=20 > This was one of the things i wanted to comment on the that review. >=20 > This change should be done as a special Linux sys/param.h that = includes ctypes.h and then includes the next sys/param.h. >=20 > A large number of the changes from that review are similar and i = wanted yo think through the right solution. >=20 > This is fragile: I'm likely to remove it again because it violates = style(9) and has no docs around it. Agreed this is wrong. If it were in tools/build/cross-build I wouldn=E2=80= =99t care about that, but this is base, and the whole point of the cross-build infrastructure is to not have to change base, especially system headers, wherever possible. This is the perfect example of the kind of thing that the cross-build compat headers are meant to fix. So yeah, please revert this someone, else I will. Jess > Warner >=20 > On Wed, Jan 24, 2024, 3:05=E2=80=AFPM Ed Maste = wrote: > The branch main has been updated by emaste: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D820401bf176996e41091d2e4190aded1= 2a966b1d >=20 > commit 820401bf176996e41091d2e4190aded12a966b1d > Author: Val Packett > AuthorDate: 2024-01-16 18:42:26 +0000 > Commit: Ed Maste > CommitDate: 2024-01-24 21:59:18 +0000 >=20 > nl_types.h: explicitly include cdefs.h >=20 > This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping from > Linux/musl, they were missing. >=20 > Sponsored by: https://www.patreon.com/valpackett > Pull Request: https://github.com/freebsd/freebsd-src/pull/1066 > --- > include/nl_types.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/include/nl_types.h b/include/nl_types.h > index 120d1911631f..6ba15132126d 100644 > --- a/include/nl_types.h > +++ b/include/nl_types.h > @@ -34,6 +34,7 @@ > #ifndef _NL_TYPES_H_ > #define _NL_TYPES_H_ >=20 > +#include > #include >=20 > #ifdef _NLS_PRIVATE