From nobody Wed Jan 24 10:06:34 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TKfkv4jJ8z57xLJ; Wed, 24 Jan 2024 10:07:03 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [94.130.200.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail.bsd4all.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TKfkv2ZQzz46Zl; Wed, 24 Jan 2024 10:07:03 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Date: Wed, 24 Jan 2024 11:06:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1706090820; bh=wy+KS0UiUiz4P97a8O1Birnrz6rg3D1nG3qhiUPlqQU=; h=Date:Message-ID:From:To:Cc:Subject:MIME-Version:Content-Type; b=ctTNEWclz/gnrPF786MyO3jvx8/MCtSgKi9FARkeka7xu67t1a/bj1RcITimh+fjg MOph2BdMMmc8xCRbL176ZJe305WOyenEPoRbDYH3q3r5+XiPz1yv/Fh5GQXzQVLkp2 qHGbROTdL96Bn1z7usWZNJIrnM9pBDboZVvR3g04DuJHBuKxObWLh6ZuQylMhAWwVG JJPNwQXYqhrRe2tjHHF9AhZuhZk2WF5oWyBpEkaASDwql/25ZtZM+N9HrjoDkua40t 7DJ90gno0O7OH2YTvQB8ccawADuaIawGAWSJKHRmMz9bFH971QpspoK5MJ0IsRjU7t sXdPNxxkbQryA== Message-ID: <87sf2nm4et.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 54c62e3e5d8c - main - pf: work around icmp6 packet-too-big not being sent when binat-ing In-Reply-To: <1E1C3472-0AF3-457B-A27A-89679770EA62@FreeBSD.org> References: <202401221252.40MCqpf6047526@gitrepo.freebsd.org> <87v87jkii9.wl-herbert@gojira.at> <1E1C3472-0AF3-457B-A27A-89679770EA62@FreeBSD.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/29.2 Mule/6.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4TKfkv2ZQzz46Zl X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE] On Tue, 23 Jan 2024 19:42:10 +0100, Kristof Provost wrote: > > On 23 Jan 2024, at 19:32, Herbert J. Skuhra wrote: > > On Mon, 22 Jan 2024 13:52:51 +0100, Kristof Provost wrote: > >> > >> The branch main has been updated by kp: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=54c62e3e5d8cd90c5571a1d4c8c5f062d580480e > >> > >> commit 54c62e3e5d8cd90c5571a1d4c8c5f062d580480e > >> Author: Kristof Provost > >> AuthorDate: 2024-01-17 17:11:27 +0000 > >> Commit: Kristof Provost > >> CommitDate: 2024-01-22 11:52:14 +0000 > >> > >> pf: work around icmp6 packet-too-big not being sent when binat-ing > >> > >> If we're applying NPTv6 we pass a packet with a modified source and/or > >> destination address to the network stack. > >> > >> If that packet then turns out to be larger than the MTU of the sending > >> interface the stack will attempt to generate an icmp6 packet-too-big > >> error, but may fail to look up the appropriate source address for that > >> error message. Even if it does, pf would still have to undo the binat > >> operation inside the icmp6 packet so the sending host can make sense of > >> the error. > >> > >> We can avoid both problems entirely by having pf also perform the MTU > >> check (taking the potential refragmentation into account), and > >> generating the icmp6 error directly in pf. > >> > >> See also: https://redmine.pfsense.org/issues/14290 > >> Sponsored by: Rubicon Communications, LLC ("Netgate") > >> Differential Revision: https://reviews.freebsd.org/D43499 > >> --- > >> sys/net/pfvar.h | 1 + > >> sys/netpfil/pf/pf.c | 12 ++++++++++++ > >> sys/netpfil/pf/pf_norm.c | 15 +++++++++++++++ > >> 3 files changed, 28 insertions(+) > > > > Does this change cause problems for others too? > > > > - ssh over IPv6 permanently disconnecting > > (client_loop: send disconnect: Broken pipe) > > - ssh connections over IPv6 hanging > > - git pull not working > > Fssh_ssh_dispatch_run_fatal: Connection to 2604:1380:4091:a001::24ca:1 port 22: Permission denied > > fatal: Could not read from remote repository. > > > Can you include your pf.conf and a packet capture demonstrating one of these issues? So I assume this issue affects only me or this server (igb nic). Disabling tso6 seems to resolve the issue. I also have an issue with rack enabled. I only works with lro disabled or net.inet.tcp.rack.features.cmpack=0. I'll check pf.conf and packet capture later. Thanks. -- Herbert