From nobody Tue Jan 23 18:32:46 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TKG1X6CGkz57s9s; Tue, 23 Jan 2024 18:33:20 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [94.130.200.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail.bsd4all.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TKG1W294Dz4L3M; Tue, 23 Jan 2024 18:33:19 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gojira.at header.s=mail202005 header.b=uBGZKIji; dmarc=none; spf=pass (mx1.freebsd.org: domain of herbert@gojira.at designates 94.130.200.20 as permitted sender) smtp.mailfrom=herbert@gojira.at Date: Tue, 23 Jan 2024 19:32:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1706034791; bh=G+SW1+zH+eCVecoAcAA37puPoTSwn3ytg/0PFtvtzU8=; h=Date:Message-ID:From:To:Cc:Subject:MIME-Version:Content-Type; b=uBGZKIji2p24vGAMmijCYUGQonHFpeNtyig6uzd+qja2+R9BnQKbmxjFCyY3YqP1r 5HC5gl2Uo4udLcNbm5Djq1a6AFZqlw2xfutmBBIQ7p1jrpwNsF1hRiMUPnjSizg+3f YH28htHHqcZH0mn/VWmNRi2+4vrLbaqxZKcqJosmDa7jETO4AVg8+fHYVuiaNFprD0 Oycm4phL/sGaa+k8A29jZRkc7CSOc2diL8HcHhM+jTdFeiuwTQePSCBiVAt49fPx+T 9SZyFmnjo2zCQOEhAGYeOpIQjbqgUt+yzpWgSZ/sn58MIkudtjYtMd+TYDJiWtmKkf 2GU7y/Ben4kmg== Message-ID: <87v87jkii9.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 54c62e3e5d8c - main - pf: work around icmp6 packet-too-big not being sent when binat-ing In-Reply-To: <202401221252.40MCqpf6047526@gitrepo.freebsd.org> References: <202401221252.40MCqpf6047526@gitrepo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/29.2 Mule/6.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_ALLOW(-0.20)[+ip4:94.130.200.20]; R_DKIM_ALLOW(-0.20)[gojira.at:s=mail202005]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; DMARC_NA(0.00)[gojira.at]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; DKIM_TRACE(0.00)[gojira.at:+] X-Rspamd-Queue-Id: 4TKG1W294Dz4L3M On Mon, 22 Jan 2024 13:52:51 +0100, Kristof Provost wrote: > > The branch main has been updated by kp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=54c62e3e5d8cd90c5571a1d4c8c5f062d580480e > > commit 54c62e3e5d8cd90c5571a1d4c8c5f062d580480e > Author: Kristof Provost > AuthorDate: 2024-01-17 17:11:27 +0000 > Commit: Kristof Provost > CommitDate: 2024-01-22 11:52:14 +0000 > > pf: work around icmp6 packet-too-big not being sent when binat-ing > > If we're applying NPTv6 we pass a packet with a modified source and/or > destination address to the network stack. > > If that packet then turns out to be larger than the MTU of the sending > interface the stack will attempt to generate an icmp6 packet-too-big > error, but may fail to look up the appropriate source address for that > error message. Even if it does, pf would still have to undo the binat > operation inside the icmp6 packet so the sending host can make sense of > the error. > > We can avoid both problems entirely by having pf also perform the MTU > check (taking the potential refragmentation into account), and > generating the icmp6 error directly in pf. > > See also: https://redmine.pfsense.org/issues/14290 > Sponsored by: Rubicon Communications, LLC ("Netgate") > Differential Revision: https://reviews.freebsd.org/D43499 > --- > sys/net/pfvar.h | 1 + > sys/netpfil/pf/pf.c | 12 ++++++++++++ > sys/netpfil/pf/pf_norm.c | 15 +++++++++++++++ > 3 files changed, 28 insertions(+) Does this change cause problems for others too? - ssh over IPv6 permanently disconnecting (client_loop: send disconnect: Broken pipe) - ssh connections over IPv6 hanging - git pull not working Fssh_ssh_dispatch_run_fatal: Connection to 2604:1380:4091:a001::24ca:1 port 22: Permission denied fatal: Could not read from remote repository. Thanks. -- Herbert