From nobody Mon Jan 22 17:30:05 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJcg21Lwrz57r6c; Mon, 22 Jan 2024 17:30:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJcg16Ndcz4fZY; Mon, 22 Jan 2024 17:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705944605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cciZMWXAiZ3KauEX/4O33zW0bkcqY/ORFZJ85NcDb6M=; b=NT36BCGCL2illYP39PtMh/h/mflY8q9sa90RlNo1KM+VvmX12FGO1+0wRbq0YrDo4MyngB o/ZE2Zv1rgU1CwYUuLt0wdQulb8iMQ7JR4ZFCIA5F21hWsRYzExOgdslRedRs6tuITo1f1 Ke/WOQ8cc5lrCyHCkszHkh4iiysQYNN83VPgo5qFYKisRqKf9DRwZgQieImixzReUhFw3V xzmKkA4/IUdU0DPUk1A1MIps1HYEnLFUEWkuG2w/z/bwvZoOyWGxAI4q+JGaWD9OpFuViz 1EDYd4sK27T+MQCSDA70rxKe1hvB/xfk9cW4hvXI2tW+SIXTr7wdV9RH4qsAkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705944605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cciZMWXAiZ3KauEX/4O33zW0bkcqY/ORFZJ85NcDb6M=; b=ejPB00HPPUaoRPorqWggSs2NvMn3Rpr1TXMCqzcIQS13iLfYl2QW0GGItIQuutEWj91u51 8rXzRLpAL9p5YQz03K3Qfm5RAc7Vy23ADzXcJml84UnTtFmY1PbybzcATibsebZsm/oooe mhhX53amQUE+CI3XJom06PbK/NmJacnHoyybZL84yM/5KHmScpSBnZi7lcqRuTGDH5sH9I LTw8jzZer4UNPc/oCSGPQe/O1TUAHPWuWUkz/hH6As14ckkoOa0cmTGZAo/nVU9URzx1t4 8L35VX8Lh/piILfXoifa9S2rDRMkG2/1X1Y2u8VODG4Mm/iKVprKayEltj+yTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705944605; a=rsa-sha256; cv=none; b=YhYZjRAZ/it9p4p9cKgupL4RaFdoNCL8K/PKn8MdmphOWmoWBKqi9knD7RWiRgrOpGLkvf euPrNFg/KPb6BKPv4wDOqk+gI8B0a4q4hZxmazL/kyIOi1Y0Ba7swGsr6Ax49xdSiKLI3P /QX5M9GincLJ9G50JzjSabqHSCePvmnsWE/TFY3/rHm5Hbd1xwu6jpRTqGgVHbYJZMgL35 Yx9tNtly93UyXuRscxuGTiIa4wYoHF5J8F/4Oxp6H6HL9NVRyurXobMXjh/0XQzFXMhfad S9RALbNEEq/qCJQ4EDmvE8R1shiT085TWGMUj2lCf8nt9vIcnMoa5zP/C7GI6w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TJcg15VLcz19PT; Mon, 22 Jan 2024 17:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40MHU5iY009322; Mon, 22 Jan 2024 17:30:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40MHU5fv009318; Mon, 22 Jan 2024 17:30:05 GMT (envelope-from git) Date: Mon, 22 Jan 2024 17:30:05 GMT Message-Id: <202401221730.40MHU5fv009318@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: a95fbd3da860 - stable/14 - bhyveload: add CAP_SEEK to our dirfd rights List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a95fbd3da860dc9db776c5cb0acd064aff5c1610 Auto-Submitted: auto-generated The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=a95fbd3da860dc9db776c5cb0acd064aff5c1610 commit a95fbd3da860dc9db776c5cb0acd064aff5c1610 Author: Kyle Evans AuthorDate: 2024-01-09 03:08:16 +0000 Commit: Kyle Evans CommitDate: 2024-01-22 17:19:14 +0000 bhyveload: add CAP_SEEK to our dirfd rights In the case of hostbase_fd, this is infact a bug fix; we have a seek callback that the host: filesystem may use in loader, and we really don't have a good excuse to break it. bootfd-derived fds will only be used with fdlopen(3) and rtld doesn't seem to need pread / lseek at all for it today, but there's no reason to break if it finds a good reason to later. Suggested by: markj (cherry picked from commit cef5e56f3fea33d6c421276af49f2967453ad4ff) --- usr.sbin/bhyveload/bhyveload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/bhyveload/bhyveload.c b/usr.sbin/bhyveload/bhyveload.c index 4d89393424f4..5250e2120938 100644 --- a/usr.sbin/bhyveload/bhyveload.c +++ b/usr.sbin/bhyveload/bhyveload.c @@ -755,7 +755,7 @@ hostbase_open(const char *base) err(EX_OSERR, "open"); if (caph_rights_limit(hostbase_fd, cap_rights_init(&rights, CAP_FSTATAT, - CAP_LOOKUP, CAP_READ)) < 0) + CAP_LOOKUP, CAP_PREAD)) < 0) err(EX_OSERR, "caph_rights_limit"); } @@ -887,7 +887,7 @@ main(int argc, char** argv) * to the more usual lookup rights. */ if (caph_rights_limit(bootfd, cap_rights_init(&rights, - CAP_FSTATAT, CAP_LOOKUP, CAP_MMAP_RX, CAP_READ)) < 0) + CAP_FSTATAT, CAP_LOOKUP, CAP_MMAP_RX, CAP_PREAD)) < 0) err(1, "caph_rights_limit"); }