From nobody Thu Jan 18 22:26:01 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TGHQK5pgZz578YH; Thu, 18 Jan 2024 22:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TGHQK4lMrz40xH; Thu, 18 Jan 2024 22:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705616761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZWCk+oFLa8HYJEPl2y+luUF5K8ZSFTEq2v7vQ9pxeDI=; b=gXw8s/seh16u+FGXl85jcN6IcHQmHuY66FpVxIPBwyeCZjnPXGUHUvqMtwtNVwlVztB4o4 5oPV2mjg0dyDZUmp4+LbvAwxRCqbTkts1lEltvupUrk3LoFLoLXgyhLOR47DIhdJihu8KT EcPIKR5jr5LVBdZhb6ZcQReFp7sei2k8B38nqlDE3bImlVO1SfTp9jxshZXrhZpjzw1jBP 7+ZX2A1K5E/jxcCtGGpoWCSxZZPyNPQBnukg6JixHoxyMukPnTFP8mK7ClTA6oGWyUQoa7 KVCY/qaXi6gwHfwOgHYkjwm4C/XxD8d+sB2fIn9oOBhvHgZv64wzsNKCdAMSsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705616761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZWCk+oFLa8HYJEPl2y+luUF5K8ZSFTEq2v7vQ9pxeDI=; b=XorzdLN6f/aWSXf4blN3f8o49MMGmuAQysykxGCPXwZW7XvSbNMMTo0P7ms2G77nepZy3Q O1VjSsbQnwfwv+DYU6E4HFqk/Hf7M31gS4dE8Q5su0uM8o/hZHskGVF2nABY362wy4wZzO TCrMCHS9AqXap7nri0PSUk+QDUhJZM9mOAE9HzuFh1e6L94lRb8SoyZruJKNVYDJEvxhBE fGLKVfyUeONeCB4SUPSOno5104c92z3m+ANvE4LzMNrIw6x19OFeRHLTl/yy7co2VeQW0k JnOeD/sFkMIqLAIOWaxwVLbCKnkSnGDIA75trEyGVyFQ6V/zrBJTS3e2ho2knw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705616761; a=rsa-sha256; cv=none; b=HH9oHhagkIaOkvP1FqNw+QQHdb/8s6kgUQFes/vU/pTAYRRGjq7VQeyBAmZxCsyQP2u+j2 HiUWZeyRxmiwZFcuocytIF3vI91p+ifdNUZFsSOErUMnrCms993aMteuK2CaEFwpWCvMqg OzWuBsE1QIcX+1pCs3jO9WadmywrqEkCyFT/jjGyikXLcgCA+xXyMwjIQWrSQFx+jyGkHB ntNMkLLTM+wkC4AXraUhkQ1kiJnWCNP/zG0h/N/ZFolMZU9xkZvOd8HP2vPPXGPqPlgsh/ F65X9O6m0AipJnhTVCwlLy/AtqJUYWKY1SPkwz7pFjDVjTyYgefv1gGlS7SH2g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TGHQK3sDyzQ4X; Thu, 18 Jan 2024 22:26:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40IMQ1Wc089529; Thu, 18 Jan 2024 22:26:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40IMQ16L089526; Thu, 18 Jan 2024 22:26:01 GMT (envelope-from git) Date: Thu, 18 Jan 2024 22:26:01 GMT Message-Id: <202401182226.40IMQ16L089526@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 8ac6f5e39417 - stable/14 - kldxref: Appease a Coverity warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8ac6f5e3941796195ae1e78602523499a20b68b7 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=8ac6f5e3941796195ae1e78602523499a20b68b7 commit 8ac6f5e3941796195ae1e78602523499a20b68b7 Author: John Baldwin AuthorDate: 2023-12-22 15:49:40 +0000 Commit: John Baldwin CommitDate: 2024-01-18 21:31:43 +0000 kldxref: Appease a Coverity warning While parsing .dynamic, nsym is set when parsing the symbol table from .dynsym. That parsing also sets ef->ef_symtab to a non-NULL value. The value of nsym isn't validated until after a check for ef->ef_symtab being NULL, so nsym always has a valid value when it is read. However, that chain of events is a bit much for static analysis to follow, so initialize nsym to 0 before parsing sections to quiet the warning. Reported by: Coverity Scan CID: 1532339 Sponsored by: DARPA (cherry picked from commit d281fece432f97b4424b852f23dfe1f974b9e30d) --- usr.sbin/kldxref/ef.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/kldxref/ef.c b/usr.sbin/kldxref/ef.c index 46d3dc1f4578..fd0782ff1dd0 100644 --- a/usr.sbin/kldxref/ef.c +++ b/usr.sbin/kldxref/ef.c @@ -361,6 +361,7 @@ ef_parse_dynamic(elf_file_t ef, const GElf_Phdr *phdyn) goto out; } + nsym = 0; for (i = 0; i < nshdr; i++) { switch (shdr[i].sh_type) { case SHT_HASH: