From nobody Tue Jan 16 00:58:01 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TDVx54Qz9z57xHP; Tue, 16 Jan 2024 00:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TDVx534xnz4QnP; Tue, 16 Jan 2024 00:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705366681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vg756sqc9j9X5yZNvBql+pHF1U5/WxqGV2z3CNmmNd8=; b=upEwDltC76vzNncDxfXRK5E3SFzmN8Kgv7UbdqjfGWNRWUQ9xDnibs5zOaVtjd1Hrufsc9 LZDTuzJNrrVJBRMomXvpZOI7kiRqp4o2/xnIQnpGPS77PhaY86YQ+cRdX8709MeYFBi97J Wh8Hu12dWB3rqq73vo23Vh7NumnMadu+Z4Ym/j3fjYKiitQ+3W9bIypdM1YaoJK9ztfDAu 1hdYF2ONCqOdrnf12VkIZpAZpgTKcqDsCTrjhMtG9ugEvwVUNrqk/WwMaY9HVjlBXz+nIF a3iNH0RO4BVMMwwkWjpT4gHMWkJlp8F8BieHLRo4TS6FOA8eVhkkStoVIE2nEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705366681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vg756sqc9j9X5yZNvBql+pHF1U5/WxqGV2z3CNmmNd8=; b=MDLcMtyAu0elDIhfUH8AAS1xlyv5MGrZTPWph9xxt3ZdVALeuLdZcFAhzpZ4/zDN0lNKWz VIx97E2aC7NkpaNiYQKXA48PRG4QRA/G5uBWpv/fibFkn4ZZzJZiR+Ts9boUz+ZQ6lR1Iv tu+UiExd6W4HBLIORix+Zi5lCikAkQID6FRvWhm/5tsiRypJoIMQznz9+PwbMdvelQGl8p XgeVynoRFinUfnlDrjUvLQe24010aTAde0wgEcBY0tl1YuaQdThL57e4c3UBelYjRAwTqP Y5ziHQf1v4B9auPUP8XJG2hbCPYJ/l5cqXVX77pm7oeM/O32eLcPU7ZZw3US5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705366681; a=rsa-sha256; cv=none; b=j6zxKHXX4AkLv8oKiMZPFmZWXZwD4O8bfBm+jOE6KOyA+i2ctZl7KdbVDj293scZWM6y8+ PWOfGo6vcK+eAn5VXLxU4yZuuEIhNCM7TUkJLbpfqJKINhXsLvig/Gd/ymqinZzsUUnbp1 ZkA/S7KlORIcFsf+45k+r8W4wzhK1zrVyFSO+m4tqYbNIP554WbBjOhSf8vGGV4HXzUoMz S3UfGwEqvZT7cpxvApsXogpBC1V56nN3agwmtGKIgQMC1+qJmq3VrIKNgoujrBJWcOK+al N1+5sbGFqJbqpAuwptIIO2kcl8bw9yKzU/uMztJuSGglcVP1+b/nPnx1nbeMbA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TDVx529VwzJtQ; Tue, 16 Jan 2024 00:58:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40G0w1Mj070538; Tue, 16 Jan 2024 00:58:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40G0w1Jn070535; Tue, 16 Jan 2024 00:58:01 GMT (envelope-from git) Date: Tue, 16 Jan 2024 00:58:01 GMT Message-Id: <202401160058.40G0w1Jn070535@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 57623b3b745a - main - checkstyle9.pl: Soften the single line braces requirement List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57623b3b745a2a89ea9b998cadf8cc8c02228fea Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=57623b3b745a2a89ea9b998cadf8cc8c02228fea commit 57623b3b745a2a89ea9b998cadf8cc8c02228fea Author: Warner Losh AuthorDate: 2024-01-15 21:48:01 +0000 Commit: Warner Losh CommitDate: 2024-01-16 00:57:28 +0000 checkstyle9.pl: Soften the single line braces requirement We inherited the error for single line statements needing braces from the original script. Style(9) allow that, and could be read to encourage that, but does not require that. Sponsored by: Netflix --- tools/build/checkstyle9.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index 3b28fef93669..8b30baa10fc9 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -2546,7 +2546,7 @@ sub process { $herectx .= raw_line($linenr, $n) . "\n";; } - ERROR("braces {} are necessary even for single statement blocks\n" . $herectx); + WARN("braces {} are encouraged even for single statement blocks\n" . $herectx); } }