From nobody Mon Jan 15 16:30:13 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TDHgC4RNFz57Hht; Mon, 15 Jan 2024 16:30:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TDHgC3vXQz570D; Mon, 15 Jan 2024 16:30:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705336215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1iZkRmFTzvnJN42d9LTTIznN+rxqbbGoy5R6Va0v0VM=; b=jwzNK3lim+D8mlJhYCugxG7weniaa31xDh0+H4w0PfXCHtqkF4aap6uO4ypXOIBdWJ4cAh cz8YGFwXU5fpMiQf78PdJS/v2Mid+wYe6dA9kwfgQGmtD9LDBBXSlap1AKqyZWEW3IPxKW sa410/STiZ0Cm2feSbQ5mzGyByRceDJdb/+D45Bnyd3VaLKznula2xS+KyjgX45zWDU1xc MhxilGWjR3jS6W8MKw8qhsOtjER9NqSa74/7RIqQfrDg0WK/4InR4TZh30wC0KXRnzemCS hktYqvxTzkGfl0yos9uDOMrO4quMszej2MKHR78XozMkQRuFXKmHRucXupQMww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705336215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1iZkRmFTzvnJN42d9LTTIznN+rxqbbGoy5R6Va0v0VM=; b=IR1LfxSad4DMvzPbsMB0yp8LQ8MV+kE8tU9J5HTQtk/+9mkIVmgp9tqvbI+ePBzGiie54i 752ouZGL+WZd8+rwXih9kfs0ztC5O74Ptkd7fqWfpAp72tCRIRRXYJZ5XtJ5Ay5xxB1MY2 ezyL/jqzEx8MBFvvb/qTSw+SHZX1w9H7MXECZvbrQzIu3ndHSaUg4T3MTpfmM3UYCeILuX OELR6MTN68KF2joWeNzY1drk+Y9Hwf5aQ6UUOGq/KpB0UXjCSu2K+6oWHjyhGr/wCpYoqX N+BCkLqcSKKnvCzL8ulZBcddFmUM8Ej4laE0p153SpxXzUEEYmp28mgMePC2lg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705336215; a=rsa-sha256; cv=none; b=d6iPeA/vp2SbG4sJ6Oiq52j8dgryKreajMCk9z+tqBVLbU5j16Lb40wbuBNBgoVBvfc4Y0 Ho8URZQ/uLx/N2pi6vFWWsUbupLn4QJQksWclE7YHL2dC9D38fnL/uZtOLncOa/mg2r2Rv fk9IubVTlh3dwe9n1ami/8WAzHkMSmE+IWdzziZROYS10NmTysFbcO5cMwqWKu6nnTKic2 eopgxUQylmDJfTf50Olt0jJGYYzELFZYmPg9k7nwOV0GyKH1sGUt/oLnc3l1IcJIGEp1CH UAZPRhq14vdibO5+zpWHfMqKGz78RJlQepYK8qZ7NsFHQYuuQEXAtHtvjbJ3IQ== Received: from [IPV6:2601:644:9381:f410:29e7:37c1:a879:8b7d] (unknown [IPv6:2601:644:9381:f410:29e7:37c1:a879:8b7d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TDHgC018zzJmG; Mon, 15 Jan 2024 16:30:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 15 Jan 2024 08:30:13 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log Content-Language: en-US To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/24 6:24 PM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=df834e06bbc78c03cb6b35f074ae43673c9ce463 > > commit df834e06bbc78c03cb6b35f074ae43673c9ce463 > Author: Warner Losh > AuthorDate: 2024-01-15 02:22:04 +0000 > Commit: Warner Losh > CommitDate: 2024-01-15 02:23:45 +0000 > > git-arc: Just strip escape sequences form arc log > > Just strip escape sequences and Warning: lines from 'arc list' output. I > upgraded and they changed and git arc list broke. This restores its > functionality. > > Note: jhb didn't like this, so if others object, I'll fix... > > Sponsored by: Netflix > Reviewed by: markj > Differential Revision: https://reviews.freebsd.org/D36553 Namely, it breaks the color output for reviews in different states, so Needs Review shows up as purple, Approved as green, etc. If you find the color output useful you'll have to revert this locally. Also, your last update in the review said that git arc was no longer broken for you back in May implying this commit wasn't needed for git arc to work for you? -- John Baldwin