From nobody Mon Jan 15 02:28:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TCx0N2v1Jz57M1l for ; Mon, 15 Jan 2024 02:28:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TCx0N0qtDz40GY for ; Mon, 15 Jan 2024 02:28:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a28b1095064so917541866b.2 for ; Sun, 14 Jan 2024 18:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1705285730; x=1705890530; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bmUaf03EbXUaPkwZs1c7KZXMR+LvXzch5KTB0s7L5Ms=; b=z2M92Zcki2AaZdmU3SLBcOO/1TRDHNKBVewPCSwkWqc7qrqNiUQ1BZfiq7uLOAntac Ik9jLtnextEAbfUl11LV/kiFCCorq/3nva0pPk87YDkGECFVZYRkMbKjaz+9qyWz7eOB OjnKpR8zEQsFY/EXsSZZ3SB6c255sTpRxaSlcsYa870y7pi+XGbKXv5SPSuS1L2eEKMX eo4khFb/mmSQsy6SiorX7hUMEi8lFedRPvR6l9/WgPIl91Fg9wbSTbIkfSOJrNF0bhiw 0oxcAJUTXzDAERA+J+nxYs1mY03BIGgWFyBRMago+4ydEIq9NiBopsGM5PX+SmKbilx9 ap0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705285730; x=1705890530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bmUaf03EbXUaPkwZs1c7KZXMR+LvXzch5KTB0s7L5Ms=; b=TstxsA7GDQjwvkVWJdIVxhq/TDuMpdK5lqHrmYXpOO7eQroh1F6kSGgq+QlYHZIiqN 6wbmofhKbP5MQrMZU841wLB+O/cJXFaHdWoPYczwZVj90C2KHftwzIzAOmgZ8aZoyfU9 C3EBmIwVxNUwTdnYM0FCdio8dvvKlRQUw0h3R0I/UFZPpYeu+XRY7+HNUVfitaE1X+ts 9ZvRrLzLBUE4VoQcDrSpY1mp/QbGxj0VoiTCgSKHhL8Jzoi7hjz8PcPYlAo1XSDMifUA +NwnVYBDh4H93B0pAjY/4wkT+zCrmlSPQ6DyA1fzECzhnQuPABHzPMFQzd2UaHX/E2Yz NQDw== X-Gm-Message-State: AOJu0Yylc6mBro1HXNlOfJnVrny3bWxsKVNmEn8drSe5E/+98/Wz8WDc U7UgY/wqjHHnfg+LG0uQYp4N6HNUZmmAIMVaXZh669SMkVJF5l3oLW8Cx9+nXl3DoQ== X-Google-Smtp-Source: AGHT+IHXjbr/Qx/M+9UFHIXLElqu/ZgZepweOwFzSsFx3N/L3qHWryNWrU7l4M8MLRC/1x6O3ch+qbz1uDCtBlEiWVc= X-Received: by 2002:a17:907:d046:b0:a2d:60a:2ae9 with SMTP id vb6-20020a170907d04600b00a2d060a2ae9mr852810ejc.52.1705285730373; Sun, 14 Jan 2024 18:28:50 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202401150224.40F2OR6f093484@gitrepo.freebsd.org> In-Reply-To: <202401150224.40F2OR6f093484@gitrepo.freebsd.org> From: Warner Losh Date: Sun, 14 Jan 2024 19:28:39 -0700 Message-ID: Subject: Re: git: 3d939d967ad4 - main - build: Use ls -i | cut rather than stat -f %i to extract inode To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000033219b060ef2c66e" X-Rspamd-Queue-Id: 4TCx0N0qtDz40GY X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --00000000000033219b060ef2c66e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 14, 2024 at 7:24=E2=80=AFPM Warner Losh wrote= : > The branch main has been updated by imp: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D3d939d967ad49f747b8b9db4fdec808= 6a7067582 > > commit 3d939d967ad49f747b8b9db4fdec8086a7067582 > Author: Warner Losh > AuthorDate: 2023-05-02 20:51:09 +0000 > Commit: Warner Losh > CommitDate: 2024-01-15 02:23:45 +0000 > > build: Use ls -i | cut rather than stat -f %i to extract inode > > ls -i dates back to 5th edition Unix and is more portable than the st= at > command, though %% is a newer shellism, it works on any shell that > FreeBSD builds with. > > Sponsored by: Netflix > Reviewed by: arichardson Differential Revision: https://reviews.freebsd.org/D43443 Warner --- > Makefile.inc1 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index 34b49ee319ec..8a0073547ed0 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -1059,8 +1059,8 @@ _cleanworldtmp: .PHONY > .if ${USING_SYSTEM_COMPILER} =3D=3D "yes" > .for cc in cc c++ > if [ -x ${WORLDTMP}/usr/bin/${cc} ]; then \ > - inum=3D$$(stat -f %i ${WORLDTMP}/usr/bin/${cc}); \ > - find ${WORLDTMP}/usr/bin -inum $${inum} -delete; \ > + inum=3D$$(ls -i ${WORLDTMP}/usr/bin/${cc}); \ > + find ${WORLDTMP}/usr/bin -inum $${inum%% *} -delete; \ > fi > .endfor > .endif # ${USING_SYSTEM_COMPILER} =3D=3D "yes" > --00000000000033219b060ef2c66e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 14, 2024 at 7:24=E2=80=AF= PM Warner Losh <imp@freebsd.org&g= t; wrote:
The br= anch main has been updated by imp:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D3d939d967ad49f747b8b9db4fdec8086a7067582
commit 3d939d967ad49f747b8b9db4fdec8086a7067582
Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
AuthorDate: 2023-05-02 20:51:09 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-01-15 02:23:45 +0000

=C2=A0 =C2=A0 build: Use ls -i | cut rather than stat -f %i to extract inod= e

=C2=A0 =C2=A0 ls -i dates back to 5th edition Unix and is more portable tha= n the stat
=C2=A0 =C2=A0 command, though %% is a newer shellism, it works on any shell= that
=C2=A0 =C2=A0 FreeBSD builds with.

=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Netflix=

Reviewed by: arichardson
Dif= ferential Revision:=C2=A0htt= ps://reviews.freebsd.org/D43443

Warner

---
=C2=A0Makefile.inc1 | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.inc1 b/Makefile.inc1
index 34b49ee319ec..8a0073547ed0 100644
--- a/Makefile.inc1
+++ b/Makefile.inc1
@@ -1059,8 +1059,8 @@ _cleanworldtmp: .PHONY
=C2=A0.if ${USING_SYSTEM_COMPILER} =3D=3D "yes"
=C2=A0.for cc in cc c++
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if [ -x ${WORLDTMP}/usr/bin/${cc} ]; then \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0inum=3D$$(stat -f %= i ${WORLDTMP}/usr/bin/${cc}); \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0find ${WORLDTMP}/us= r/bin -inum $${inum} -delete; \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0inum=3D$$(ls -i ${W= ORLDTMP}/usr/bin/${cc}); \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0find ${WORLDTMP}/us= r/bin -inum $${inum%% *} -delete; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 fi
=C2=A0.endfor
=C2=A0.endif # ${USING_SYSTEM_COMPILER} =3D=3D "yes"
--00000000000033219b060ef2c66e--