From nobody Sun Jan 07 17:03:19 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Nn35qCfz55RDX; Sun, 7 Jan 2024 17:03:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Nn351ylz4Gt3; Sun, 7 Jan 2024 17:03:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704646999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AVmIjd2cqjQJkANiQa0grbudOgHfUYuNcbGcJb6aVWE=; b=CgpbCE8tEeA8Eng3BVKbdVaMi6Vw4wBzNOx9ENwn49c9T1M8keHIbGHsBVfMiJR9alR1lG QMVquTW20Wu1+DWkXAXlXhUFGTqmV90MfegPUTw1KUmkXiy77LR7G8m9crpnXLrFHbsGM7 y5wV00MjNkViP4EtAdyrv13hoya5HYEmfZ0POVtcmnmxGkNha4ek2jp8Mzt8pN9iwA7kyn 2pZDs/Ga00meo78Zuv0tnNUW7mSb/4QgjsSlhyqHrPVqNgUnLT+YfiRop0q1lVjiX/rN2W bO7vQlXmqrsL3jWJF+Wmr5IDxgXlD5LGRsJmtaYakkd8Go+m3H3717VY6AealA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704646999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AVmIjd2cqjQJkANiQa0grbudOgHfUYuNcbGcJb6aVWE=; b=pSIFIxwOAt3e9yzRlG7Z05eTgMjCOCi4gDaF36oJxMmnMPET81vEaDTV1EMp0kkroQxgQo Rv+F4jtOzE7d0u9rQXGybMggfmqqsWE4g6b1RHmOmi+sTLaFj3MM92MLILRU5DnplbDKN8 RQyQ0S6GTrOTUJ7mf7rOJfIhcLldv3sp5JKrBAjJ0s3Gi3kg2IArg6tHCTPCExSSZMJG+h /+nVp+4YE6nSG7ncdWy0U+ZmeZt96RtpoY61uvmbJaeXvct6NvvsWyhoyh4ERdGS0oKeAG OaivG54jtU+RGqvjCoVzfbbI5plnLLRY1XPUhlzNOizNug+vJmX+1xVCePu9mg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704646999; a=rsa-sha256; cv=none; b=f7neFeg+83LNVK+PEnKp/cyQDCYMT78lGBmoScWy/0FhqlBkNQCKWMxaOBxotxNVgtn1RI kZBzdTlAVt5j8OJeR8n3ZwSrKbVfROrOeeNy1NQfAh2YD1REUPK9id4d5zrrGUJT/t5gs/ tIJI0snUv6Gg9woMYrsMFXo1lsmo7XaHM8dcW34nzQPrv3Au9NCF0KkiKq9TKzvd1LPnyK ImkctxkPjzfviVB4TBy1YRVeaXzY3Ww9mD0u+va/GK7cb4Mdk11cI2vCFvLivQiGU68D7G k1IBmjACO746e0BoQ1jzUKxlJ6XvVUtP9bfkpWS3RFws3CuhZAT2HgpZQKT1tQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T7Nn346HQzYMt; Sun, 7 Jan 2024 17:03:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 407H3Jjn045905; Sun, 7 Jan 2024 17:03:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 407H3JkA045902; Sun, 7 Jan 2024 17:03:19 GMT (envelope-from git) Date: Sun, 7 Jan 2024 17:03:19 GMT Message-Id: <202401071703.407H3JkA045902@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: c8bfd3fda78c - stable/13 - gtaskqueue: Fix a typo List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: c8bfd3fda78cd89cfc9d419a26946603c2124b10 Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c8bfd3fda78cd89cfc9d419a26946603c2124b10 commit c8bfd3fda78cd89cfc9d419a26946603c2124b10 Author: Mark Johnston AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston CommitDate: 2024-01-07 16:56:35 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week (cherry picked from commit e1f336704d308679d4178fd5063dba854b22a07b) --- sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_gtaskqueue.c b/sys/kern/subr_gtaskqueue.c index 3558b534967d..590dd53d0ea3 100644 --- a/sys/kern/subr_gtaskqueue.c +++ b/sys/kern/subr_gtaskqueue.c @@ -614,7 +614,7 @@ taskqgroup_cpu_create(struct taskqgroup *qgroup, int idx, int cpu) qcpu = &qgroup->tqg_queue[idx]; LIST_INIT(&qcpu->tgc_tasks); qcpu->tgc_taskq = gtaskqueue_create_fast(NULL, M_WAITOK, - taskqueue_thread_enqueue, &qcpu->tgc_taskq); + gtaskqueue_thread_enqueue, &qcpu->tgc_taskq); gtaskqueue_start_threads(&qcpu->tgc_taskq, 1, PI_SOFT, "%s_%d", qgroup->tqg_name, idx); qcpu->tgc_cpu = cpu;