From nobody Sat Jan 06 19:25:24 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T6qzS6wPJz571Pq; Sat, 6 Jan 2024 19:25:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T6qzS4v5gz3wtr; Sat, 6 Jan 2024 19:25:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704569124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P90wIuMquYea01rmA0htLUh00MOgfUoomD0ZlE0hW4k=; b=vvSofn81XmQoPuJBH2/ZHeNTGw1tXZYudrp/ubfpNZpiUFx88NDEVB6ysUDnsSr/oQghtv cSvPSZ9SayA9th3Ouw0dUrSeO6M0LYH8AJ9wwbTfMl7ER/93Zhw51Vmn0yMLu3D4f/PooP XxPn6Th0xRvdJTPhzoP5WaSPHO9EC6L33fRUzjKdM+oERqW5gmlt0L1JZO47Sqj8R7r+Co tByNwUzt19380p2aFmNhJjDCrv90wq0XPG3F64fKcFExmR++prywvYerj0PHnHnefOoj2b dQQOS0On86ljHgCc9+0+VHnBZizy4UQDhcQmOQnvMc2Qy/jFL76GA+674uH3iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704569124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P90wIuMquYea01rmA0htLUh00MOgfUoomD0ZlE0hW4k=; b=Nahctq6DEO8wMQ7A1JD6b4g3iB2CNI2tMPZQ9t34jOh0G2NlPzDtiNxNIJEyO88NEcd7Rt MOiPWNd6K2tt+kspGHdmu5WkPdorsdhMI5t7HFdAwQrwlAhL701cXXUSsFJFhPB/TjrFW+ X6T42nMYDjM9HvPafMWLVC/onIFQ3553/aNWkJBwexoH9t58ChNdkIPhdHPp3bstGXkLL3 pRD+cgSewNEEpEWl7DHEO/RHVyBPz/l6HZ2PNi+hYIksBP7JlJl0CNriVGh0XLdehcMH/Z Sm+ogKzn+u20oYskIFPoL/SWkmxgy3NTaFzWhiK49Edr5oFKoXZH4iIRRaNbuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704569124; a=rsa-sha256; cv=none; b=XAeRpfRKI0MLYWDMAXTcNuGl6DxdzBr4uaMmNZmCNjSu0YK8Ni7zok2K0WBBJ3Ho+GAcna XTpOJM1YdUYmbyHrxtTZ56NMCIVlQ+Eka4SipqZ3HXIRfI66dYqWefZFFpX++usEcl6Qkr M8H7IRNagT55F/oXxsWPsn3+++3hxMl9QnOQRDXu1lkE53fm6sLY17ND/q+CqzPVxTiuCy y+woZ719YfqriEaN88l0wO+lNXof5eTDqwBzXPODVBppSUFFRSWZTbz1Amt8Y5xyBodKxy GH9ZaX4/EjVtlyWBZsCP9S5QD7ZZhRnnUklvVYMmdx983jseZCeuXpWG9C6RjA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T6qzS3rhZztHV; Sat, 6 Jan 2024 19:25:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 406JPOsx064850; Sat, 6 Jan 2024 19:25:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 406JPO6C064847; Sat, 6 Jan 2024 19:25:24 GMT (envelope-from git) Date: Sat, 6 Jan 2024 19:25:24 GMT Message-Id: <202401061925.406JPO6C064847@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Marius Strobl Subject: git: ac0db253f944 - stable/13 - exit1(): Reword comment regarding init workaround List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: marius X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ac0db253f94487305b4274372a18da79abeaf7a3 Auto-Submitted: auto-generated The branch stable/13 has been updated by marius: URL: https://cgit.FreeBSD.org/src/commit/?id=ac0db253f94487305b4274372a18da79abeaf7a3 commit ac0db253f94487305b4274372a18da79abeaf7a3 Author: Marius Strobl AuthorDate: 2023-08-06 19:54:57 +0000 Commit: Marius Strobl CommitDate: 2024-01-05 21:53:04 +0000 exit1(): Reword comment regarding init workaround There are other relatively common reasons why init might get killed during reboot, the workaround was really not sparc64-specific. (cherry picked from commit 96c76d930656f13d3c041dc8d8f2fc3dd1e5e05a) (cherry picked from commit 28b36ecf990fc28a935ab2ce75f7504721c3a7ea) --- sys/kern/kern_exit.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c index bfa3e70f878e..bd820aae8197 100644 --- a/sys/kern/kern_exit.c +++ b/sys/kern/kern_exit.c @@ -237,10 +237,11 @@ exit1(struct thread *td, int rval, int signo) p = td->td_proc; /* - * XXX in case we're rebooting we just let init die in order to - * work around an unsolved stack overflow seen very late during - * shutdown on sparc64 when the gmirror worker process exists. - * XXX what to do now that sparc64 is gone... remove if? + * In case we're rebooting we just let init die in order to + * work around an issues where pid 1 might get a fatal signal. + * For instance, if network interface serving NFS root is + * going down due to reboot, page-in requests for text are + * failing. */ if (p == initproc && rebooting == 0) { printf("init died (signal %d, exit %d)\n", signo, rval);