From nobody Wed Jan 03 04:48:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4cfs5zWcz54ccQ; Wed, 3 Jan 2024 04:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4cfs1TpMz3BxZ; Wed, 3 Jan 2024 04:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704257301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lYHCRrWuqMS3ZFV17XtHaNoqwQwhctCmfVGsyO+tRrg=; b=lMOVgHUxf1DH0TuuCoUkf+0k4e7Jlnyt3OucSiCEt+C2ZzRxLfRd3KCOCOXgJBo8Wj5j5a VeRRVH2kEWqqgHYuplGSXQoIOHTSNPYbqNh8o6QvJyqGo7roZySk9bvxx+e3CLgOtaFK/b v5ZLSlGfOhFy0McJz18aIdO8xwVXln6onvRTp+d3opilNpkTaCy4dXpmFYMVw2CX10TNVA SD3JUfqKK/HZs5o7qUxJCggKYZsCOO/+ruSmtXoIN+eTvGTy+PVfFYGF4zAFOVZONbnSBz LGjjrR2KObM7wAMfkYvR9rAMEf90ni3rLpMcfJiTgIP51wWW8I4KCjUxsuxK4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704257301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lYHCRrWuqMS3ZFV17XtHaNoqwQwhctCmfVGsyO+tRrg=; b=S4hYrEg9gLCpTjSNJDh5+0yLQPQPl/i9thZG+BiD5//PFhoeMLjEdp9sj4ulu+Y/Wtjq9P SHbEpMpo2qLyNHhHsyHtaHNxYGkHfsKFsbvX0XbIJ5N6TkJe2HbbrCJZXCy3L7V+GJUR1Q +7BzYQUqHHuKhO2bpAZfP5eDgvmh4M8Dk8Ad7si9n2qyL5sLhcwgJkdqUpq0bzrXqQRNi6 EV49q4KVU00+cp7FDaDQNnVpyo1iSTH8bZ5kLaR4HapwOp7qqh4djdLB9gV5LBtNtMyzcq Un3ld0lbo6aT4Qi9s8mNPFR/ZW7Qi/FlHR8zcRUN7kmHbITSan7sCaUgLYwmXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704257301; a=rsa-sha256; cv=none; b=faawWfAJ+BTduv3jD60AMSGrKk5Hf8bWNly240iMDzQ2O8bJTPbmXC9c+h06n+79eT21oj HJDRxVWpYzAmg/90EEnicDH1zH/Jcs6ez5v8NGAFkk1ZbfrolBjFnlEYfGCdAMddI1sXZM wEuFEQavEAm/R5Xc2U+JwdqniF5LJtdlghezQwOTeafkSH3G6dzySbvZoRrXnOK88/lrLJ lAnaSg62FMqnxBrHmhr30OpE0hWFZbE6EOFlxutDkXEGDcRnTVq8FpWJ0ORokc/c5BVpPL lmaUiMx01QdmNAcowtpWLkkEs40sfvsX5a1Jd3nHhVEYqjMtpg9lBanDp75bCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4cfs0YhXzWvF; Wed, 3 Jan 2024 04:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4034mKEV026287; Wed, 3 Jan 2024 04:48:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4034mKKo026284; Wed, 3 Jan 2024 04:48:20 GMT (envelope-from git) Date: Wed, 3 Jan 2024 04:48:20 GMT Message-Id: <202401030448.4034mKKo026284@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: 346112fe3d7a - stable/14 - kdump: use print_mask_arg0 appropriately List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 346112fe3d7ad77001e815e87c74996f8f04cb25 Auto-Submitted: auto-generated The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=346112fe3d7ad77001e815e87c74996f8f04cb25 commit 346112fe3d7ad77001e815e87c74996f8f04cb25 Author: Kyle Evans AuthorDate: 2023-12-13 16:49:03 +0000 Commit: Kyle Evans CommitDate: 2024-01-03 04:47:21 +0000 kdump: use print_mask_arg0 appropriately Some callers are using print_mask_arg() when they should be using print_mask_arg0(); the latter should be used when all flags are optional and there's not a flag to be decoded with a 0-mask. This turns: nmount(0x6991e009000,0x8,0<>0) into: nmount(0x6991e009000,0x8,0) Reviewed by: jhb (cherry picked from commit a206524709bdfbd577bcfe76676da80b8250f84c) --- usr.bin/kdump/kdump.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c index cb8f5ff1f537..078b8a364db8 100644 --- a/usr.bin/kdump/kdump.c +++ b/usr.bin/kdump/kdump.c @@ -934,7 +934,8 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_close_range_flags, *ip); + print_mask_arg0(sysdecode_close_range_flags, + *ip); ip += 3; narg -= 3; break; @@ -1000,14 +1001,14 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break; case SYS_unmount: print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break; @@ -1465,7 +1466,7 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break;