From nobody Wed Jan 03 04:48:18 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4cfp4jmDz54cWQ; Wed, 3 Jan 2024 04:48:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4cfp2yDkz3C8K; Wed, 3 Jan 2024 04:48:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704257298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zFJpxZW/q9lSgmoYaF5CfxwjybCrZ+jm39CCsDLyl3o=; b=hx3uRgx95W0RoRU8XuHtsh0rAQmaB+SKqe6wZoCto4jZOGl8Rr+tHTfn+qGI7qpayZNvmu 2QzHzoDkROnURjfkT36ueBlyx1JcubG+LdPxWoFu/IzPdhGRFCM9bmdDAv1zIRtZixbgfY i3ZBGBC8r6ufnbiQqdkwAKzwGbitqc9hqfH0RXMdCAiEsFb2yUE22pStZZmlCHuhKThVun 1TGh5XU6xXONrCGDlI3TfihOPB/MYs4AVYHvxyYb4aMEviT60D2d7nMLyKbH6K5KLTI4fs 26N5OIlgPE/nYsS3mCvweBlu4fVNoWY2ydsTtUZ0QY0LIB/X5PSSPJMDr7N+sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704257298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zFJpxZW/q9lSgmoYaF5CfxwjybCrZ+jm39CCsDLyl3o=; b=ui5QcBeNE6lXASmkJZqmRPHWEcvscYHAQqMBbfZ5OIWGK/qDcCmim4Se5Vl6aAJDB74ROH XoFOE0Skx8yFkex1dudZYwMUtl8/29InMzB1F2hb0tVNMGb0uuNO9rAxBQXTYmBvOkXNR8 NtXm/cMdwM7Vph72PBuFLXT4UGsfrRBUD7Vbztu17zagowvbuM/zSS5SaFs+A1St5Iek57 7f4Dqd3Li1p009Q8/vCKJaHYI8LYwMxVta1TtdbKkXElNFdpvZHLOxbYdMknugSrupI3NV hq4UXZynN9xXm+3CC3sCTgG5aMfzc3/0HC4Ks0akw0a1T6egVAP0bLjgAhB8Ow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704257298; a=rsa-sha256; cv=none; b=mgFnwRLOqb9MI1i9TNi/URtorUFATR4ladBR5ujUCejPl9yuK0T5+d0wC7xAyXzO11cx6b wMkWKb+q9du3H5sEVKWv+h05Xh2tJIwixHnvevAtBd4cvmmv5k9mUm0Yay7TEjIYIzurkl JCTXI4khmq49ntnWq1+mlUKXC5EDJQp6axZMfRFNk9STugliDprxfCRuH4NLllG3dACmnl cDWY0dWrHtVi5h4qklExmeQk/kr3TpK3754DEgUq/tIi8v2ITAODYG0iEGJhgjsPQNi5/8 VQnYy9F2yXCOPw7Ic2bvh3GkcdQdP6aXx+8SWr+s6U24yzoemv/xiu7XkiGRaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4cfp1jYqzWkt; Wed, 3 Jan 2024 04:48:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4034mIhs026016; Wed, 3 Jan 2024 04:48:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4034mI2R026013; Wed, 3 Jan 2024 04:48:18 GMT (envelope-from git) Date: Wed, 3 Jan 2024 04:48:18 GMT Message-Id: <202401030448.4034mI2R026013@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: ee0e6ac14776 - stable/13 - kdump: use print_mask_arg0 appropriately List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ee0e6ac14776ca4c131d2178e790a3c4d85c682f Auto-Submitted: auto-generated The branch stable/13 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=ee0e6ac14776ca4c131d2178e790a3c4d85c682f commit ee0e6ac14776ca4c131d2178e790a3c4d85c682f Author: Kyle Evans AuthorDate: 2023-12-13 16:49:03 +0000 Commit: Kyle Evans CommitDate: 2024-01-03 04:47:27 +0000 kdump: use print_mask_arg0 appropriately Some callers are using print_mask_arg() when they should be using print_mask_arg0(); the latter should be used when all flags are optional and there's not a flag to be decoded with a 0-mask. This turns: nmount(0x6991e009000,0x8,0<>0) into: nmount(0x6991e009000,0x8,0) Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D43007 (cherry picked from commit a206524709bdfbd577bcfe76676da80b8250f84c) --- usr.bin/kdump/kdump.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c index 4938f83d215f..70d039e387d4 100644 --- a/usr.bin/kdump/kdump.c +++ b/usr.bin/kdump/kdump.c @@ -880,7 +880,8 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_close_range_flags, *ip); + print_mask_arg0(sysdecode_close_range_flags, + *ip); ip += 3; narg -= 3; break; @@ -946,14 +947,14 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break; case SYS_unmount: print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break; @@ -1411,7 +1412,7 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break;