From nobody Tue Jan 02 21:43:30 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4RDg1bKfz55tpL; Tue, 2 Jan 2024 21:43:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4RDg0sSrz3Fw1; Tue, 2 Jan 2024 21:43:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704231811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qbQqRC+S3dcbPjr2kony+V287EMsmkQQnsz6boNjyrY=; b=SV2nDNvSkMwAuAuo19u1WTbIz2zlXsEHwz7SrEO4FYNBuKuKxw/wGJGKU42SqhM18e6mFx 9d06ccLgF2+lKFw8hNPYeLmRN1FDMNeRy8DAqf/g5fnznhLSQPTJke6ixK01yUZtC9QoVr 6m17tlOyA0UtpBgTO4cfaJxvrpOhSR/bW/cJY3Tq4MS3pTIjxNkCNgvbcvKtHKAF5RyjsO bErSqL2LL9xyF4a11awQhiayfx+Gdp0RPdyWryLCP+C0S3ICuDb+RHrWKX1eDIhPHY0iHZ Jx47ZkJ/VoW3aKXCoIuLp9gD3v/rlSkzna3H/KgePzFdXzUapwJ+BYRBUOZ9jA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704231811; a=rsa-sha256; cv=none; b=V5r5z567wa6YlQvvmTK9C5BuwjSWlrVF2PGDJV+gM0vuiJ8/X/u7Ye4u/pZ62vRF9WeOZL eP4GWEHDJWk2HA55QsPg+a9g6b+H3JvLcCTuLdqPD8ujfda7UBADaNDnPqhxlAYwL5H52u 4oeNgsBffVBKVz41tjrcpL1rVN+CDVUxbHNLcF3w/HQ45u8J82Kh62dHO1P1kBbskCj9ZO 4Ao7ufnhMukfjAYbcGwTZ3bIyllcRkz83VHMe9jk8nDMuqnOsP/IffrSGFiufc8t4pbaYj nDM9zcPUoIrResMqogat5H0wFqxnMBmIGmjN83pmIxnVR3SrooG7NkShTxeT8g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704231811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qbQqRC+S3dcbPjr2kony+V287EMsmkQQnsz6boNjyrY=; b=xtK9SlP1N37GBgiVXZQzj5zYWNWPwF85gJCGFVpWJ1DZEQYprwkOrSUi6AHjkTgqDoxydA BHseOZ8tUilAU36MpLUVQUrSWwUcdlmSM3XWYdngExVbdw3c10yfwXiSfToeI0yBkmC4nt 2jcTKwSNKgwR4nyvOmZy+dR26ijTFXO+j/3UFlRPocoibh3ogLzlWVYHvuqsc30yFQW+Es pY4NWvS+BlEzN8bGqCAfh9L92B0qR1BTDl4gonoIBYVxKX0732I36CrE0bZhsp5Lx9E/oL 0oKq04JSLoq5QIOBsWSA6NqGUhzGFlw+8WZRf71woFhPW6tMsnXx/2hi0qw6Pg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4RDf71z0z1HMv; Tue, 2 Jan 2024 21:43:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 402LhU7s022180; Tue, 2 Jan 2024 21:43:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 402LhUku022177; Tue, 2 Jan 2024 21:43:30 GMT (envelope-from git) Date: Tue, 2 Jan 2024 21:43:30 GMT Message-Id: <202401022143.402LhUku022177@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Jason A. Harmening" Subject: git: 10f2e94acc1e - main - vm_page_reclaim_contig(): update comment to chase recent changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jah X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 10f2e94acc1e1f01f9342a99cbf28708525885c3 Auto-Submitted: auto-generated The branch main has been updated by jah: URL: https://cgit.FreeBSD.org/src/commit/?id=10f2e94acc1e1f01f9342a99cbf28708525885c3 commit 10f2e94acc1e1f01f9342a99cbf28708525885c3 Author: Jason A. Harmening AuthorDate: 2024-01-02 21:33:59 +0000 Commit: Jason A. Harmening CommitDate: 2024-01-02 21:39:36 +0000 vm_page_reclaim_contig(): update comment to chase recent changes Commit 2619c5ccfe ("Avoid waiting on physical allocations that can't possibly be satisfied") changed the return value from bool to errno. Adjust the function description to match reality. --- sys/vm/vm_page.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 72057f2fc9f5..4429ec067673 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -3014,11 +3014,13 @@ unlock: * * Reclaim allocated, contiguous physical memory satisfying the specified * conditions by relocating the virtual pages using that physical memory. - * Returns true if reclamation is successful and false otherwise. Since + * Returns 0 if reclamation is successful, ERANGE if the specified domain + * can't possibly satisfy the reclamation request, or ENOMEM if not + * currently able to reclaim the requested number of pages. Since * relocation requires the allocation of physical pages, reclamation may - * fail due to a shortage of free pages. When reclamation fails, callers - * are expected to perform vm_wait() before retrying a failed allocation - * operation, e.g., vm_page_alloc_contig(). + * fail with ENOMEM due to a shortage of free pages. When reclamation + * fails in this manner, callers are expected to perform vm_wait() before + * retrying a failed allocation operation, e.g., vm_page_alloc_contig(). * * The caller must always specify an allocation class through "req". *