From nobody Tue Jan 02 00:37:21 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3v7j58bJz55yX1; Tue, 2 Jan 2024 00:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3v7j41wpz3Hqb; Tue, 2 Jan 2024 00:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704155841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Lg9HWwwzrTYi+170cvdnPjmkpAZFvnn0vnogXdr+qLU=; b=c56VhxFOrt/k5EKi8j6AdiiDDdk6jtp3i795ZeocB3i5u6TrRnbHx7tIsfW6T0aBuV9SaH 4O2RC0wV7UFn40vei/HwfJuJemIt/yM/cLwR3drJfU8O8FkcSRfujzJ4j37NejRxeSSOmt 7SJULlljiLBS5en2jeEeCUjHGBmP8n0HOyvVP50VvtJu6Qmd870FRaolh+mnRPIemxy5cc YDyHTvJUyiv8YOEMCEzWeFPdB3B1Zw3f+B2ao9jQS5Y/nU6H627Kjzo+KdSXCrIp2mJHIw /ovuhYmp2SJrZyq53VFlO6AZvieeIiVEY1/ymG2qTkBrJrfWCJA3SnqJH1rr8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704155841; a=rsa-sha256; cv=none; b=nk5GVHkqAti6oB2Eb2ySnXVnnqRIpEML/FBDQPdv0DCM2slGf5G/HtD5hbuS6xxUntJ3k6 xEOAAvXk57KXql3pm7r1y7OiBpr4sF6lnbQ1bx8KYhPjAAkT6X0wdc183daGQyFqittpKY mdrA2bdo7kU2PXBmMxdtGQBqX8ZqNtOKMxuvCAArlfS/QgaYaoRCq0mpnJdYKbSkD1QyEV TQOeL33xwzx5wtXrVVEqHER6v8Z6kkhui5/8yffj3Slje6JkO2TRdJ+uUfrjP7/Q1FDos+ 7zerCTPw9NWNy3B3arp6N5ky3MhKVz59f19910k2tXpWbs12eXs2P3FXyLAsUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704155841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Lg9HWwwzrTYi+170cvdnPjmkpAZFvnn0vnogXdr+qLU=; b=gnyt7PgvBKMV6/QsDUaVbr3zH9KJQ+UrtjN1mqI61+F7zJwyUWzp35f7ERA/QdopdVaRm6 0Je6h+Z34mowptVkEJ1Ik2VelD2b9Dg0y0O14nhCfCwZZ++Xkz+oLXerDA2suFr8LJtzj8 szHDAUgWjbaZ6EFuAa8bGtmd+kuapccAQgWSjphBSSBs3fSHx2fu/wuFYtjY7309cAEqzo IbFdsq0RJ/VW3yCFaFPqPGY/j8hXDyIZNpVWJKcigSleieAoquZWAErqqpJBbFMyBEGDGu 0D0ITjZm8SVwgkFSWIbRq+gu2FRn/uCeA4CurTGd8b6fKLEV4ea6Spovseupsw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3v7j2xydzfYL; Tue, 2 Jan 2024 00:37:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4020bLex085334; Tue, 2 Jan 2024 00:37:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4020bLSq085331; Tue, 2 Jan 2024 00:37:21 GMT (envelope-from git) Date: Tue, 2 Jan 2024 00:37:21 GMT Message-Id: <202401020037.4020bLSq085331@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: eb5a0f6271a0 - stable/14 - powerpc: Avoid ignoring copyin()'s return value List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: eb5a0f6271a01aafe39bd232f2f91133a8e36fbc Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=eb5a0f6271a01aafe39bd232f2f91133a8e36fbc commit eb5a0f6271a01aafe39bd232f2f91133a8e36fbc Author: Mark Johnston AuthorDate: 2023-12-26 01:40:16 +0000 Commit: Mark Johnston CommitDate: 2024-01-02 00:29:50 +0000 powerpc: Avoid ignoring copyin()'s return value A recent change made it possible for cpu_set_upcall() to return an error. Do that here instead of ignoring an error from copyin(). Reviewed by: jhibbits MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D43105 (cherry picked from commit bdf03b4bcc4a9aa0be503dbc64415e6b0b845fbc) --- sys/powerpc/powerpc/exec_machdep.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/powerpc/powerpc/exec_machdep.c b/sys/powerpc/powerpc/exec_machdep.c index 0c10115c4e25..94e561ddd33a 100644 --- a/sys/powerpc/powerpc/exec_machdep.c +++ b/sys/powerpc/powerpc/exec_machdep.c @@ -1155,6 +1155,9 @@ cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, { struct trapframe *tf; uintptr_t sp; + #ifdef __powerpc64__ + int error; + #endif tf = td->td_frame; /* align stack and alloc space for frame ptr and saved LR */ @@ -1182,10 +1185,12 @@ cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, tf->srr0 = (register_t)entry; /* ELFv2 ABI requires that the global entry point be in r12. */ tf->fixreg[12] = (register_t)entry; - } - else { + } else { register_t entry_desc[3]; - (void)copyin((void *)entry, entry_desc, sizeof(entry_desc)); + error = copyin((void *)entry, entry_desc, + sizeof(entry_desc)); + if (error != 0) + return (error); tf->srr0 = entry_desc[0]; tf->fixreg[2] = entry_desc[1]; tf->fixreg[11] = entry_desc[2];