From nobody Mon Jan 01 00:10:11 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3GZq6Nqrz55djm; Mon, 1 Jan 2024 00:10:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3GZq5gFvz4RwV; Mon, 1 Jan 2024 00:10:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704067811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dFG9uGAd3pChV4On/4da1fbVcWm0doQKdORZhT7acWU=; b=K0DDwnYAMHefRaW7CMPNbBJSzesr5dd7ngr9awqRtA3wqqPqyV73cAl7ckrX8ji7LDH+Ee fNHWBzhk7QYpY15+hdYTsiidAIw5JWnXuaMy65oVCj9BrWxRQDA7lfP9smO7302N0Y1YXO tbs63zvsbLHO2T4BLqju+ZNdRrZdman4wu7DS02Yk/KYMvJsMeqWgD0DUgQMuGQD5tKAQE A7+N5AAaURXv1ysy46zUMjAKqQ6vlIbOzak0oa98NAMNH3AfuowUeMtjQHIz/HZRdoLZKC 5UrQzBuYkMZGpu1jFB9VvPgsTxeQ1UzQL8d3terZfs3wUIvohId79j7KnxATzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704067811; a=rsa-sha256; cv=none; b=IjY9ruMvOnwcTOAY9n5D5Qh/wKd+TyEyJ0A36DFZwNvLdzgYCUuZmNGnqLGRj64RZJiOVS 8aS3JXco36oJKiD8bikep6+CEycboQN+OgHUnhsOTrIxRzeU2rm4ImjHXjBl81h38GBReg JXHyNJFYSJQNObC7B20SFJw1qjx52hlU2YHTgfChwFB1q8J0iKn8aLQIeK3uYCMfjyWZSv 8fOU+WQsNAUFJnch41WV4azzse6SwHoOX00jBFAjOLy7xzO8kRFszlOR6Pvt1fJpC0lLdt QxB2O0OTbEibGto6Gr7pJ0saouB7dIE2ARjS7v2Uz7UTGYafek95QU521ST+BQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704067811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dFG9uGAd3pChV4On/4da1fbVcWm0doQKdORZhT7acWU=; b=hh7c8+RjFYK/P/49cvDnOjEZyhu62Zu/++sbbu39vCJT8YG0S7EoT2RwVO9QhwsDsvQjOz CWJYtr2Pjs5VyIq3eI3BwT8gAolwD7nI7+yMxQqH3RGK+pJJ7tbRafTaSVMR4otyIdtWVW MBE48+HcbMZto8oMCs9yAxugC4R07WBoAeYdhlpesqJNFFlN5z/3Qv1sNwdZkzuNV4MXBb /mdr08no8wAdqhA7fORXLo9SRhj4ar+UvZjLSwFs+akQFijfuJnP6iltQGWLU8CAiKY9AV r8ArVPyCgXJzhrXCDt4g41UcF7V3TjTR15u89JLCICjQM+3TiVrAydLaMCLdsg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3GZq4lS4zw1Y; Mon, 1 Jan 2024 00:10:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4010ABnA020147; Mon, 1 Jan 2024 00:10:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4010AB7Q020141; Mon, 1 Jan 2024 00:10:11 GMT (envelope-from git) Date: Mon, 1 Jan 2024 00:10:11 GMT Message-Id: <202401010010.4010AB7Q020141@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 91d2a093dfac - main - isp: Fix endianness conversion in isp_read_flash_data() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 91d2a093dfaccdf288db663b6e9d47539ea1c1bf Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=91d2a093dfaccdf288db663b6e9d47539ea1c1bf commit 91d2a093dfaccdf288db663b6e9d47539ea1c1bf Author: Mark Johnston AuthorDate: 2023-12-31 23:52:52 +0000 Commit: Mark Johnston CommitDate: 2023-12-31 23:59:06 +0000 isp: Fix endianness conversion in isp_read_flash_data() Reported by: Jenkins Fixes: 10ed63fc06cb ("isp(4): Rework firmware handling/loading") --- sys/dev/isp/isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/isp/isp.c b/sys/dev/isp/isp.c index aa2f1fb74c59..b53171add5f5 100644 --- a/sys/dev/isp/isp.c +++ b/sys/dev/isp/isp.c @@ -4575,7 +4575,7 @@ isp_read_flash_data(ispsoftc_t *isp, uint32_t *dwptr, uint32_t faddr, uint32_t d rval = isp_read_flash_dword(isp, faddr, dwptr); if (rval != ISP_SUCCESS) break; - htole32(*((uint32_t *)(dwptr))); + *dwptr = htole32(*dwptr); } return (rval);