From nobody Thu Feb 22 20:10:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TgkmR0WBKz5BKMs for ; Thu, 22 Feb 2024 20:11:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TgkmQ5drzz4s8G for ; Thu, 22 Feb 2024 20:11:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-564372fb762so58320a12.0 for ; Thu, 22 Feb 2024 12:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1708632660; x=1709237460; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xN2jAPHWu1hUzRDZcsqA/Far3O8FpaiMVVbq4GuoqoM=; b=qvuoFyd/9qW0f0/DBKdCQAcYkL+sX8uoB6MDI1RxBWmHlYm8MEb7gDGHmMgzrVB3jE dOHYOKSgpNmcsiMTieh49thg4/OF5atMzaONAE+HvQOfGoyD1vAnBADs9EBNAOV3zJi8 w2tIx7tpAb1VTDzxp4cT/Nfi6bpCQCExVu+CUUVLTbU2bpRNYan+s0I2ptYNl02leWIZ Ov8wQlFemeXQtTd7Gh9keJZqe9sofE+qGjUV/wM4IpTaiRVowcYWP3VRzQgB2Dx/GnWk VR9NL9hQoAybd96/59o01EVx9gS/7o5v1qP3B2ZgaI+G2HO2GeASPQ7oOh5afEZFWOlv pW2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708632660; x=1709237460; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xN2jAPHWu1hUzRDZcsqA/Far3O8FpaiMVVbq4GuoqoM=; b=tv5dT97GCgq8pJH6QTEBT7m8lSXJW+Lbe6aHCHRA/gRTBHBhCKEM3amz1bXqtmzlK3 OdcAB4+P19DoccHE5dtSugg+QjVqPEi5NC7tglZUAnTvN1IGEqngAOT4QxDT1NTQGnhp B4Yg7Hyd1kfKNXWaQ+ghIttDeApNlO4lBwltnleW9WvYEiCjxqN4UH8irnwX4RZUEZ8x fur1Tjwf8Jz23vV5Abr7NBYA0csIijmT7izl1YYjkNLonMnZqEYSrvk7ZnRKu9Dybpjd d3I56bQM9oqR3nLMsUsUFXuonpb061i4RLiT99yn64iwznNMC/z5BVspYRBKfWpre7is 2JhA== X-Forwarded-Encrypted: i=1; AJvYcCX3qpz513mUzrT91qvQpXHpJxDlJvfjZ2fx+elVJpnE4jZghw39tCpDjZSm2bly/qC1Wm1UIRG6xTJVDRWZJmls78Hy850EIItd4llj3NRD X-Gm-Message-State: AOJu0Yy8qTftEtGls1cluyBVr5WzThovMxJAYUERbRKyichcFdniMCue aBrr2SWjzloNgq0bpzOgki7LGJyEtI+ILMfasMsWJjHLKbQ3N2XAS5ZfAjR0zsIsclSKGPQKceL GBnSkOZK5DFgSpUA1I+oU66I9bOHVdF5OxfcLVRSDXdXOMIsILIg= X-Google-Smtp-Source: AGHT+IH/gBt3b+6GzPE8Ve9z3CzVlXs3S5IOdvyFVEE61J/vWNZlAm0r6XGBWx9wfAsutMWZbQg1T3xPoTYO11izg30= X-Received: by 2002:aa7:d713:0:b0:564:3b2e:2a2e with SMTP id t19-20020aa7d713000000b005643b2e2a2emr9298621edq.9.1708632659990; Thu, 22 Feb 2024 12:10:59 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202402211855.41LItsm2033633@gitrepo.freebsd.org> <23101a96-4901-4086-bdbf-dfbab2b66e49@FreeBSD.org> In-Reply-To: <23101a96-4901-4086-bdbf-dfbab2b66e49@FreeBSD.org> From: Warner Losh Date: Thu, 22 Feb 2024 13:10:48 -0700 Message-ID: Subject: Re: git: 47e073941f4e - main - Import the kernel parts of bhyve/arm64 To: John Baldwin Cc: Andrew Turner , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c02ced0611fe0a4f" X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4TgkmQ5drzz4s8G X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --000000000000c02ced0611fe0a4f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2024 at 11:30=E2=80=AFAM John Baldwin wro= te: > On 2/21/24 10:55 AM, Andrew Turner wrote: > > The branch main has been updated by andrew: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D47e073941f4e7ca6e9bde3fa65abbfc= fed6bfa2b > > > > commit 47e073941f4e7ca6e9bde3fa65abbfcfed6bfa2b > > Author: Andrew Turner > > AuthorDate: 2024-01-09 15:22:27 +0000 > > Commit: Andrew Turner > > CommitDate: 2024-02-21 18:55:32 +0000 > > > > Import the kernel parts of bhyve/arm64 > > > > To support virtual machines on arm64 add the vmm code. This is > based on > > earlier work by Mihai Carabas and Alexandru Elisei at University > > Politehnica of Bucharest, with further work by myself and Mark > Johnston. > > > > All AArch64 CPUs should work, however only the GICv3 interrupt > > controller is supported. There is initial support to allow the GIC= v2 > > to be supported in the future. Only pure Armv8.0 virtualisation is > > supported, the Virtualization Host Extensions are not currently > used. > > > > With a separate userspace patch and U-Boot port FreeBSD guests are > able > > to boot to multiuser mode, and the hypervisor can be tested with t= he > > kvm unit tests. Linux partially boots, but hangs before entering > > userspace. Other operating systems are untested. > > > > Sponsored by: Arm Ltd > > Sponsored by: Innovate UK > > Sponsored by: The FreeBSD Foundation > > Sponsored by: University Politehnica of Bucharest > > Differential Revision: https://reviews.freebsd.org/D37428 > > FYI, sys/arm64/vmm/vmm.c shares a fair bit of code with sys/amd64/vmm/vmm= .c > and looks to be derived from the amd64 file, so I think it should preserv= e > NetApp's copyright line in addition to Mihai's. > In general, the advice I've been giving is that one should retain copyrights when there's at least 10%-20% remaining of the original work. And one should hesitate to add them unless you've contributed 10%-20% or more to the work (ideally more, but sometimes that's gets squishy because the underlying law is based on words like substantial and de-minimus, which don't translate well to line counts, and for large works what is substantial can be a bit subjective). If they share so much, maybe we should also look at sharing directly, rather than by cut and paste in the future. Warner --000000000000c02ced0611fe0a4f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 22, 2024 at 11:30=E2=80= =AFAM John Baldwin <jhb@freebsd.org> wrote:
On= 2/21/24 10:55 AM, Andrew Turner wrote:
> The branch main has been updated by andrew:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D47e073941f4e7ca6e9bde3fa65abbfcfed6bfa2b<= /a>
>
> commit 47e073941f4e7ca6e9bde3fa65abbfcfed6bfa2b
> Author:=C2=A0 =C2=A0 =C2=A0Andrew Turner <andrew@FreeBSD.org> > AuthorDate: 2024-01-09 15:22:27 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Andrew Turner <andrew@FreeBSD.org> > CommitDate: 2024-02-21 18:55:32 +0000
>
>=C2=A0 =C2=A0 =C2=A0 Import the kernel parts of bhyve/arm64
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 To support virtual machines on arm64 add the vmm c= ode. This is based on
>=C2=A0 =C2=A0 =C2=A0 earlier work by Mihai Carabas and Alexandru Elisei= at University
>=C2=A0 =C2=A0 =C2=A0 Politehnica of Bucharest, with further work by mys= elf and Mark Johnston.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 All AArch64 CPUs should work, however only the GIC= v3 interrupt
>=C2=A0 =C2=A0 =C2=A0 controller is supported. There is initial support = to allow the GICv2
>=C2=A0 =C2=A0 =C2=A0 to be supported in the future. Only pure Armv8.0 v= irtualisation is
>=C2=A0 =C2=A0 =C2=A0 supported, the Virtualization Host Extensions are = not currently used.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 With a separate userspace patch and U-Boot port Fr= eeBSD guests are able
>=C2=A0 =C2=A0 =C2=A0 to boot to multiuser mode, and the hypervisor can = be tested with the
>=C2=A0 =C2=A0 =C2=A0 kvm unit tests. Linux partially boots, but hangs b= efore entering
>=C2=A0 =C2=A0 =C2=A0 userspace. Other operating systems are untested. >=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0Arm Ltd
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0Innovate UK
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation >=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0University Politehnica o= f Bucharest
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D37428

FYI, sys/arm64/vmm/vmm.c shares a fair bit of code with sys/amd64/vmm/vmm.c=
and looks to be derived from the amd64 file, so I think it should preserve<= br> NetApp's copyright line in addition to Mihai's.

In general, the advice I've been giving is that one sh= ould retain copyrights when
there's at least 10%-20% remainin= g of the original work. And one should hesitate to add
them unles= s you've contributed=C2=A010%-20% or more to the work (ideally more, bu= t sometimes
that's gets squishy because the underlying law is= based on words like substantial
and de-minimus, which don't = translate well to line counts, and for large works what
is substa= ntial can be a bit subjective).

If they share so m= uch, maybe we should also look at sharing directly, rather than by
cut and paste in the future.

Warner
<= /div> --000000000000c02ced0611fe0a4f--