From nobody Wed Feb 21 15:51:38 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tg13b57WLz59pss; Wed, 21 Feb 2024 15:51:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tg13b0LtLz4HmD; Wed, 21 Feb 2024 15:51:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708530699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bMZrX4YnS56F5g9F8d/Q7tB7cEy4z7DrKIfI82bEIAk=; b=qwdrD1kRDSczG7p2cFSlMkOKzGXd1vMtkUtGFOOojWseZ1X8SdwFaRoQx2awAgl6hZUWAU yXMKWi/dlPQtFjeZAEcLbt9MFzXJlGB3JAztS8/NON799r/PPbfUsEvSmu9+bseyPQGzaT 3Zg+kzW8m9ltO8IC/+zbPeoYbNN8A2j2+JCym3mBcCXo5nfY8TA27ZOGXUwMopQBKGrs7w MdPMn7RNvG13VdNJahf1zDkKDXjVa92Ebt5Z+W9RoTh6KFwQD0RfWkihYjcgMcl726cJmQ tjsq3dfKWJ7vNfZqiDbTh7IeHcq1sykIAhmTiSiyBM54u5hkWvk3Xyub1MzpPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708530699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bMZrX4YnS56F5g9F8d/Q7tB7cEy4z7DrKIfI82bEIAk=; b=r7jmdD1fYfwnrHocfbjRVa56hoaZ1mCpz057xl7k26y376tzBl+mVQTDO/+W6Wd3rz62b/ UILydpDf2XYAEmrOmEoaoLcK4hQeBRAPl7OteIgxzBeQEOYTYunOAudbVfqIX6hG5Qj2OV oPVsOSM0c4qN4TJC6hEvPVqxAibJVkG/v7dtOTkHzW3iO+AI89FGmKZTxZpq0RtoLWbmvY H2imn3B+Yh2zRnOGMrPImFsQkDLW6Pi7opNdVwFfyuKoyVGaAP3VRXuw6m2fSzM78cbP5K bFpGnZUfYnBRVw3TyOeHCjuNqx5mW6r4xsnAH5b5pMT6h5Yvwm6RZYKs2gi9wA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708530699; a=rsa-sha256; cv=none; b=Iqz7gbrmJynPlBQ6BIMvI59U3V2m3wSV23VGbTUV2wZrnlkcP7bz+ArI2RduW9VAiY1Zro zBCxmlVGrGNkINpx9Uvu6aJkMP5AyTEeQeTyXaanpgpSpY9GrW+h5Gc6cbg8bCLQAeFy8u NtlFQ17HeepxH0PSPIdq3M3wrpT6v1VxUHBWUdkzXR/5HWd1ZoXfWMmmn9LQbl/7hU/lPD 0Oj1Xe9hDzPhAyj+54sd8r+OUMgJzQHue2bGOkTBr6H7oT7AJri2hd2JjmIv8/PK7AF7kP UtHrwmPH2oAS8SQn8AA2CzWo4EMZPvaO99O320YQPEXU3RsAx2JEKY8Fs2PMaw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tg13Z6YKwz18MB; Wed, 21 Feb 2024 15:51:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41LFpccp023946; Wed, 21 Feb 2024 15:51:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41LFpcpZ023943; Wed, 21 Feb 2024 15:51:38 GMT (envelope-from git) Date: Wed, 21 Feb 2024 15:51:38 GMT Message-Id: <202402211551.41LFpcpZ023943@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: b2822c40f61d - main - loader/efi: Make gcc friendlier by move md_dev List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b2822c40f61d351bf8a4cac87e12521db06ff962 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=b2822c40f61d351bf8a4cac87e12521db06ff962 commit b2822c40f61d351bf8a4cac87e12521db06ff962 Author: Warner Losh AuthorDate: 2024-02-21 15:50:31 +0000 Commit: Warner Losh CommitDate: 2024-02-21 15:51:34 +0000 loader/efi: Make gcc friendlier by move md_dev Move the extern struct devsw md_dev out of the function. gcc is happier with this arrangemnt often. However, we really should move it to a header file, but that requires a bit of a rework of md support and config. Sponsored by: Netflix Reviewed by: manu, tsoome Differential Revision: https://reviews.freebsd.org/D44008 --- stand/efi/loader/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stand/efi/loader/main.c b/stand/efi/loader/main.c index d7cffe5f6df9..5944c383574e 100644 --- a/stand/efi/loader/main.c +++ b/stand/efi/loader/main.c @@ -278,10 +278,11 @@ probe_zfs_currdev(uint64_t guid) #endif #ifdef MD_IMAGE_SIZE +extern struct devsw md_dev; + static bool probe_md_currdev(void) { - extern struct devsw md_dev; bool rv; set_currdev_devsw(&md_dev, 0);