From nobody Wed Feb 21 14:01:57 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tfyd14GFHz5CF0T; Wed, 21 Feb 2024 14:01:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tfyd12FyGz4gdh; Wed, 21 Feb 2024 14:01:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708524117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eetsiB6vW2oZBJfO8zwI/8y4PPfUSt8jQk4r8Q606j8=; b=PV47524qj9/jgre8P3ywC79MQZ2ASj+YUFWDl0olg8WxtlQeBA6YbpxUrqud/3QHL6mFSZ nPjg4EQ5ppIwH7/9QtvWuvlZuNc55S7TvhX3EPMW0hWwdC8XL2YVKGCrikYAVy6aOC9deh 7RS3VWmmKh1Y/37Q/Rt5KK8tmLcVvY9heg32mYGjhY1lXLnH+/LSoyWV3AQR05ARwbItUm DZZHJTJ0YQLpy8DRDH5VN09IRI7EFKvxauXb5npC9oGNVM8qpMRfHcPRDeSDbNxalmwACq jMi5zD+nwUkS5r+YzcS6iJUx5G/LVjWG1qdpWFd7+21pHQRIw+Qu6uaL1qdkMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708524117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eetsiB6vW2oZBJfO8zwI/8y4PPfUSt8jQk4r8Q606j8=; b=xHGBnY4JDBNWFU2E4ZwHKeCpb7pwtcTBW+K5ZLeeUi0KkbaZyKS8sLT7ji7uF27AfR+IoV wzOeUOMGEw5CDvMYWy/RyahDKu2BL19Bu7K/WP8BPbp7y7nZDsqf/zWQrLMW22Yg/indjm g3IIm1OUx0/TgvtMmvzmHgldy5WKTcsVs/NhF1jupD8UKBnJowv3/gRF5AOqiF4qge8Rjt vwU/XHlLhTgH4HeAejSnjF+WU3ObLaYZySZvBdFREPhfI1Be0J8L81osbs5pSDGcnJEPj5 PThWcy0Rxuv+Aps8bFQGQNt+r9st9G70nJCrBiLLQL1nnrp7+/xvt7eftZe7+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708524117; a=rsa-sha256; cv=none; b=NVD0/dFrQEA+Cb3gg8Jz7Tf/AgOPuHz9mn0PDMSupmtJHubIUI+B2BiHcoIiXta04+RiIg CH9QrLzPq/emb5tIDF5srLjMfcyGG7RnwVbb5HuAJRX0qPix7fanqSSzXZGpYhxI1fRQPG 3jj0E3y1VyC+H0bqXCl+fge8osa6wkjvREarFjH0dPQAxCpbHB4fnnrF2vTbiBTxSW1vg1 ckFvQwU5lOIuYih8SFs0FEZ6aCPJ/WWyVsIm5+DrgXWosCtZJCpuHlYp9ngotW0DgalRsH F45aVa6Sd9Z4h79nDtbyLUMN2w1OgccCwKOWFY12mtseYGVUoM9FYTO+p9pFRw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tfyd11MTPz1569; Wed, 21 Feb 2024 14:01:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41LE1vNi080339; Wed, 21 Feb 2024 14:01:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41LE1vSv080336; Wed, 21 Feb 2024 14:01:57 GMT (envelope-from git) Date: Wed, 21 Feb 2024 14:01:57 GMT Message-Id: <202402211401.41LE1vSv080336@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 88bdc4bb60df - releng/13.3 - heimdal: Fix NULL deref List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.3 X-Git-Reftype: branch X-Git-Commit: 88bdc4bb60df6aab4457d244c5fbf4b56b22ff6d Auto-Submitted: auto-generated The branch releng/13.3 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=88bdc4bb60df6aab4457d244c5fbf4b56b22ff6d commit 88bdc4bb60df6aab4457d244c5fbf4b56b22ff6d Author: Cy Schubert AuthorDate: 2024-02-15 15:41:07 +0000 Commit: Cy Schubert CommitDate: 2024-02-21 14:01:48 +0000 heimdal: Fix NULL deref A flawed logical condition allows a malicious actor to remotely trigger a NULL pointer dereference using a crafted negTokenInit token. Upstream notes: Reported to Heimdal by Michał Kępień . From the report: Acknowledgement --------------- This flaw was found while working on addressing ZDI-CAN-12302: ISC BIND TKEY Query Heap-based Buffer Overflow Remote Code Execution Vulnerability, which was reported to ISC by Trend Micro's Zero Day Security: CVE-2022-3116 Obtained from: upstream 7a19658c1 MFS requested by: re (cperciva) Approved by: re (cperciva) (cherry picked from commit fc773115fa2dbb6c01377f2ed47dabf79a4e361a) (cherry picked from commit 6b421e431a2de6eb9e8bd670efffe76e6617d520) --- crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c index b60dc19ad8e3..48542f06fcbe 100644 --- a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c +++ b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c @@ -605,7 +605,7 @@ acceptor_start * If opportunistic token failed, lets try the other mechs. */ - if (!first_ok && ni->mechToken != NULL) { + if (!first_ok) { size_t j; preferred_mech_type = GSS_C_NO_OID;